All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
To: "kusumi.tomohiro@gmail.com" <kusumi.tomohiro@gmail.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"fio@vger.kernel.org" <fio@vger.kernel.org>
Cc: Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: RE: [PATCH 8/8] Fix num2str() output when modulo != -1U
Date: Tue, 4 Apr 2017 20:46:46 +0000	[thread overview]
Message-ID: <TU4PR84MB01760F9E5030FAF73E7B14BDAB0B0@TU4PR84MB0176.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20170404202218.52260-8-tkusumi@tuxera.com>



> -----Original Message-----
> From: fio-owner@vger.kernel.org [mailto:fio-owner@vger.kernel.org] On
> Behalf Of kusumi.tomohiro@gmail.com
> Sent: Tuesday, April 4, 2017 3:22 PM
> Subject: [PATCH 8/8] Fix num2str() output when modulo != -1U
...
> @@ -62,6 +62,9 @@ char *num2str(uint64_t num, int maxlen, int base, int
> pow2, int units)
>  		break;
...
> +	sprintf(fmt, "%%.%df", (int)(maxlen - strlen(tmp) - 1));
> +	sprintf(tmp, fmt, (double)modulo / (double)thousand[!!pow2]);

I suspect one of the goals of that function was to restrict itself
to integer math and avoid invoking the floating point unit (which
might not even exist on some CPUs).



  reply	other threads:[~2017-04-04 20:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 20:22 [PATCH 1/8] Don't silently terminate td when no I/O performed due to error kusumi.tomohiro
2017-04-04 20:22 ` [PATCH 2/8] dump_td_info() doesn't really need to be a function kusumi.tomohiro
2017-04-04 20:22 ` [PATCH 3/8] Add assert(0) to DDIR_DATASYNC sync path if fdatasync(2) is unsupported kusumi.tomohiro
2017-04-08 17:02   ` Jens Axboe
2017-04-04 20:22 ` [PATCH 4/8] Make lib/prio_tree.c a stand-alone library kusumi.tomohiro
2017-04-04 20:22 ` [PATCH 5/8] Make lib/memalign.c " kusumi.tomohiro
2017-04-04 20:22 ` [PATCH 6/8] Make lib/num2str.c a stand-alone library by adding lib/num2str.h kusumi.tomohiro
2017-04-04 20:22 ` [PATCH 7/8] Fix num2str() output when maxlen <= strlen(tmp) kusumi.tomohiro
2017-04-04 20:22 ` [PATCH 8/8] Fix num2str() output when modulo != -1U kusumi.tomohiro
2017-04-04 20:46   ` Elliott, Robert (Persistent Memory) [this message]
2017-04-08 17:05 ` [PATCH 1/8] Don't silently terminate td when no I/O performed due to error Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TU4PR84MB01760F9E5030FAF73E7B14BDAB0B0@TU4PR84MB0176.NAMPRD84.PROD.OUTLOOK.COM \
    --to=elliott@hpe.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=kusumi.tomohiro@gmail.com \
    --cc=tkusumi@tuxera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.