From: Chris Brandt <Chris.Brandt@renesas.com>
To: jacopo mondi <jacopo@jmondi.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH 2/2] dt-bindings: pinctrl: Add RZ/A2 pinctrl and GPIO
Date: Fri, 19 Oct 2018 01:03:01 +0000 [thread overview]
Message-ID: <TY1PR01MB15627E9E1F358D00DF00C17D8AF90@TY1PR01MB1562.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20181018205131.GF11703@w540>
Hi Jacopo,
On Thursday, October 18, 2018, jacopo mondi wrote:
> > + Example: Assigning a GPIO:
> > +
> > + leds {
> > + status = "okay";
> > + compatible = "gpio-leds";
> > +
> > + led0 {
> > + /* P6_0 */
> > + gpios = <&pinctrl RZA2_PIN_ID(P6, 0) GPIO_ACTIVE_HIGH>;
> > + };
> > + };
>
> I think you should list the required properties ('pinmux') and the pin
> configuration flags the hardware supports.
OK, I can list pinmux.
> From a quick look to the
> manual I only see a configurable drive strength, but I might have
> missed something.
Yes, some pin can have different drive strength, but not all pins. Also,
some part are not clear about the drive strength.
So for this initial release, I do not want to be trying to describe
hardware that I don't completely understand yet.
> > +/*
> > + * Convert a port and pin label to its global pin index
> > + */
> > + #define RZA2_PIN_ID(port, pin) ((port) * RZA2_PINS_PER_PORT + (pin))
>
> Why not just RZA2_PIN() :) ?
OK.
I don't mind a shorter name.
Chris
prev parent reply other threads:[~2018-10-19 1:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 15:09 [PATCH 0/2] pinctrl: Add RZ/A2 pin and gpio driver Chris Brandt
2018-10-05 15:09 ` [PATCH 1/2] pinctrl: Add RZ/A2 pin and gpio controller Chris Brandt
2018-10-18 9:57 ` jacopo mondi
2018-10-18 21:42 ` Chris Brandt
2018-10-05 15:09 ` [PATCH 2/2] dt-bindings: pinctrl: Add RZ/A2 pinctrl and GPIO Chris Brandt
2018-10-16 22:47 ` Rob Herring
2018-10-17 0:53 ` Chris Brandt
2018-10-18 13:34 ` Rob Herring
2018-10-18 21:10 ` jacopo mondi
2018-10-19 1:47 ` Chris Brandt
2018-10-18 20:51 ` jacopo mondi
2018-10-19 1:03 ` Chris Brandt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY1PR01MB15627E9E1F358D00DF00C17D8AF90@TY1PR01MB1562.jpnprd01.prod.outlook.com \
--to=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jacopo@jmondi.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.