All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	Simon Horman <horms@verge.net.au>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: RE: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
Date: Fri, 22 Feb 2019 12:03:43 +0000	[thread overview]
Message-ID: <TY1PR01MB17704A0F818A4A01A6D82D90C07F0@TY1PR01MB1770.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <TY1PR01MB177050F5C00ED7DE89FB4318C07F0@TY1PR01MB1770.jpnprd01.prod.outlook.com>

Hello Geert,

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Fabrizio Castro
> Sent: 22 February 2019 10:12
> Subject: RE: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
> 
> Hello Geert,
> 
> > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> > Sent: 21 February 2019 18:34
> > To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Subject: Re: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
> >
> > On Wed, Feb 20, 2019 at 5:09 PM Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com> wrote:
> > > Enum LAST_DT_CORE_CLK needs updating as R8A774C0_CLK_CANFD
> > > was recently added and it's the core clock with the highest
> > > index.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > Nice catch!
> > You only notice this kind of bug when you start referencing the clock
> > from DT, right? At registration time, the clock number space is shared with
> > internal core clocks, so no error is detected.
> > Can we improve that?
> 
> I can look into it

Actually, it seems like I am a bit tight on time, not sure I am going to have the chance to look into this, sorry Geert

Thanks,
Fab

> 
> >
> > Fixes: 2a6efbc6da5d248c ("clk: renesas: r8a774c0: Add missing CANFD clock")
> 
> Commit 2a6efbc6da5d248c is not in a release or in a rc, is it ok to refer to it with a fixes tag?
> 
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Mike/Stephen: can you please take this one directly, as it is a fix for
> > clk-next?
> >
> > Fabrizio: Looks like R8A774A1 has the same bug. Care to fix that as well?
> 
> Will do
> 
> Thanks,
> Fab
> 
> >
> > Thanks!
> >
> > Gr{oetje,eeting}s,
> >
> >                         Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> >                                 -- Linus Torvalds

      reply	other threads:[~2019-02-22 12:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20 16:09 [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK Fabrizio Castro
2019-02-20 20:39 ` Chris Paterson
2019-02-21 18:33 ` Geert Uytterhoeven
2019-02-21 21:10   ` Stephen Boyd
2019-02-22 10:12   ` Fabrizio Castro
2019-02-22 12:03     ` Fabrizio Castro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY1PR01MB17704A0F818A4A01A6D82D90C07F0@TY1PR01MB1770.jpnprd01.prod.outlook.com \
    --to=fabrizio.castro@bp.renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.