From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabrizio Castro Subject: RE: [RFC v4 13/26] watchdog: renesas_wdt: Add restart handler Date: Wed, 7 Feb 2018 15:55:24 +0000 Message-ID: References: <1517423070-24236-1-git-send-email-fabrizio.castro@bp.renesas.com> <1517423070-24236-14-git-send-email-fabrizio.castro@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Sender: linux-renesas-soc-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Philipp Zabel , Rob Herring , Mark Rutland , Wim Van Sebroeck , Russell King , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Simon Horman , Magnus Damm , Geert Uytterhoeven , Wolfram Sang , Guenter Roeck , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Watchdog Mailing List , Linux-Renesas List-Id: devicetree@vger.kernel.org SGVsbG8gR2VlcnQsDQoNCj4gU3ViamVjdDogUmU6IFtSRkMgdjQgMTMvMjZdIHdhdGNoZG9nOiBy ZW5lc2FzX3dkdDogQWRkIHJlc3RhcnQgaGFuZGxlcg0KPg0KPiBIaSBGYWJyaXppbywNCg0KVGhh bmsgeW91IGZvciB5b3VyIGZlZWRiYWNrIQ0KDQo+DQo+IE9uIFdlZCwgSmFuIDMxLCAyMDE4IGF0 IDc6MjQgUE0sIEZhYnJpemlvIENhc3Rybw0KPiA8ZmFicml6aW8uY2FzdHJvQGJwLnJlbmVzYXMu Y29tPiB3cm90ZToNCj4gPiBPbiBpV2F2ZSdzIGJvYXJkcyBpd2cyMGQgYW5kIGl3ZzIyZCB0aGUg b25seSB3YXkgdG8gcmVib290IHRoZSBzeXN0ZW0gaXMNCj4gPiBieSBtZWFucyBvZiB0aGUgd2F0 Y2hkb2cuDQo+ID4gVGhpcyBwYXRjaCBhZGRzIGEgcmVzdGFydCBoYW5kbGVyIHRvIHJ3ZHRfb3Bz LCBhbmQgYWxzbyBtYWtlcyBzdXJlIHdlDQo+ID4ga2VlcCBpdHMgcHJpb3JpdHkgdG8gYSBtZWRp dW0gbGV2ZWwsIGluIG9yZGVyIHRvIG5vdCBvdmVycmlkZSBvdGhlciBtb3JlDQo+ID4gZWZmZWN0 aXZlIGhhbmRsZXJzLg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogRmFicml6aW8gQ2FzdHJvIDxm YWJyaXppby5jYXN0cm9AYnAucmVuZXNhcy5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogUmFtZXNo IFNoYW5tdWdhc3VuZGFyYW0gPHJhbWVzaC5zaGFubXVnYXN1bmRhcmFtQGJwLnJlbmVzYXMuY29t Pg0KPg0KPiA+IC0tLSBhL2RyaXZlcnMvd2F0Y2hkb2cvcmVuZXNhc193ZHQuYw0KPiA+ICsrKyBi L2RyaXZlcnMvd2F0Y2hkb2cvcmVuZXNhc193ZHQuYw0KPiA+IEBAIC0xMTgsNiArMTM2LDcgQEAg c3RhdGljIGNvbnN0IHN0cnVjdCB3YXRjaGRvZ19vcHMgcndkdF9vcHMgPSB7DQo+ID4gICAgICAg ICAuc3RvcCA9IHJ3ZHRfc3RvcCwNCj4gPiAgICAgICAgIC5waW5nID0gcndkdF9pbml0X3RpbWVv dXQsDQo+ID4gICAgICAgICAuZ2V0X3RpbWVsZWZ0ID0gcndkdF9nZXRfdGltZWxlZnQsDQo+ID4g KyAgICAgICAucmVzdGFydCA9IHJ3ZHRfcmVzdGFydCwNCj4gPiAgfTsNCj4gPg0KPiA+ICBzdGF0 aWMgaW50IHJ3ZHRfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4gPiBAQCAt MTc2LDYgKzE5NSw3IEBAIHN0YXRpYyBpbnQgcndkdF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2KQ0KPiA+ICAgICAgICAgcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwgcHJpdik7 DQo+ID4gICAgICAgICB3YXRjaGRvZ19zZXRfZHJ2ZGF0YSgmcHJpdi0+d2RldiwgcHJpdik7DQo+ ID4gICAgICAgICB3YXRjaGRvZ19zZXRfbm93YXlvdXQoJnByaXYtPndkZXYsIG5vd2F5b3V0KTsN Cj4gPiArICAgICAgIHdhdGNoZG9nX3NldF9yZXN0YXJ0X3ByaW9yaXR5KCZwcml2LT53ZGV2LCAx MjgpOw0KPg0KPiBHaXZlbiB3ZSB3YW50IHRvIHJlYm9vdCBSLUNhciBHZW4yIGJvYXJkcyBlcXVp cHBlZCB3aXRoIGEgc3VpdGFibGUgUE1JQw0KPiAoZS5nLiBEQTkwNjMpIHVzaW5nIHRoYXQgUE1J QywgSSB0aGluayB0aGUgcHJpb3JpdHkgc2hvdWxkIGJlIGxvd2VyICgwPyksDQo+IGNmci4NCg0K WWVzLCBjYW4gZG8sIEkgaGF2ZSBubyBzdHJvbmcgb3BpbmlvbiBhYm91dCB0aGlzLg0KSSdsbCB1 c2UgcHJpb3JpdHkgMCBmb3IgdGhlIG5leHQgc3VibWlzc2lvbi4NCg0KVGhhbmtzLA0KRmFiDQoN Cj4NCj4gICogICAwOiAgIHVzZSB3YXRjaGRvZydzIHJlc3RhcnQgZnVuY3Rpb24gYXMgbGFzdCBy ZXNvcnQsIGhhcyBsaW1pdGVkIHJlc3RhcnQNCj4gICogICAgICAgIGNhcGFiaWxpZXMNCj4gICog ICAxMjg6IGRlZmF1bHQgcmVzdGFydCBoYW5kbGVyLCB1c2UgaWYgbm8gb3RoZXIgaGFuZGxlciBp cyBleHBlY3RlZCB0byBiZQ0KPiAgKiAgICAgICAgYXZhaWxhYmxlIGFuZC9vciBpZiByZXN0YXJ0 IGlzIHN1ZmZpY2llbnQgdG8gcmVzdGFydCB0aGUgZW50aXJlIHN5c3RlbQ0KPiAgKiAgIDI1NTog cHJlZW1wdCBhbGwgb3RoZXIgaGFuZGxlcnMNCj4NCj4gR3J7b2V0amUsZWV0aW5nfXMsDQo+DQo+ ICAgICAgICAgICAgICAgICAgICAgICAgIEdlZXJ0DQo+DQo+IC0tDQo+IEdlZXJ0IFV5dHRlcmhv ZXZlbiAtLSBUaGVyZSdzIGxvdHMgb2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGludXgt bTY4ay5vcmcNCj4NCj4gSW4gcGVyc29uYWwgY29udmVyc2F0aW9ucyB3aXRoIHRlY2huaWNhbCBw ZW9wbGUsIEkgY2FsbCBteXNlbGYgYSBoYWNrZXIuIEJ1dA0KPiB3aGVuIEknbSB0YWxraW5nIHRv IGpvdXJuYWxpc3RzIEkganVzdCBzYXkgInByb2dyYW1tZXIiIG9yIHNvbWV0aGluZyBsaWtlIHRo YXQuDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLS0gTGludXMgVG9ydmFsZHMN Cg0KDQoNClJlbmVzYXMgRWxlY3Ryb25pY3MgRXVyb3BlIEx0ZCwgRHVrZXMgTWVhZG93LCBNaWxs Ym9hcmQgUm9hZCwgQm91cm5lIEVuZCwgQnVja2luZ2hhbXNoaXJlLCBTTDggNUZILCBVSy4gUmVn aXN0ZXJlZCBpbiBFbmdsYW5kICYgV2FsZXMgdW5kZXIgUmVnaXN0ZXJlZCBOby4gMDQ1ODY3MDku DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-path: From: Fabrizio Castro To: Geert Uytterhoeven CC: Philipp Zabel , Rob Herring , Mark Rutland , Wim Van Sebroeck , Russell King , Catalin Marinas , Will Deacon , "Michael Turquette" , Stephen Boyd , Simon Horman , Magnus Damm , "Geert Uytterhoeven" , Wolfram Sang , Guenter Roeck , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Watchdog Mailing List , Linux-Renesas , "linux-arm-kernel@lists.infradead.org" , linux-clk , Chris Paterson , Biju Das , Ramesh Shanmugasundaram Subject: RE: [RFC v4 13/26] watchdog: renesas_wdt: Add restart handler Date: Wed, 7 Feb 2018 15:55:24 +0000 Message-ID: References: <1517423070-24236-1-git-send-email-fabrizio.castro@bp.renesas.com> <1517423070-24236-14-git-send-email-fabrizio.castro@bp.renesas.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 List-ID: SGVsbG8gR2VlcnQsDQoNCj4gU3ViamVjdDogUmU6IFtSRkMgdjQgMTMvMjZdIHdhdGNoZG9nOiBy ZW5lc2FzX3dkdDogQWRkIHJlc3RhcnQgaGFuZGxlcg0KPg0KPiBIaSBGYWJyaXppbywNCg0KVGhh bmsgeW91IGZvciB5b3VyIGZlZWRiYWNrIQ0KDQo+DQo+IE9uIFdlZCwgSmFuIDMxLCAyMDE4IGF0 IDc6MjQgUE0sIEZhYnJpemlvIENhc3Rybw0KPiA8ZmFicml6aW8uY2FzdHJvQGJwLnJlbmVzYXMu Y29tPiB3cm90ZToNCj4gPiBPbiBpV2F2ZSdzIGJvYXJkcyBpd2cyMGQgYW5kIGl3ZzIyZCB0aGUg b25seSB3YXkgdG8gcmVib290IHRoZSBzeXN0ZW0gaXMNCj4gPiBieSBtZWFucyBvZiB0aGUgd2F0 Y2hkb2cuDQo+ID4gVGhpcyBwYXRjaCBhZGRzIGEgcmVzdGFydCBoYW5kbGVyIHRvIHJ3ZHRfb3Bz LCBhbmQgYWxzbyBtYWtlcyBzdXJlIHdlDQo+ID4ga2VlcCBpdHMgcHJpb3JpdHkgdG8gYSBtZWRp dW0gbGV2ZWwsIGluIG9yZGVyIHRvIG5vdCBvdmVycmlkZSBvdGhlciBtb3JlDQo+ID4gZWZmZWN0 aXZlIGhhbmRsZXJzLg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogRmFicml6aW8gQ2FzdHJvIDxm YWJyaXppby5jYXN0cm9AYnAucmVuZXNhcy5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogUmFtZXNo IFNoYW5tdWdhc3VuZGFyYW0gPHJhbWVzaC5zaGFubXVnYXN1bmRhcmFtQGJwLnJlbmVzYXMuY29t Pg0KPg0KPiA+IC0tLSBhL2RyaXZlcnMvd2F0Y2hkb2cvcmVuZXNhc193ZHQuYw0KPiA+ICsrKyBi L2RyaXZlcnMvd2F0Y2hkb2cvcmVuZXNhc193ZHQuYw0KPiA+IEBAIC0xMTgsNiArMTM2LDcgQEAg c3RhdGljIGNvbnN0IHN0cnVjdCB3YXRjaGRvZ19vcHMgcndkdF9vcHMgPSB7DQo+ID4gICAgICAg ICAuc3RvcCA9IHJ3ZHRfc3RvcCwNCj4gPiAgICAgICAgIC5waW5nID0gcndkdF9pbml0X3RpbWVv dXQsDQo+ID4gICAgICAgICAuZ2V0X3RpbWVsZWZ0ID0gcndkdF9nZXRfdGltZWxlZnQsDQo+ID4g KyAgICAgICAucmVzdGFydCA9IHJ3ZHRfcmVzdGFydCwNCj4gPiAgfTsNCj4gPg0KPiA+ICBzdGF0 aWMgaW50IHJ3ZHRfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4gPiBAQCAt MTc2LDYgKzE5NSw3IEBAIHN0YXRpYyBpbnQgcndkdF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2KQ0KPiA+ICAgICAgICAgcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwgcHJpdik7 DQo+ID4gICAgICAgICB3YXRjaGRvZ19zZXRfZHJ2ZGF0YSgmcHJpdi0+d2RldiwgcHJpdik7DQo+ ID4gICAgICAgICB3YXRjaGRvZ19zZXRfbm93YXlvdXQoJnByaXYtPndkZXYsIG5vd2F5b3V0KTsN Cj4gPiArICAgICAgIHdhdGNoZG9nX3NldF9yZXN0YXJ0X3ByaW9yaXR5KCZwcml2LT53ZGV2LCAx MjgpOw0KPg0KPiBHaXZlbiB3ZSB3YW50IHRvIHJlYm9vdCBSLUNhciBHZW4yIGJvYXJkcyBlcXVp cHBlZCB3aXRoIGEgc3VpdGFibGUgUE1JQw0KPiAoZS5nLiBEQTkwNjMpIHVzaW5nIHRoYXQgUE1J QywgSSB0aGluayB0aGUgcHJpb3JpdHkgc2hvdWxkIGJlIGxvd2VyICgwPyksDQo+IGNmci4NCg0K WWVzLCBjYW4gZG8sIEkgaGF2ZSBubyBzdHJvbmcgb3BpbmlvbiBhYm91dCB0aGlzLg0KSSdsbCB1 c2UgcHJpb3JpdHkgMCBmb3IgdGhlIG5leHQgc3VibWlzc2lvbi4NCg0KVGhhbmtzLA0KRmFiDQoN Cj4NCj4gICogICAwOiAgIHVzZSB3YXRjaGRvZydzIHJlc3RhcnQgZnVuY3Rpb24gYXMgbGFzdCBy ZXNvcnQsIGhhcyBsaW1pdGVkIHJlc3RhcnQNCj4gICogICAgICAgIGNhcGFiaWxpZXMNCj4gICog ICAxMjg6IGRlZmF1bHQgcmVzdGFydCBoYW5kbGVyLCB1c2UgaWYgbm8gb3RoZXIgaGFuZGxlciBp cyBleHBlY3RlZCB0byBiZQ0KPiAgKiAgICAgICAgYXZhaWxhYmxlIGFuZC9vciBpZiByZXN0YXJ0 IGlzIHN1ZmZpY2llbnQgdG8gcmVzdGFydCB0aGUgZW50aXJlIHN5c3RlbQ0KPiAgKiAgIDI1NTog cHJlZW1wdCBhbGwgb3RoZXIgaGFuZGxlcnMNCj4NCj4gR3J7b2V0amUsZWV0aW5nfXMsDQo+DQo+ ICAgICAgICAgICAgICAgICAgICAgICAgIEdlZXJ0DQo+DQo+IC0tDQo+IEdlZXJ0IFV5dHRlcmhv ZXZlbiAtLSBUaGVyZSdzIGxvdHMgb2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGludXgt bTY4ay5vcmcNCj4NCj4gSW4gcGVyc29uYWwgY29udmVyc2F0aW9ucyB3aXRoIHRlY2huaWNhbCBw ZW9wbGUsIEkgY2FsbCBteXNlbGYgYSBoYWNrZXIuIEJ1dA0KPiB3aGVuIEknbSB0YWxraW5nIHRv IGpvdXJuYWxpc3RzIEkganVzdCBzYXkgInByb2dyYW1tZXIiIG9yIHNvbWV0aGluZyBsaWtlIHRo YXQuDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLS0gTGludXMgVG9ydmFsZHMN Cg0KDQoNClJlbmVzYXMgRWxlY3Ryb25pY3MgRXVyb3BlIEx0ZCwgRHVrZXMgTWVhZG93LCBNaWxs Ym9hcmQgUm9hZCwgQm91cm5lIEVuZCwgQnVja2luZ2hhbXNoaXJlLCBTTDggNUZILCBVSy4gUmVn aXN0ZXJlZCBpbiBFbmdsYW5kICYgV2FsZXMgdW5kZXIgUmVnaXN0ZXJlZCBOby4gMDQ1ODY3MDku DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Fabrizio Castro To: Geert Uytterhoeven CC: Philipp Zabel , Rob Herring , Mark Rutland , Wim Van Sebroeck , Russell King , Catalin Marinas , Will Deacon , "Michael Turquette" , Stephen Boyd , Simon Horman , Magnus Damm , "Geert Uytterhoeven" , Wolfram Sang , Guenter Roeck , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Watchdog Mailing List , Linux-Renesas , "linux-arm-kernel@lists.infradead.org" , linux-clk , Chris Paterson , Biju Das , Ramesh Shanmugasundaram Subject: RE: [RFC v4 13/26] watchdog: renesas_wdt: Add restart handler Date: Wed, 7 Feb 2018 15:55:24 +0000 Message-ID: References: <1517423070-24236-1-git-send-email-fabrizio.castro@bp.renesas.com> <1517423070-24236-14-git-send-email-fabrizio.castro@bp.renesas.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: SGVsbG8gR2VlcnQsDQoNCj4gU3ViamVjdDogUmU6IFtSRkMgdjQgMTMvMjZdIHdhdGNoZG9nOiBy ZW5lc2FzX3dkdDogQWRkIHJlc3RhcnQgaGFuZGxlcg0KPg0KPiBIaSBGYWJyaXppbywNCg0KVGhh bmsgeW91IGZvciB5b3VyIGZlZWRiYWNrIQ0KDQo+DQo+IE9uIFdlZCwgSmFuIDMxLCAyMDE4IGF0 IDc6MjQgUE0sIEZhYnJpemlvIENhc3Rybw0KPiA8ZmFicml6aW8uY2FzdHJvQGJwLnJlbmVzYXMu Y29tPiB3cm90ZToNCj4gPiBPbiBpV2F2ZSdzIGJvYXJkcyBpd2cyMGQgYW5kIGl3ZzIyZCB0aGUg b25seSB3YXkgdG8gcmVib290IHRoZSBzeXN0ZW0gaXMNCj4gPiBieSBtZWFucyBvZiB0aGUgd2F0 Y2hkb2cuDQo+ID4gVGhpcyBwYXRjaCBhZGRzIGEgcmVzdGFydCBoYW5kbGVyIHRvIHJ3ZHRfb3Bz LCBhbmQgYWxzbyBtYWtlcyBzdXJlIHdlDQo+ID4ga2VlcCBpdHMgcHJpb3JpdHkgdG8gYSBtZWRp dW0gbGV2ZWwsIGluIG9yZGVyIHRvIG5vdCBvdmVycmlkZSBvdGhlciBtb3JlDQo+ID4gZWZmZWN0 aXZlIGhhbmRsZXJzLg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogRmFicml6aW8gQ2FzdHJvIDxm YWJyaXppby5jYXN0cm9AYnAucmVuZXNhcy5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogUmFtZXNo IFNoYW5tdWdhc3VuZGFyYW0gPHJhbWVzaC5zaGFubXVnYXN1bmRhcmFtQGJwLnJlbmVzYXMuY29t Pg0KPg0KPiA+IC0tLSBhL2RyaXZlcnMvd2F0Y2hkb2cvcmVuZXNhc193ZHQuYw0KPiA+ICsrKyBi L2RyaXZlcnMvd2F0Y2hkb2cvcmVuZXNhc193ZHQuYw0KPiA+IEBAIC0xMTgsNiArMTM2LDcgQEAg c3RhdGljIGNvbnN0IHN0cnVjdCB3YXRjaGRvZ19vcHMgcndkdF9vcHMgPSB7DQo+ID4gICAgICAg ICAuc3RvcCA9IHJ3ZHRfc3RvcCwNCj4gPiAgICAgICAgIC5waW5nID0gcndkdF9pbml0X3RpbWVv dXQsDQo+ID4gICAgICAgICAuZ2V0X3RpbWVsZWZ0ID0gcndkdF9nZXRfdGltZWxlZnQsDQo+ID4g KyAgICAgICAucmVzdGFydCA9IHJ3ZHRfcmVzdGFydCwNCj4gPiAgfTsNCj4gPg0KPiA+ICBzdGF0 aWMgaW50IHJ3ZHRfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4gPiBAQCAt MTc2LDYgKzE5NSw3IEBAIHN0YXRpYyBpbnQgcndkdF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2KQ0KPiA+ICAgICAgICAgcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwgcHJpdik7 DQo+ID4gICAgICAgICB3YXRjaGRvZ19zZXRfZHJ2ZGF0YSgmcHJpdi0+d2RldiwgcHJpdik7DQo+ ID4gICAgICAgICB3YXRjaGRvZ19zZXRfbm93YXlvdXQoJnByaXYtPndkZXYsIG5vd2F5b3V0KTsN Cj4gPiArICAgICAgIHdhdGNoZG9nX3NldF9yZXN0YXJ0X3ByaW9yaXR5KCZwcml2LT53ZGV2LCAx MjgpOw0KPg0KPiBHaXZlbiB3ZSB3YW50IHRvIHJlYm9vdCBSLUNhciBHZW4yIGJvYXJkcyBlcXVp cHBlZCB3aXRoIGEgc3VpdGFibGUgUE1JQw0KPiAoZS5nLiBEQTkwNjMpIHVzaW5nIHRoYXQgUE1J QywgSSB0aGluayB0aGUgcHJpb3JpdHkgc2hvdWxkIGJlIGxvd2VyICgwPyksDQo+IGNmci4NCg0K WWVzLCBjYW4gZG8sIEkgaGF2ZSBubyBzdHJvbmcgb3BpbmlvbiBhYm91dCB0aGlzLg0KSSdsbCB1 c2UgcHJpb3JpdHkgMCBmb3IgdGhlIG5leHQgc3VibWlzc2lvbi4NCg0KVGhhbmtzLA0KRmFiDQoN Cj4NCj4gICogICAwOiAgIHVzZSB3YXRjaGRvZydzIHJlc3RhcnQgZnVuY3Rpb24gYXMgbGFzdCBy ZXNvcnQsIGhhcyBsaW1pdGVkIHJlc3RhcnQNCj4gICogICAgICAgIGNhcGFiaWxpZXMNCj4gICog ICAxMjg6IGRlZmF1bHQgcmVzdGFydCBoYW5kbGVyLCB1c2UgaWYgbm8gb3RoZXIgaGFuZGxlciBp cyBleHBlY3RlZCB0byBiZQ0KPiAgKiAgICAgICAgYXZhaWxhYmxlIGFuZC9vciBpZiByZXN0YXJ0 IGlzIHN1ZmZpY2llbnQgdG8gcmVzdGFydCB0aGUgZW50aXJlIHN5c3RlbQ0KPiAgKiAgIDI1NTog cHJlZW1wdCBhbGwgb3RoZXIgaGFuZGxlcnMNCj4NCj4gR3J7b2V0amUsZWV0aW5nfXMsDQo+DQo+ ICAgICAgICAgICAgICAgICAgICAgICAgIEdlZXJ0DQo+DQo+IC0tDQo+IEdlZXJ0IFV5dHRlcmhv ZXZlbiAtLSBUaGVyZSdzIGxvdHMgb2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGludXgt bTY4ay5vcmcNCj4NCj4gSW4gcGVyc29uYWwgY29udmVyc2F0aW9ucyB3aXRoIHRlY2huaWNhbCBw ZW9wbGUsIEkgY2FsbCBteXNlbGYgYSBoYWNrZXIuIEJ1dA0KPiB3aGVuIEknbSB0YWxraW5nIHRv IGpvdXJuYWxpc3RzIEkganVzdCBzYXkgInByb2dyYW1tZXIiIG9yIHNvbWV0aGluZyBsaWtlIHRo YXQuDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLS0gTGludXMgVG9ydmFsZHMN Cg0KDQoNClJlbmVzYXMgRWxlY3Ryb25pY3MgRXVyb3BlIEx0ZCwgRHVrZXMgTWVhZG93LCBNaWxs Ym9hcmQgUm9hZCwgQm91cm5lIEVuZCwgQnVja2luZ2hhbXNoaXJlLCBTTDggNUZILCBVSy4gUmVn aXN0ZXJlZCBpbiBFbmdsYW5kICYgV2FsZXMgdW5kZXIgUmVnaXN0ZXJlZCBOby4gMDQ1ODY3MDku DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: fabrizio.castro@bp.renesas.com (Fabrizio Castro) Date: Wed, 7 Feb 2018 15:55:24 +0000 Subject: [RFC v4 13/26] watchdog: renesas_wdt: Add restart handler In-Reply-To: References: <1517423070-24236-1-git-send-email-fabrizio.castro@bp.renesas.com> <1517423070-24236-14-git-send-email-fabrizio.castro@bp.renesas.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Geert, > Subject: Re: [RFC v4 13/26] watchdog: renesas_wdt: Add restart handler > > Hi Fabrizio, Thank you for your feedback! > > On Wed, Jan 31, 2018 at 7:24 PM, Fabrizio Castro > wrote: > > On iWave's boards iwg20d and iwg22d the only way to reboot the system is > > by means of the watchdog. > > This patch adds a restart handler to rwdt_ops, and also makes sure we > > keep its priority to a medium level, in order to not override other more > > effective handlers. > > > > Signed-off-by: Fabrizio Castro > > Signed-off-by: Ramesh Shanmugasundaram > > > --- a/drivers/watchdog/renesas_wdt.c > > +++ b/drivers/watchdog/renesas_wdt.c > > @@ -118,6 +136,7 @@ static const struct watchdog_ops rwdt_ops = { > > .stop = rwdt_stop, > > .ping = rwdt_init_timeout, > > .get_timeleft = rwdt_get_timeleft, > > + .restart = rwdt_restart, > > }; > > > > static int rwdt_probe(struct platform_device *pdev) > > @@ -176,6 +195,7 @@ static int rwdt_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, priv); > > watchdog_set_drvdata(&priv->wdev, priv); > > watchdog_set_nowayout(&priv->wdev, nowayout); > > + watchdog_set_restart_priority(&priv->wdev, 128); > > Given we want to reboot R-Car Gen2 boards equipped with a suitable PMIC > (e.g. DA9063) using that PMIC, I think the priority should be lower (0?), > cfr. Yes, can do, I have no strong opinion about this. I'll use priority 0 for the next submission. Thanks, Fab > > * 0: use watchdog's restart function as last resort, has limited restart > * capabilies > * 128: default restart handler, use if no other handler is expected to be > * available and/or if restart is sufficient to restart the entire system > * 255: preempt all other handlers > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.