From: Grant Peltier <grant.peltier.jg@renesas.com>
To: Guenter Roeck <linux@roeck-us.net>,
Grant Peltier <grantpeltier93@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Adam Vaughn <adam.vaughn.xh@renesas.com>
Subject: RE: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
Date: Tue, 11 Aug 2020 17:24:06 +0000 [thread overview]
Message-ID: <TYAPR01MB2925D8052837B51F9D40639DD8450@TYAPR01MB2925.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <47df1832-86f6-bb51-0488-d1d9ab0e0b6f@roeck-us.net>
Ah, my apologies. Duly noted for the future. Thanks for catching it.
Grant
-----Original Message-----
From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
Sent: Tuesday, August 11, 2020 12:17 PM
To: Grant Peltier <grantpeltier93@gmail.com>
Cc: Grant Peltier <grant.peltier.jg@renesas.com>; linux-kernel@vger.kernel.org; Adam Vaughn <adam.vaughn.xh@renesas.com>
Subject: Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
On 8/10/20 11:36 AM, Grant Peltier wrote:
> Per the RAA228228 datasheet, READ_TEMPERATURE_1 is not a supported
> PMBus command.
>
> Signed-off-by: Grant Peltier <grantpeltier93@gmail.com>
Please copy linux-hwmon@vger.kernel.org on hwmon patches. This patch is not in the hwmon patchwork, which in general almost guarantees that it gets lost since I usually pull patches from there. As it happens, you are lucky that I noticed. Patch applied.
Guenter
> ---
> drivers/hwmon/pmbus/isl68137.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pmbus/isl68137.c
> b/drivers/hwmon/pmbus/isl68137.c index 0c622711ef7e..58aa95a3c010
> 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -67,6 +67,7 @@ enum variants {
> raa_dmpvr1_2rail,
> raa_dmpvr2_1rail,
> raa_dmpvr2_2rail,
> + raa_dmpvr2_2rail_nontc,
> raa_dmpvr2_3rail,
> raa_dmpvr2_hv,
> };
> @@ -241,6 +242,10 @@ static int isl68137_probe(struct i2c_client *client,
> info->pages = 1;
> info->read_word_data = raa_dmpvr2_read_word_data;
> break;
> + case raa_dmpvr2_2rail_nontc:
> + info->func[0] &= ~PMBUS_HAVE_TEMP;
> + info->func[1] &= ~PMBUS_HAVE_TEMP;
> + fallthrough;
> case raa_dmpvr2_2rail:
> info->pages = 2;
> info->read_word_data = raa_dmpvr2_read_word_data; @@ -304,7 +309,7
> @@ static const struct i2c_device_id raa_dmpvr_id[] = {
> {"raa228000", raa_dmpvr2_hv},
> {"raa228004", raa_dmpvr2_hv},
> {"raa228006", raa_dmpvr2_hv},
> - {"raa228228", raa_dmpvr2_2rail},
> + {"raa228228", raa_dmpvr2_2rail_nontc},
> {"raa229001", raa_dmpvr2_2rail},
> {"raa229004", raa_dmpvr2_2rail},
> {}
>
next prev parent reply other threads:[~2020-08-11 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 18:36 [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228 Grant Peltier
2020-08-11 17:17 ` Guenter Roeck
2020-08-11 17:24 ` Grant Peltier [this message]
2020-10-13 18:18 Alex Qiu
2020-10-13 18:22 ` Alex Qiu
2020-10-13 18:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB2925D8052837B51F9D40639DD8450@TYAPR01MB2925.jpnprd01.prod.outlook.com \
--to=grant.peltier.jg@renesas.com \
--cc=adam.vaughn.xh@renesas.com \
--cc=grantpeltier93@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.