All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Cc: "linux-renesas-soc@vger.kernel.org"  <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] mmc: renesas_sdhi: refactor calculation of best TAP
Date: Thu, 9 Apr 2020 08:58:58 +0000	[thread overview]
Message-ID: <TYAPR01MB45440A401D341427694F9419D8C10@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20200408094638.10375-2-wsa+renesas@sang-engineering.com>

Hi Wolfram-san,

> From: Wolfram Sang, Sent: Wednesday, April 8, 2020 6:47 PM
> 
> To select the best TAP, we need to find the longest stream of set bits
> in a bit field. There is now a helper function for bitmaps which
> iterates over all region of set bits. Using it makes the code much more
> concise and easier to understand. Double so, because we need to handle
> two bitmaps in the near future. Remove a superfluous comment while here.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda


  reply	other threads:[~2020-04-09  8:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08  9:46 [PATCH v2 0/3] mmc: renesas_sdhi: improve TAP selection if all TAPs are good Wolfram Sang
2020-04-08  9:46 ` [PATCH v2 1/3] mmc: renesas_sdhi: refactor calculation of best TAP Wolfram Sang
2020-04-09  8:58   ` Yoshihiro Shimoda [this message]
2020-04-08  9:46 ` [PATCH v2 2/3] mmc: renesas_sdhi: clarify handling of selecting TAPs Wolfram Sang
2020-04-08  9:46 ` [PATCH v2 3/3] mmc: renesas_sdhi: improve TAP selection if all TAPs are good Wolfram Sang
2020-04-09  9:04   ` Yoshihiro Shimoda
2020-04-15 10:21 ` [PATCH v2 0/3] " Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAPR01MB45440A401D341427694F9419D8C10@TYAPR01MB4544.jpnprd01.prod.outlook.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.