From: "naohirot@fujitsu.com" <naohirot@fujitsu.com>
To: 'Robin Murphy' <robin.murphy@arm.com>, Marc Zyngier <maz@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Fuad Tabba <tabba@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
David Brazdil <dbrazdil@google.com>
Subject: RE: [PATCH] arm64: Remove AArch64 X30 redundant register alias
Date: Thu, 15 Jul 2021 01:29:04 +0000 [thread overview]
Message-ID: <TYAPR01MB602500E7A6DCE760B002AF8ADF129@TYAPR01MB6025.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <0c89941d-7f49-2686-e80d-84b10a48b86d@arm.com>
Hi Robin, Marc,
Thank you for your quick feedbacks!
> From: Robin Murphy <robin.murphy@arm.com>
> Sent: Wednesday, July 14, 2021 8:39 PM
> On 2021-07-14 10:54, Marc Zyngier wrote:
> > On Tue, 13 Jul 2021 14:29:45 +0100,
> > Naohiro Tamura <naohirot@fujitsu.com> wrote:
> >> -/*
> >> - * Register aliases.
> >> - */
> >> -lr .req x30 // link register
> >> -
> >> /*
> >> * Vector entry
> >> */
> >
> > I seem to vaguely remember that this isn't always defined, see [1] for
> > a recent example. Dropping it altogether may end-up being pretty
> > disruptive.
>
> Right, the built-in alias was only introduced a few years ago in
> binutils 2.29 (where it initially caused problems itself by being a bit
> overzealous[2]), but our current minimum version is 2.23, so we still
> need this for older but still-supported toolchains (e.g. I expect the
> Linaro GCC 7-based releases with binutils 2.28 are still being used).
I confirmed that binutils 2.23 doesn't have the alias [3].
So I withdraw this patch.
[3] https://sourceware.org/binutils/docs-2.23/as/AArch64-Directives.html#AArch64-Directives
p.s. I have learned how to submit a patch 😊
Thanks.
Naohiro
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-07-15 1:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 13:29 [PATCH] arm64: Remove AArch64 X30 redundant register alias Naohiro Tamura
2021-07-14 9:54 ` Marc Zyngier
2021-07-14 11:38 ` Robin Murphy
2021-07-15 1:29 ` naohirot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB602500E7A6DCE760B002AF8ADF129@TYAPR01MB6025.jpnprd01.prod.outlook.com \
--to=naohirot@fujitsu.com \
--cc=andreyknvl@gmail.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dbrazdil@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.