From: Biju Das <biju.das.jz@bp.renesas.com>
To: Adam Ford <aford173@gmail.com>
Cc: "linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"aford@beaconembedded.com" <aford@beaconembedded.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Sergei Shtylyov <sergei.shtylyov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series
Date: Sat, 2 Jan 2021 08:13:26 +0000 [thread overview]
Message-ID: <TYBPR01MB5309CC39CE7896473819E7C486D40@TYBPR01MB5309.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAHCN7x+6BobFukqiENYg4HwZm5M0S5Dv14DmbmW5xYn0DdXBwQ@mail.gmail.com>
> -----Original Message-----
> From: Adam Ford <aford173@gmail.com>
> Sent: 01 January 2021 21:34
> To: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: linux-renesas-soc@vger.kernel.org; aford@beaconembedded.com; Krzysztof
> Kozlowski <krzk@kernel.org>; Rob Herring <robh+dt@kernel.org>; Geert
> Uytterhoeven <geert+renesas@glider.be>; Magnus Damm
> <magnus.damm@gmail.com>; Sergei Shtylyov <sergei.shtylyov@gmail.com>;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support
> for RZ/G2 Series
>
> On Fri, Jan 1, 2021 at 12:58 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> >
> > Hi Adam,
> >
> > Thanks for the patch.
> >
> > > -----Original Message-----
> > > From: Adam Ford <aford173@gmail.com>
> > > Sent: 01 January 2021 11:39
> > > To: linux-renesas-soc@vger.kernel.org
> > > Cc: aford@beaconembedded.com; Adam Ford <aford173@gmail.com>;
> > > Krzysztof Kozlowski <krzk@kernel.org>; Rob Herring
> > > <robh+dt@kernel.org>; Geert Uytterhoeven <geert+renesas@glider.be>;
> > > Magnus Damm <magnus.damm@gmail.com>; Sergei Shtylyov
> > > <sergei.shtylyov@gmail.com>; linux-kernel@vger.kernel.org;
> > > devicetree@vger.kernel.org
> > > Subject: [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add
> > > support for
> > > RZ/G2 Series
> > >
> > > The RZ/G2 Series has the RPC-IF interface.
> > > Update bindings to support: r8a774a1, r8a774b1, r8a774c0, and
> > > r8a774e1
> > >
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > > ---
> > > .../bindings/memory-controllers/renesas,rpc-if.yaml | 4
> ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/memory-
> > > controllers/renesas,rpc-if.yaml
> > > b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-i
> > > f.yaml index 6d6ba608fd22..050c66af8c2c 100644
> > > ---
> > > a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-
> > > if.yaml
> > > +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,r
> > > +++ pc-
> > > if.yaml
> > > @@ -26,6 +26,10 @@ properties:
> > > compatible:
> > > items:
> > > - enum:
> > > + - renesas,r8a774a1-rpc-if # RZ/G2M
> > > + - renesas,r8a774b1-rpc-if # RZ/G2N
> > > + - renesas,r8a774c0-rpc-if # RZ/G2E
> > > + - renesas,r8a774e1-rpc-if # RZ/G2H
> > > - renesas,r8a77970-rpc-if # R-Car V3M
> > > - renesas,r8a77980-rpc-if # R-Car V3H
> > > - renesas,r8a77995-rpc-if # R-Car D3
> >
> > May be we need to update the below description as well to cover RZ/G2
> device??
> >
> > - const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 device
>
> How do you want it to read?
Since it is generic compatible string for both R-Car gen3 and RZ/G2 device, I would update the description as
- const: renesas,rcar-gen3-rpc-if # a generic R-Car gen3 or RZ/G2 device
Also may be we need to update the description of config RENESAS_RPCIF in drivers/memory/Kconfig to taken care of RZ/G2 devices in a separate patch.
Cheers,
Biju
next prev parent reply other threads:[~2021-01-02 8:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-01 11:39 [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series Adam Ford
2021-01-01 11:39 ` [PATCH 2/2] arm64: dts: renesas: rzg2: Add RPC-IF Support Adam Ford
2021-01-08 14:38 ` Geert Uytterhoeven
2021-01-01 18:58 ` [PATCH 1/2] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series Biju Das
2021-01-01 21:34 ` Adam Ford
2021-01-02 8:08 ` Biju Das
2021-01-02 8:13 ` Biju Das [this message]
2021-01-02 11:31 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYBPR01MB5309CC39CE7896473819E7C486D40@TYBPR01MB5309.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.