All of lore.kernel.org
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 3/5] pinctrl: renesas: r8a77965: Add R8A774B1 PFC support
Date: Tue, 13 Oct 2020 18:30:19 +0000	[thread overview]
Message-ID: <TYBPR01MB5309CE7357B944E9778E0A0C86040@TYBPR01MB5309.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <0116bdae-6b7f-8e8e-f07b-b8d5615c39da@gmail.com>

Hi Marek,

> Subject: Re: [PATCH v2 3/5] pinctrl: renesas: r8a77965: Add R8A774B1 PFC
> support
>
> On 10/13/20 8:01 PM, Biju Das wrote:
>
> Hi,
>
> [...]
>
> >> On 10/13/20 10:52 AM, Biju Das wrote:
> >>> Renesas RZ/G2N (r8a774b1) is pin compatible with R-Car M3-N
> >>> (r8a77965), however it doesn't have several automotive specific
> >>> peripherals. Add a r8a77965 specific pin groups/functions along with
> >>> common pin groups/functions for supporting both r8a77965 and
> >>> r8a774b1
> >> SoC.
> >>
> >> Would it make sense to ifdef out the R8A774B1 extras if
> >> CONFIG_PINCTRL_PFC_R8A774B1 is not enabled and in turn also the
> >> R8A77965 extras if CONFIG_PINCTRL_PFC_R8A77965 is not enabled, so
> the
> >> resulting U-Boot binary isn't bloated with the unused tables ?
> >
> > By default, all IP's in R8A774B1 will be  present in R8A77965 SoC. So the
> extras is only for R8A77965.
> >
> > Code will be much cleaner, if we maintain same structure like linux
> > [1]. Otherwise we need to add #ifdef CONFIG_PINCTRL_PFC_R8A77965 for
> the DRIF IP/.automotive all over the places in this file.
> > So please advise.
>
> Check with the linux maintainers please, surely there should be some way to
> separate the extras in a way that's not too hard to maintain, and thus reduce
> the resulting binary size. For U-Boot, that is quite important already, I think
> the TFA can only load 1 MiB binary in total.

I agree for bootloader size is important. So I will add macros as per your suggestion (we don't need to look into linux for this).

Cheers,
biju


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

  reply	other threads:[~2020-10-13 18:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13  8:52 [PATCH v2 0/5] Add Clock and Pincontrol driver support for RZ/G2[HN] SoC's Biju Das
2020-10-13  8:52 ` [PATCH v2 1/5] clk: renesas: Add R8A774B1 clock tables Biju Das
2020-10-13 17:10   ` Marek Vasut
2020-10-13 18:02     ` Biju Das
2020-10-13  8:52 ` [PATCH v2 2/5] clk: renesas: r8a774b1-cpg-mssr: Add R8A774B1 RPC clock Biju Das
2020-10-13  8:52 ` [PATCH v2 3/5] pinctrl: renesas: r8a77965: Add R8A774B1 PFC support Biju Das
2020-10-13 17:12   ` Marek Vasut
2020-10-13 18:01     ` Biju Das
2020-10-13 18:07       ` Marek Vasut
2020-10-13 18:30         ` Biju Das [this message]
2020-10-13 18:34           ` Marek Vasut
2020-10-14 11:29             ` Biju Das
2020-10-15 21:53               ` Marek Vasut
2020-10-17 13:11                 ` Biju Das
2020-10-28 10:39                   ` Biju Das
2020-10-13  8:52 ` [PATCH v2 4/5] clk: renesas: Add R8A774E1 clock tables Biju Das
2020-10-13  8:52 ` [PATCH v2 5/5] pinctrl: renesas: r8a77951: Add R8A774E1 PFC support Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYBPR01MB5309CE7357B944E9778E0A0C86040@TYBPR01MB5309.jpnprd01.prod.outlook.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.