RE: [PATCH net v2] net: renesas: rswitch: Fix timestamp feature after all descriptors are used

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Simon Horman <simon.horman@corigine.com>
Cc: "s.shtylyov@omp.ru" <s.shtylyov@omp.ru>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	Phong Hoang <phong.hoang.wz@renesas.com>
Subject: RE: [PATCH net v2] net: renesas: rswitch: Fix timestamp feature after all descriptors are used
Date: Thu, 8 Jun 2023 00:21:13 +0000	[thread overview]
Message-ID: <TYBPR01MB53419CEF615E14B8ACD3ADC6D850A@TYBPR01MB5341.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <ZIChdcJ1e2cl5epK@corigine.com>

Hi Simon-san,

> From: Simon Horman, Sent: Thursday, June 8, 2023 12:26 AM
> 
> On Wed, Jun 07, 2023 at 04:01:41PM +0900, Yoshihiro Shimoda wrote:
> > The timestamp descriptors were intended to act cyclically. Descriptors
> > from index 0 through gq->ring_size - 1 contain actual information, and
> > the last index (gq->ring_size) should have LINKFIX to indicate
> > the first index 0 descriptor. However, thie LINKFIX value is missing,
> 
> Hi Shimoda-san,
> 
> a very minor nit, in case you end up posting a v3 for some other reason:
> 
> 	thie -> the

Thank you for your review! I'll fix this on v3.

Best regards,
Yoshihiro Shimoda

> > causing the timestamp feature to stop after all descriptors are used.
> > To resolve this issue, set the LINKFIX to the timestamp descritors.
> >
> > Reported-by: Phong Hoang <phong.hoang.wz@renesas.com>
> > Fixes: 33f5d733b589 ("net: renesas: rswitch: Improve TX timestamp accuracy")
> 
> ...