All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/crypto: suspected missing null check in hisi_qm_pre_init
@ 2021-10-27 11:06 YE Chengfeng
  2021-10-28  1:24 ` Zhou Wang
  0 siblings, 1 reply; 3+ messages in thread
From: YE Chengfeng @ 2021-10-27 11:06 UTC (permalink / raw)
  To: wangzhou1, herbert, davem; +Cc: linux-kernel

Hi,

https://github.com/torvalds/linux/blob/master/drivers/crypto/hisilicon/qm.c#L3286

We notice that at #line 3286, the return pointer of ACPI_COMPANION is not null-checked, and then it's dereferenced in acpi_device_power_manageable. Seems that it could be a potential null-pointer-dereference issue.

This is detected by our experimental static analysis tool, it could be false positive, so we manually check and report those we think may be true bugs. Would you like to have a look at them? If it's real bug, we could like to provide patch to ease your workflow.

Thanks so much,
Chengfeng

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: drivers/crypto: suspected missing null check in hisi_qm_pre_init
  2021-10-27 11:06 drivers/crypto: suspected missing null check in hisi_qm_pre_init YE Chengfeng
@ 2021-10-28  1:24 ` Zhou Wang
  2021-10-28  2:20   ` 回复: " YE Chengfeng
  0 siblings, 1 reply; 3+ messages in thread
From: Zhou Wang @ 2021-10-28  1:24 UTC (permalink / raw)
  To: YE Chengfeng, herbert, davem; +Cc: linux-kernel

> Hi,
> 
> https://github.com/torvalds/linux/blob/master/drivers/crypto/hisilicon/qm.c#L3286
> 
> We notice that at #line 3286, the return pointer of ACPI_COMPANION is not null-checked, and then it's dereferenced in acpi_device_power_manageable. Seems that it could be a potential null-pointer-dereference issue.
> 
> This is detected by our experimental static analysis tool, it could be false positive, so we manually check and report those we think may be true bugs. Would you like to have a look at them? If it's real bug, we could like to provide patch to ease your workflow.

Hi Chengfeng,

It will reture NULL when ACPI is disabled, however this driver deponds on
ACPI, which is already set in Kconfig. So no need do null-checked here.

Thanks,
Zhou

> 
> Thanks so much,
> Chengfeng
> .
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* 回复: drivers/crypto: suspected missing null check in hisi_qm_pre_init
  2021-10-28  1:24 ` Zhou Wang
@ 2021-10-28  2:20   ` YE Chengfeng
  0 siblings, 0 replies; 3+ messages in thread
From: YE Chengfeng @ 2021-10-28  2:20 UTC (permalink / raw)
  To: Zhou Wang, herbert, davem; +Cc: linux-kernel

Got it.
Thanks for your reply.

Best regards,
Chengfeng

-----邮件原件-----
发件人: Zhou Wang <wangzhou1@hisilicon.com> 
发送时间: 2021年10月28日 9:24
收件人: YE Chengfeng <cyeaa@connect.ust.hk>; herbert@gondor.apana.org.au; davem@davemloft.net
抄送: linux-kernel@vger.kernel.org
主题: Re: drivers/crypto: suspected missing null check in hisi_qm_pre_init

> Hi,
> 
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Ftorvalds%2Flinux%2Fblob%2Fmaster%2Fdrivers%2Fcrypto%2Fhisilic
> on%2Fqm.c%23L3286&amp;data=04%7C01%7Ccyeaa%40connect.ust.hk%7C98c99b9b
> 25084a3fac8d08d999b1a9cb%7C6c1d415239d044ca88d9b8d6ddca0708%7C1%7C0%7C
> 637709810602673947%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjo
> iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=e3p0PP1tp%2BA
> %2BrUALUgrowuYEZT3L21WoQBqfAn5iKac%3D&amp;reserved=0
> 
> We notice that at #line 3286, the return pointer of ACPI_COMPANION is not null-checked, and then it's dereferenced in acpi_device_power_manageable. Seems that it could be a potential null-pointer-dereference issue.
> 
> This is detected by our experimental static analysis tool, it could be false positive, so we manually check and report those we think may be true bugs. Would you like to have a look at them? If it's real bug, we could like to provide patch to ease your workflow.

Hi Chengfeng,

It will reture NULL when ACPI is disabled, however this driver deponds on ACPI, which is already set in Kconfig. So no need do null-checked here.

Thanks,
Zhou

> 
> Thanks so much,
> Chengfeng
> .
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-28  2:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27 11:06 drivers/crypto: suspected missing null check in hisi_qm_pre_init YE Chengfeng
2021-10-28  1:24 ` Zhou Wang
2021-10-28  2:20   ` 回复: " YE Chengfeng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.