From: Biju Das <biju.das.jz@bp.renesas.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Support Opensource <support.opensource@diasemi.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
biju.das.au <biju.das.au@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH 3/6] rtc: da9063: Use dev_err_probe()
Date: Thu, 4 Jan 2024 19:31:32 +0000 [thread overview]
Message-ID: <TYCPR01MB112695EE120985DAD1ADCE0F486672@TYCPR01MB11269.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20231219234956fd65a895@mail.local>
Hi Alexandre Belloni,
> -----Original Message-----
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Sent: Tuesday, December 19, 2023 11:50 PM
> Subject: Re: [PATCH 3/6] rtc: da9063: Use dev_err_probe()
>
> On 01/12/2023 16:40:25+0000, Biju Das wrote:
> > > RTC_FEATURE_ALARM is what you should clear and you have to fallback
> > > to the irq is not present case.
> >
> >
> > Ok,Will update Patch#3 with clearing "RTC_FEATURE_ALARM" as the
> > fallback for the irqhandler error case
> >
> > On patch#1, I will clear both RTC_FEATURE_ALARM" and
> > "RTC_FEATURE_UPDATE_INTERRUPT",
> >
> > as with just clearing "RTC_FEATURE_ALARM", I get below error.
> >
> > root@smarc-rzg2ul:~# date -s "2023-08-06 19:30:00"
> > Sun Aug 6 19:30:00 UTC 2023
> > root@smarc-rzg2ul:~# hwclock -w
> > root@smarc-rzg2ul:~# hwclock -r
> > hwclock: select() to /dev/rtc0 to wait for clock tick timed out
> > root@smarc-rzg2ul:~#
> >
> >
>
> I can't believe this is true because the rtc core code will take the same
> path when RTC_FEATURE_ALARM or RTC_FEATURE_UPDATE_INTERRUPT is
> cleared:
>
>
> RTC_FEATURE_UPDATE_INTERRUPT must be cleared only when RTC_FEATURE_ALARM
> is set.
I rechecked this with latest next and it is working with clearing RTC_FEATURE_ALARM.
I will send v3 with this change.
root@smarc-rzg2ul:~# date -s "2023-08-06 19:30:00"
Sun Aug 6 19:30:00 UTC 2023
root@smarc-rzg2ul:~# hwclock -w
root@smarc-rzg2ul:~# hwclock -r
2023-08-06 19:30:11.664350+00:00
root@smarc-rzg2ul:~#
Cheers,
Biju
next prev parent reply other threads:[~2024-01-04 19:31 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 11:08 [PATCH 0/6] Add DA9062 PMIC and built-in RTC support for RZ/G2UL SMARC EVK Biju Das
2023-12-01 11:08 ` Biju Das
2023-12-01 11:08 ` [PATCH 1/6] rtc: da9063: Make IRQ as optional Biju Das
2023-12-01 13:00 ` Geert Uytterhoeven
2023-12-01 13:23 ` Biju Das
2023-12-01 11:08 ` [PATCH 2/6] rtc: da9063: Use device_get_match_data() Biju Das
2023-12-01 13:06 ` Geert Uytterhoeven
2023-12-01 11:08 ` [PATCH 3/6] rtc: da9063: Use dev_err_probe() Biju Das
2023-12-01 13:11 ` Geert Uytterhoeven
2023-12-01 13:30 ` Biju Das
2023-12-01 15:20 ` Alexandre Belloni
2023-12-01 15:43 ` Biju Das
2023-12-01 15:55 ` Alexandre Belloni
2023-12-01 16:40 ` Biju Das
2023-12-19 23:49 ` Alexandre Belloni
2023-12-19 23:56 ` Alexandre Belloni
2024-01-04 19:31 ` Biju Das [this message]
2023-12-01 11:08 ` [PATCH 4/6] dt-bindings: mfd: Convert da9062 to json-schema Biju Das
2023-12-01 13:33 ` Geert Uytterhoeven
2023-12-01 15:54 ` Conor Dooley
2023-12-06 5:15 ` kernel test robot
2023-12-06 9:33 ` Biju Das
2023-12-06 13:28 ` Lee Jones
2023-12-06 15:19 ` Biju Das
2023-12-08 2:21 ` Liu, Yujie
2023-12-01 11:08 ` [PATCH 5/6] arm64: dts: renesas: rzg2ul-smarc: Enable PMIC and built-in RTC Biju Das
2023-12-01 13:39 ` Geert Uytterhoeven
2023-12-01 13:48 ` Biju Das
2023-12-01 13:58 ` Geert Uytterhoeven
2023-12-01 11:08 ` [PATCH 6/6] arm64: defconfig: Enable Renesas DA9062 defconfig Biju Das
2023-12-01 11:08 ` Biju Das
2023-12-01 13:41 ` Geert Uytterhoeven
2023-12-01 13:41 ` Geert Uytterhoeven
2023-12-01 15:02 ` Biju Das
2023-12-01 15:02 ` Biju Das
2023-12-01 15:41 ` Geert Uytterhoeven
2023-12-01 15:41 ` Geert Uytterhoeven
2023-12-10 9:49 ` Biju Das
2023-12-10 9:49 ` Biju Das
2023-12-11 8:20 ` Geert Uytterhoeven
2023-12-11 8:20 ` Geert Uytterhoeven
2023-12-11 8:32 ` Biju Das
2023-12-11 8:32 ` Biju Das
2023-12-11 8:52 ` Geert Uytterhoeven
2023-12-11 8:52 ` Geert Uytterhoeven
2023-12-11 9:00 ` Biju Das
2023-12-11 9:00 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYCPR01MB112695EE120985DAD1ADCE0F486672@TYCPR01MB11269.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=biju.das.au@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.