All of lore.kernel.org
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH v3] mmc: renesas_sdhi: Fix rounding errors
Date: Mon, 26 Sep 2022 17:13:21 +0000	[thread overview]
Message-ID: <TYCPR01MB59335B9556A66EE2D23351CD86529@TYCPR01MB5933.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <YzCHFZnhrMWPkyIQ@shikoro>

Hi Wolfram,

> Subject: Re: [PATCH v3] mmc: renesas_sdhi: Fix rounding errors
> 
> On Thu, Sep 22, 2022 at 09:55:11AM +0100, Biju Das wrote:
> > Due to clk rounding errors on RZ/G2L platforms, it selects a clock
> > source with a lower clock rate compared to a higher one.
> > For eg:- (533333333 Hz / 4 * 4 = 533333332 Hz < 533333333 Hz).
> >
> > This patch fixes this issue by adding a margin of (1/1024) higher to
> > the clock rate.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Despite the discussion about the comments, the patch does not change
> any clock selection on my R-Car M3-N based Salvator-XS, both for eMMC
> and some SD cards. So:
> 
> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks for testing. I have incorporated the review comments and send v4.

Cheers,
Biju


      reply	other threads:[~2022-09-26 17:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22  8:55 [PATCH v3] mmc: renesas_sdhi: Fix rounding errors Biju Das
2022-09-24 10:18 ` Wolfram Sang
2022-09-25 17:06   ` Biju Das
2022-09-26 12:20     ` Geert Uytterhoeven
2022-09-26 12:52       ` Biju Das
2022-09-25 16:51 ` Wolfram Sang
2022-09-26 17:13   ` Biju Das [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYCPR01MB59335B9556A66EE2D23351CD86529@TYCPR01MB5933.jpnprd01.prod.outlook.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.