All of lore.kernel.org
 help / color / mirror / Atom feed
From: Norihiko Hama <norihiko.hama@alpsalpine.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"usb-storage@lists.one-eyed-alien.net"
	<usb-storage@lists.one-eyed-alien.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb-storage: Optimize scan delay more precisely
Date: Wed, 27 Mar 2024 07:57:52 +0000	[thread overview]
Message-ID: <TYVPR01MB10781723CBD338DC3EEB5F20590342@TYVPR01MB10781.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <2024032745-transfer-dazzler-2e15@gregkh>

On Wed, Mar 27, 2024 at 07:39:55AM +0000, Norihiko Hama wrote:
> > > Sorry, but module parameters are from the 1990's, we will not go back to that if at all possible as it's not easy to maintain and will not work properly for multiple devices.
> > >
> > > I can understand wanting something between 1 and 0 seconds, but adding yet-another-option isn't probably the best way, sorry.
> > 1 second does not meet with performance requirement.
>
> Who is requiring such a performance requirement?  The USB specification?
> Or something else?
This is our customer requirement.

> > I have no good idea except module parameter so that we can maintain backward compatibility but be configurable out of module.
> > Do you have any other better solution?
> How long do you exactly need to wait?  Why not figure out how long the device takes and if it fails, slowly back off until the full time delay happens and then you can abort?
It's IOP issue and difficult to figure out because it depends on device itself.
I know we have multiple devices with delay_use=0, but then it's recovered and detected by reset after 30s timeout, that is too long than 1 sec.

  reply	other threads:[~2024-03-27  7:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27  5:51 [PATCH] usb-storage: Optimize scan delay more precisely Norihiko Hama
2024-03-27  5:53 ` Greg KH
2024-03-27  7:39   ` Norihiko Hama
2024-03-27  7:44     ` Greg KH
2024-03-27  7:57       ` Norihiko Hama [this message]
2024-03-27  8:15         ` Greg KH
2024-03-28  2:52           ` Norihiko Hama
2024-03-27 14:10     ` Alan Stern
2024-03-28  3:04       ` Norihiko Hama
2024-03-28 14:51         ` Alan Stern
2024-03-28 15:21           ` [usb-storage] " Matthew Dharm
2024-03-28 16:18             ` Alan Stern
2024-03-28 23:38               ` Norihiko Hama
2024-03-29  1:45               ` Matthew Dharm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYVPR01MB10781723CBD338DC3EEB5F20590342@TYVPR01MB10781.jpnprd01.prod.outlook.com \
    --to=norihiko.hama@alpsalpine.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.