* Re: [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
@ 2019-11-06 10:50 ` S.j. Wang
0 siblings, 0 replies; 8+ messages in thread
From: S.j. Wang @ 2019-11-06 10:50 UTC (permalink / raw)
To: S.j. Wang, Rob Herring
Cc: mark.rutland, devicetree, alsa-devel, timur, Xiubo.Lee,
linuxppc-dev, tiwai, lgirdwood, nicoleotsuka, broonie, festevam,
linux-kernel
Hi Rob
>
> Hi
> >
> > On Wed, Oct 30, 2019 at 07:41:26PM +0800, Shengjiu Wang wrote:
> > > In order to support the two asrc modules in imx8qm, we need to add
> > > compatible string "fsl,imx8qm-asrc0" and "fsl,imx8qm-asrc1"
> >
> > Are the blocks different in some way?
> >
> > If not, why do you need to distinguish them?
> >
> The internal clock mapping is different for each module.
>
Or we can use one compatible string, but need add another property
"fsl,asrc-clk-map" to distinguish the different clock map.
The change is in below.
Which one do you think is better?
Required properties:
- - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc".
+ - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc",
+ "fsl,imx8qm-asrc".
- reg : Offset and length of the register set for the device.
@@ -35,6 +36,11 @@ Required properties:
- fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends.
+ - fsl,asrc-clk-map : Defines clock map used in driver. which is required
+ by imx8qm
+ <0> - select the map for asrc0
+ <1> - select the map for asrc1
+
Optional properties:
Best regards
Wang shengjiu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [alsa-devel] [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
@ 2019-11-06 10:50 ` S.j. Wang
0 siblings, 0 replies; 8+ messages in thread
From: S.j. Wang @ 2019-11-06 10:50 UTC (permalink / raw)
To: S.j. Wang, Rob Herring
Cc: mark.rutland, devicetree, alsa-devel, timur, Xiubo.Lee, festevam,
tiwai, lgirdwood, nicoleotsuka, broonie, linuxppc-dev,
linux-kernel
Hi Rob
>
> Hi
> >
> > On Wed, Oct 30, 2019 at 07:41:26PM +0800, Shengjiu Wang wrote:
> > > In order to support the two asrc modules in imx8qm, we need to add
> > > compatible string "fsl,imx8qm-asrc0" and "fsl,imx8qm-asrc1"
> >
> > Are the blocks different in some way?
> >
> > If not, why do you need to distinguish them?
> >
> The internal clock mapping is different for each module.
>
Or we can use one compatible string, but need add another property
"fsl,asrc-clk-map" to distinguish the different clock map.
The change is in below.
Which one do you think is better?
Required properties:
- - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc".
+ - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc",
+ "fsl,imx8qm-asrc".
- reg : Offset and length of the register set for the device.
@@ -35,6 +36,11 @@ Required properties:
- fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends.
+ - fsl,asrc-clk-map : Defines clock map used in driver. which is required
+ by imx8qm
+ <0> - select the map for asrc0
+ <1> - select the map for asrc1
+
Optional properties:
Best regards
Wang shengjiu
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
@ 2019-11-06 10:50 ` S.j. Wang
0 siblings, 0 replies; 8+ messages in thread
From: S.j. Wang @ 2019-11-06 10:50 UTC (permalink / raw)
To: S.j. Wang, Rob Herring
Cc: mark.rutland, devicetree, alsa-devel, timur, Xiubo.Lee, festevam,
tiwai, lgirdwood, nicoleotsuka, broonie, linuxppc-dev,
linux-kernel
Hi Rob
>
> Hi
> >
> > On Wed, Oct 30, 2019 at 07:41:26PM +0800, Shengjiu Wang wrote:
> > > In order to support the two asrc modules in imx8qm, we need to add
> > > compatible string "fsl,imx8qm-asrc0" and "fsl,imx8qm-asrc1"
> >
> > Are the blocks different in some way?
> >
> > If not, why do you need to distinguish them?
> >
> The internal clock mapping is different for each module.
>
Or we can use one compatible string, but need add another property
"fsl,asrc-clk-map" to distinguish the different clock map.
The change is in below.
Which one do you think is better?
Required properties:
- - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc".
+ - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc",
+ "fsl,imx8qm-asrc".
- reg : Offset and length of the register set for the device.
@@ -35,6 +36,11 @@ Required properties:
- fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends.
+ - fsl,asrc-clk-map : Defines clock map used in driver. which is required
+ by imx8qm
+ <0> - select the map for asrc0
+ <1> - select the map for asrc1
+
Optional properties:
Best regards
Wang shengjiu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
@ 2019-11-07 7:51 ` S.j. Wang
0 siblings, 0 replies; 8+ messages in thread
From: S.j. Wang @ 2019-11-07 7:51 UTC (permalink / raw)
To: Rob Herring
Cc: timur, nicoleotsuka, Xiubo.Lee, festevam, broonie, alsa-devel,
lgirdwood, perex, tiwai, mark.rutland, devicetree, linuxppc-dev,
linux-kernel
Hi Rob
>
> On Wed, Oct 30, 2019 at 07:41:26PM +0800, Shengjiu Wang wrote:
> > In order to support the two asrc modules in imx8qm, we need to add
> > compatible string "fsl,imx8qm-asrc0" and "fsl,imx8qm-asrc1"
>
> Are the blocks different in some way?
>
> If not, why do you need to distinguish them?
>
The internal clock mapping is different for each module.
Or we can use one compatible string, but need add another
property "fsl,asrc-clk-map" to distinguish the different clock map.
The change is in below.
Which one do you think is better?
Required properties:
- - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc".
+ - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc",
+ "fsl,imx8qm-asrc".
- reg : Offset and length of the register set for the device.
@@ -35,6 +36,11 @@ Required properties:
- fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends.
+ - fsl,asrc-clk-map : Defines clock map used in driver. which is required
+ by imx8qm
+ <0> - select the map for asrc0
+ <1> - select the map for asrc1
+
Optional properties:
Best regards
Wang shengjiu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
@ 2019-11-07 7:51 ` S.j. Wang
0 siblings, 0 replies; 8+ messages in thread
From: S.j. Wang @ 2019-11-07 7:51 UTC (permalink / raw)
To: Rob Herring
Cc: mark.rutland, devicetree, alsa-devel, timur, Xiubo.Lee,
linuxppc-dev, tiwai, lgirdwood, perex, nicoleotsuka, broonie,
festevam, linux-kernel
Hi Rob
>
> On Wed, Oct 30, 2019 at 07:41:26PM +0800, Shengjiu Wang wrote:
> > In order to support the two asrc modules in imx8qm, we need to add
> > compatible string "fsl,imx8qm-asrc0" and "fsl,imx8qm-asrc1"
>
> Are the blocks different in some way?
>
> If not, why do you need to distinguish them?
>
The internal clock mapping is different for each module.
Or we can use one compatible string, but need add another
property "fsl,asrc-clk-map" to distinguish the different clock map.
The change is in below.
Which one do you think is better?
Required properties:
- - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc".
+ - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc",
+ "fsl,imx8qm-asrc".
- reg : Offset and length of the register set for the device.
@@ -35,6 +36,11 @@ Required properties:
- fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends.
+ - fsl,asrc-clk-map : Defines clock map used in driver. which is required
+ by imx8qm
+ <0> - select the map for asrc0
+ <1> - select the map for asrc1
+
Optional properties:
Best regards
Wang shengjiu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
2019-10-30 11:41 Shengjiu Wang
@ 2019-11-05 22:06 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2019-11-05 22:06 UTC (permalink / raw)
To: Shengjiu Wang
Cc: timur, nicoleotsuka, Xiubo.Lee, festevam, broonie, alsa-devel,
lgirdwood, perex, tiwai, mark.rutland, devicetree, linuxppc-dev,
linux-kernel
On Wed, Oct 30, 2019 at 07:41:26PM +0800, Shengjiu Wang wrote:
> In order to support the two asrc modules in imx8qm, we need to
> add compatible string "fsl,imx8qm-asrc0" and "fsl,imx8qm-asrc1"
Are the blocks different in some way?
If not, why do you need to distinguish them?
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/fsl,asrc.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> index 1d4d9f938689..cd2bd3daa7e1 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> @@ -8,7 +8,8 @@ three substreams within totally 10 channels.
>
> Required properties:
>
> - - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc".
> + - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc",
> + "fsl,imx8qm-asrc0" or "fsl,imx8qm-asrc1".
>
> - reg : Offset and length of the register set for the device.
>
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
@ 2019-11-05 22:06 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2019-11-05 22:06 UTC (permalink / raw)
To: Shengjiu Wang
Cc: mark.rutland, devicetree, alsa-devel, timur, Xiubo.Lee,
linuxppc-dev, tiwai, lgirdwood, perex, nicoleotsuka, broonie,
festevam, linux-kernel
On Wed, Oct 30, 2019 at 07:41:26PM +0800, Shengjiu Wang wrote:
> In order to support the two asrc modules in imx8qm, we need to
> add compatible string "fsl,imx8qm-asrc0" and "fsl,imx8qm-asrc1"
Are the blocks different in some way?
If not, why do you need to distinguish them?
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/fsl,asrc.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> index 1d4d9f938689..cd2bd3daa7e1 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> @@ -8,7 +8,8 @@ three substreams within totally 10 channels.
>
> Required properties:
>
> - - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc".
> + - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc",
> + "fsl,imx8qm-asrc0" or "fsl,imx8qm-asrc1".
>
> - reg : Offset and length of the register set for the device.
>
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm
@ 2019-10-30 11:41 Shengjiu Wang
2019-11-05 22:06 ` Rob Herring
0 siblings, 1 reply; 8+ messages in thread
From: Shengjiu Wang @ 2019-10-30 11:41 UTC (permalink / raw)
To: timur, nicoleotsuka, Xiubo.Lee, festevam, broonie, alsa-devel,
lgirdwood, perex, tiwai, robh+dt, mark.rutland, devicetree
Cc: linuxppc-dev, linux-kernel
In order to support the two asrc modules in imx8qm, we need to
add compatible string "fsl,imx8qm-asrc0" and "fsl,imx8qm-asrc1"
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
Documentation/devicetree/bindings/sound/fsl,asrc.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
index 1d4d9f938689..cd2bd3daa7e1 100644
--- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
+++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
@@ -8,7 +8,8 @@ three substreams within totally 10 channels.
Required properties:
- - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc".
+ - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc",
+ "fsl,imx8qm-asrc0" or "fsl,imx8qm-asrc1".
- reg : Offset and length of the register set for the device.
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-11-07 8:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 10:50 [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm S.j. Wang
2019-11-06 10:50 ` S.j. Wang
2019-11-06 10:50 ` [alsa-devel] " S.j. Wang
-- strict thread matches above, loose matches on Subject: below --
2019-11-07 7:51 S.j. Wang
2019-11-07 7:51 ` S.j. Wang
2019-10-30 11:41 Shengjiu Wang
2019-11-05 22:06 ` Rob Herring
2019-11-05 22:06 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.