All of lore.kernel.org
 help / color / mirror / Atom feed
From: Priyanka Jain <priyanka.jain@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] T1042RDB_PI_NAND_SECURE_BOOT: SECURE_BOOT means environment is nowhere
Date: Mon, 18 Nov 2019 07:29:51 +0000	[thread overview]
Message-ID: <VE1PR04MB6494131A86A9150DFD204DF4E64D0@VE1PR04MB6494.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191115132117.GG19317@bill-the-cat>



>-----Original Message-----
>From: Tom Rini <trini@konsulko.com>
>Sent: Friday, November 15, 2019 6:51 PM
>To: Priyanka Jain <priyanka.jain@nxp.com>
>Cc: u-boot at lists.denx.de
>Subject: Re: [U-Boot] [PATCH 4/5] T1042RDB_PI_NAND_SECURE_BOOT:
>SECURE_BOOT means environment is nowhere
>
>On Fri, Nov 15, 2019 at 12:43:48PM +0000, Priyanka Jain wrote:
>>
>>
>> >-----Original Message-----
>> >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Tom Rini
>> >Sent: Thursday, November 14, 2019 8:24 PM
>> >To: u-boot at lists.denx.de
>> >Subject: [U-Boot] [PATCH 4/5] T1042RDB_PI_NAND_SECURE_BOOT:
>> >SECURE_BOOT means environment is nowhere
>> >
>> >Signed-off-by: Tom Rini <trini@konsulko.com>
>> >---
>> > board/freescale/t104xrdb/spl.c | 2 ++
>> > 1 file changed, 2 insertions(+)
>> >
>> >diff --git a/board/freescale/t104xrdb/spl.c
>> >b/board/freescale/t104xrdb/spl.c index 7b0eb8edf51d..76b5160cf903
>> >100644
>> >--- a/board/freescale/t104xrdb/spl.c
>> >+++ b/board/freescale/t104xrdb/spl.c
>> >@@ -106,6 +106,7 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>> >#endif
>> >
>> > 	/* relocate environment function pointers etc. */
>> >+#ifndef CONFIG_NXP_ESBC
>> Can we use some ENV related config instead of this?
>
>We could but I think that's more fragile / complex:
>

>> > #ifdef CONFIG_SPL_NAND_BOOT
>> > 	nand_spl_load_image(CONFIG_ENV_OFFSET, CONFIG_ENV_SIZE,
>> > 			    (uchar *)CONFIG_ENV_ADDR);
>> >@@ -120,6 +121,7 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>#endif
>> > 	gd->env_addr  = (ulong)(CONFIG_ENV_ADDR);
>> > 	gd->env_valid = ENV_VALID;
>> >+#endif
>
>The endif goes here since we have cases on NAND / MMC / SPI loading the
>environment and then we say it's now valid (and where it is).  We could
>do:
>#if defined(CONFIG_ENV_IS_IN_NAND) || defined(CONFIG_ENV_IS_IN_MMC)
>|| \
>	defined(CONFIG_ENV_IS_IN__SPI_FLASH)
>
This looks better as this is env related code. 
>if you prefer instead of CONFIG_NXP_ESBC
>
>--
>Tom 
-priyankajain

  reply	other threads:[~2019-11-18  7:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 14:54 [U-Boot] [PATCH 1/5] env: Remove useless CONFIG_ENV_SIZE_REDUND and fix ENV_IS_REDUND check Tom Rini
2019-11-14 14:54 ` [U-Boot] [PATCH 2/5] fsl: layerscape: guard *env_sf_get_env_addr() on CONFIG_ENV_IS_IN_SPI_FLASH Tom Rini
2019-11-15 12:43   ` Priyanka Jain
2019-11-14 14:54 ` [U-Boot] [PATCH 3/5] smart-gateway-mt7688: Correct build time check for overwriting factory data Tom Rini
2019-11-14 16:50   ` Stefan Roese
2019-11-14 16:59     ` Tom Rini
2019-11-14 14:54 ` [U-Boot] [PATCH 4/5] T1042RDB_PI_NAND_SECURE_BOOT: SECURE_BOOT means environment is nowhere Tom Rini
2019-11-15 12:43   ` Priyanka Jain
2019-11-15 13:21     ` Tom Rini
2019-11-18  7:29       ` Priyanka Jain [this message]
2019-11-14 14:54 ` [U-Boot] [PATCH 5/5] env: Finish migration of common ENV options Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR04MB6494131A86A9150DFD204DF4E64D0@VE1PR04MB6494.eurprd04.prod.outlook.com \
    --to=priyanka.jain@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.