From mboxrd@z Thu Jan  1 00:00:00 1970
From: Priyanka Jain <priyanka.jain@nxp.com>
Date: Wed, 3 Feb 2021 08:15:49 +0000
Subject: Subject:[PATCH v2 4/4] board/km: add support for seli8 design
 based on nxp ls102x
In-Reply-To: <VI1PR06MB40295BD611859FA7D6FE6D7AD2B59@VI1PR06MB4029.eurprd06.prod.outlook.com>
References: <VI1PR06MB40295BD611859FA7D6FE6D7AD2B59@VI1PR06MB4029.eurprd06.prod.outlook.com>
Message-ID: <VE1PR04MB64943F750ECD522AF4CBDA52E6B49@VE1PR04MB6494.eurprd04.prod.outlook.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



>-----Original Message-----
>From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Aleksandar
>Gerasimovski
>Sent: Tuesday, February 2, 2021 2:37 PM
>To: Priyanka Jain (OSS) <priyanka.jain@oss.nxp.com>; u-boot at lists.denx.de
>Cc: Valentin Longchamp <valentin.longchamp@hitachi-powergrids.com>; Holger
>Brunck <holger.brunck@hitachi-powergrids.com>; Rainer Boschung
><rainer.boschung@hitachi-powergrids.com>; Matteo Ghidoni
><matteo.ghidoni@hitachi-powergrids.com>
>Subject: RE: Subject:[PATCH v2 4/4] board/km: add support for seli8 design based
>on nxp ls102x
>
>
>-----Original Message-----
>From: Priyanka Jain (OSS) <priyanka.jain@oss.nxp.com>
>Sent: Dienstag, 2. Februar 2021 07:33
>To: Aleksandar Gerasimovski <aleksandar.gerasimovski@hitachi-
>powergrids.com>; Priyanka Jain (OSS) <priyanka.jain@oss.nxp.com>; u-
>boot at lists.denx.de
>Cc: Valentin Longchamp <valentin.longchamp@hitachi-powergrids.com>; Holger
>Brunck <holger.brunck@hitachi-powergrids.com>; Rainer Boschung
><rainer.boschung@hitachi-powergrids.com>; Matteo Ghidoni
><matteo.ghidoni@hitachi-powergrids.com>
>Subject: RE: Subject: [PATCH v2 4/4] board/km: add support for seli8 design based
>on nxp ls102x
>
>CAUTION: This email originated from outside of the organization. Do not click
>links or open attachments unless you recognize the sender and know the content
>is safe.
>
>
>>-----Original Message-----
>>From: Aleksandar Gerasimovski <aleksandar.gerasimovski@hitachi-
>>powergrids.com>
>>Sent: Tuesday, January 19, 2021 4:11 PM
>>To: Priyanka Jain (OSS) <priyanka.jain@oss.nxp.com>;
>>u-boot at lists.denx.de
>>Cc: Valentin Longchamp <valentin.longchamp@hitachi-powergrids.com>;
>>Holger Brunck <holger.brunck@hitachi-powergrids.com>; Rainer Boschung
>><rainer.boschung@hitachi-powergrids.com>; Matteo Ghidoni
>><matteo.ghidoni@hitachi-powergrids.com>
>>Subject: Subject: [PATCH v2 4/4] board/km: add support for seli8 design
>>based on nxp ls102x
>>
>>The SELI8 design is a new tdm service unit card for Hitachi-Powergrids
>>XMC and FOX product lines.
>>
>>It is based on NXP LS1021 SoC and it provides following interfaces:
>> - IFC interface for NOR, NAND and external FPGA's
>> - 1 x RGMII ETH for debug purposes
>> - 2 x SGMII ETH for management communication via back-plane
>> - 1 x uQE HDLC for management communication via back-plane
>> - 1 x I2C for peripheral devices
>> - 1 x SPI for peripheral devices
>> - 1 x UART for debug logging
>>
>>It is foreseen that the design will be later re-used for another XMC
>>and FOX service cards with similar SoC requirements.
>>
>>Signed-off-by: Rainer Boschung <rainer.boschung@hitachi-powergrids.com>
>>Signed-off-by: Matteo Ghidoni <matteo.ghidoni@hitachi-powergrids.com>
>>Signed-off-by: Aleksandar Gerasimovski
>><aleksandar.gerasimovski@hitachi- powergrids.com>
>>---
><snip>
>Kindly fix below checkpatch errors /warnings
>WARNING: 'AYSNC' may be misspelled - perhaps 'ASYNC'?
>#799: FILE: include/configs/km/pg-wcom-ls102xa.h:64:
>+                                       CSOR_NOR_NOR_MODE_AYSNC_NOR | \
>
>ERROR: All commands are managed by Kconfig
>#953: FILE: include/configs/km/pg-wcom-ls102xa.h:218:
>+#define CONFIG_CMDLINE_TAG
>
>total: 1 errors, 2 warnings, 0 checks, 964 lines checked
>
>Regards
>Priyanka
>
>Hi Priyanka,
>
>CSOR_NOR_NOR_MODE_AYSNC_NOR is named like in mainline (nxp) see
>include/fsl_ifc.h If you asking me to change that than it belongs to a separate
>patch, not this topic.
>
OK this warning can be ignored

>CONFIG_CMDLINE_TAG is a whitelisted on mainline, there is no Kconfig for that.
>

Tom,

How to handle this checkpatch error?
CONFIG_CMDLINE_TAG is a whitelisted in mainline, but checkpatch is throwing error.
Can I go ahead and accept this patch ?

Regards
Priyanka


>Regards,
>Aleksandar
>