RE: [EXT] Re: [v1,iproute2 1/2] iproute2:tc:action: add a gate control action

From: Po Liu <po.liu@nxp.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Alexandru Marginean <alexandru.marginean@nxp.com>,
	Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
	Roy Zang <roy.zang@nxp.com>, Mingkai Hu <mingkai.hu@nxp.com>,
	Jerry Huang <jerry.huang@nxp.com>, Leo Li <leoyang.li@nxp.com>,
	"michael.chan@broadcom.com" <michael.chan@broadcom.com>,
	"vishal@chelsio.com" <vishal@chelsio.com>,
	"saeedm@mellanox.com" <saeedm@mellanox.com>,
	"leon@kernel.org" <leon@kernel.org>,
	"jiri@mellanox.com" <jiri@mellanox.com>,
	"idosch@mellanox.com" <idosch@mellanox.com>,
	"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
	"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"jhs@mojatatu.com" <jhs@mojatatu.com>,
	"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
	"simon.horman@netronome.com" <simon.horman@netronome.com>,
	"pablo@netfilter.org" <pablo@netfilter.org>,
	"moshe@mellanox.com" <moshe@mellanox.com>,
	"m-karicheri2@ti.com" <m-karicheri2@ti.com>,
	"andre.guedes@linux.intel.com" <andre.guedes@linux.intel.com>,
	David Ahern <dsahern@gmail.com>
Subject: RE: [EXT] Re: [v1,iproute2  1/2] iproute2:tc:action: add a gate control action
Date: Wed, 25 Mar 2020 02:40:10 +0000	[thread overview]
Message-ID: <VE1PR04MB64968CF9E07D5CA510D2369492CE0@VE1PR04MB6496.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200324145912.657f2c9e@hermes.lan>

Hi Stephen,

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: 2020年3月25日 5:59
> To: Po Liu <po.liu@nxp.com>
> Cc: davem@davemloft.net; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; vinicius.gomes@intel.com; Claudiu Manoil
> <claudiu.manoil@nxp.com>; Vladimir Oltean <vladimir.oltean@nxp.com>;
> Alexandru Marginean <alexandru.marginean@nxp.com>; Xiaoliang Yang
> <xiaoliang.yang_1@nxp.com>; Roy Zang <roy.zang@nxp.com>; Mingkai Hu
> <mingkai.hu@nxp.com>; Jerry Huang <jerry.huang@nxp.com>; Leo Li
> <leoyang.li@nxp.com>; michael.chan@broadcom.com; vishal@chelsio.com;
> saeedm@mellanox.com; leon@kernel.org; jiri@mellanox.com;
> idosch@mellanox.com; alexandre.belloni@bootlin.com;
> UNGLinuxDriver@microchip.com; kuba@kernel.org; jhs@mojatatu.com;
> xiyou.wangcong@gmail.com; simon.horman@netronome.com;
> pablo@netfilter.org; moshe@mellanox.com; m-karicheri2@ti.com;
> andre.guedes@linux.intel.com; David Ahern <dsahern@gmail.com>
> Subject: [EXT] Re: [v1,iproute2 1/2] iproute2:tc:action: add a gate control
> action
> 
> Caution: EXT Email
> 
> On Tue, 24 Mar 2020 11:47:44 +0800
> Po Liu <Po.Liu@nxp.com> wrote:
> 
> > diff --git a/include/uapi/linux/pkt_cls.h
> > b/include/uapi/linux/pkt_cls.h index a6aa466..7a047a9 100644
> > --- a/include/uapi/linux/pkt_cls.h
> > +++ b/include/uapi/linux/pkt_cls.h
> > @@ -106,6 +106,7 @@ enum tca_id {
> >       TCA_ID_SAMPLE = TCA_ACT_SAMPLE,
> >       TCA_ID_CTINFO,
> >       TCA_ID_MPLS,
> > +     TCA_ID_GATE,
> >       TCA_ID_CT,
> >       /* other actions go here */
> >       __TCA_ID_MAX = 255
> 
> All uapi headers need to come from checked in kernel.
> 
> This is an example of why, you have an out of date version because this
> version would have broken ABI.
> 
> 
> This patch should be against iproute2-next since because it depends on
> net-next.

I'll keep up with the iproute2-next branch. Thanks!

Br,
Po Liu