From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEE99C0650E for ; Wed, 3 Jul 2019 10:32:17 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 652FF218A5 for ; Wed, 3 Jul 2019 10:32:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="sT1KRYOc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 652FF218A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9674D1B94F; Wed, 3 Jul 2019 12:32:15 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130088.outbound.protection.outlook.com [40.107.13.88]) by dpdk.org (Postfix) with ESMTP id 07DDA5B3E; Wed, 3 Jul 2019 12:32:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RKM3/TvSHgCk8sWwswPxSr4LDHd24X4tgmMv2REj4ro=; b=sT1KRYOc08amzuvq7aMH6CmuCgovhh9Rj0NoiY+BY6CixfcJ9OWLGHv79nZ6jwCyceZyJT64DTWYeIs+YGz3TGCL2IKvUEeilhvyCpLrc7XtvrI3q7uKoiREeJYsQQGQmFrIu9OoB4b3WfgS8v38wbzDUOYOGDSkIYPajeEN7lY= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6494.eurprd04.prod.outlook.com (20.179.233.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Wed, 3 Jul 2019 10:32:12 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.2032.019; Wed, 3 Jul 2019 10:32:12 +0000 From: Akhil Goyal To: "Iremonger, Bernard" , "Ananyev, Konstantin" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto Thread-Index: AQHVIS5r8sG9YVSumkyzkOG5VMHLPqaZhjuAgB9EOiCAAAMMAIAAACwAgAAEh4CAAAA/sA== Date: Wed, 3 Jul 2019 10:32:12 +0000 Message-ID: References: <1559819547-20742-1-git-send-email-bernard.iremonger@intel.com> <1560351121-21234-2-git-send-email-bernard.iremonger@intel.com> <2601191342CEEE43887BDE71AB97725801688E4E2C@IRSMSX104.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C260DC128E@IRSMSX108.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C260DC12DA@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DC12DA@IRSMSX108.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5e020f72-2e0e-4240-f07d-08d6ffa1b617 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6494; x-ms-traffictypediagnostic: VE1PR04MB6494: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 00872B689F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(199004)(189003)(6246003)(478600001)(256004)(7736002)(86362001)(14444005)(66446008)(55016002)(446003)(229853002)(64756008)(305945005)(71200400001)(8676002)(81166006)(66946007)(9686003)(33656002)(66556008)(74316002)(71190400001)(2501003)(53936002)(81156014)(73956011)(6436002)(66066001)(99286004)(476003)(186003)(14454004)(5660300002)(2906002)(11346002)(76176011)(486006)(8936002)(25786009)(102836004)(6506007)(52536014)(44832011)(4326008)(3846002)(26005)(76116006)(110136005)(6116002)(68736007)(7696005)(66476007)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6494; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: AoF1bLu8t9sFXIzcTZXTQGIzioIl9PdX9RM7hoyq0TKsXVFwIBIbt82KNmNPNZB0U2twQIf2GYzMHXXiCzyeYfLrPCuBzUwhefE77Awbx8/Z62d24RFx8qcVzyX63I+ZjleZMf+7eDILNKLpc7zv7OjW/LwbmInlLRXhY5XVpWUcnFiv5QVJmJq8sZ5OotpFRfeQqV0PRCCjl/Q4ARoqNGM6gYOxx0d3ho5KI9dpOpU3PS5SNmFqefmKSMf8qkLYTz+Nfvwj7S3e/DSaoe2wKWW3b2aRj51UKLbs7wb0qgIv5ZBnYJTnn3wfH0pm9qVqmVuI/KAxh+47IBujNXGcsFCn87qOZL7VkUfLpxSYrAUe2HxcxKn/AG48T+q+H63TYThom3Zl3LbrkA7vjIx+sF3Ats1eWbFdZGs1Vd72X14= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e020f72-2e0e-4240-f07d-08d6ffa1b617 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2019 10:32:12.8524 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6494 Subject: Re: [dpdk-dev] [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Akhil, >=20 > > > > > > > > > > > > Hi Akhil, > > > > > > > > > > > Hi Bernard, > > > > > > > > > > > > > > > > Inline crypto installs a flow rule in the NIC. This flow rule > > > > > > must be installed before the first inbound packet is received. > > > > > > > > > > > > The create_session() function installs the flow rule, > > > > > > create_session() has been refactored into > > > > > > create_inline_session() and create_lookaside_session(). The > > > > > > create_inline_session() function uses the socket_ctx data and i= s > > > > > > now called at initialisation in sa_add_rules(). > > > > > > > > > > > > The max_session_size() function has been added to calculate > > > > > > memory requirements. > > > > > > > > > > > > The cryprodev_init() function has been refactored to drop calls > > > > > > to > > > > > > rte_mempool_create() and to drop calculation of memory > > requirements. > > > > > > > > > > > > The main() function has been refactored to call > > > > > > max_session_size() and to call session_pool_init() and > > session_priv_pool_init() earlier. > > > > > > The ports are started now before adding a flow rule in main(). > > > > > > The sa_init(), sp4_init(), sp6_init() and rt_init() functions > > > > > > are now called after the ports have been started. > > > > > > > > > > > > The rte_ipsec_session_prepare() function is called in > > > > > > fill_ipsec_session() for inline which is called from the > > > > > > ipsec_sa_init() > > > > function. > > > > > > > > > > > > Fixes: ec17993a145a ("examples/ipsec-secgw: support security > > > > > > offload") > > > > > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample > > > > > > application") > > > > > > Cc: stable@dpdk.org > > > > > > > > > > > > Signed-off-by: Bernard Iremonger > > > > > > --- > > > > > > > > > > Acked-by: Konstantin Ananyev > > > > > Tested-by: Konstantin Ananyev > > > > > > > > > > > > > This patch need to be rebased. > > > > > > > > However, I will try to work on your v5 in next few days if I get > > > > time. If I don't get time to fix that, will need you to send a reba= sed > > version of this patch. > > > > > > > > Thanks, > > > > Akhil > > > > > > > > > > v6 is the latest version > > > I will send a v7 rebased on 19.08.rc1 > > > > I was talking about your previous which was for both lookaside and inli= ne > > cases to create sessions at init time. > > If I get time, I will fix that or will ask you to rebase this one. > > > > > > Regards, > > > > > > Bernard > > > >=20 > They previous one was v4, where we could not test the lookaside code. > Should I rebase the v4 and send as v7? >=20 I will let you know, if your v4 can work well or your v6 will be rebased an= d applied. > Regards, >=20 > Bernard. >=20