From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65AE9C0650F for ; Tue, 30 Jul 2019 09:03:12 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id EC8F720644 for ; Tue, 30 Jul 2019 09:03:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="is6ZGbVx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC8F720644 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA2511BFED; Tue, 30 Jul 2019 11:03:10 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80087.outbound.protection.outlook.com [40.107.8.87]) by dpdk.org (Postfix) with ESMTP id D52F11BFE7 for ; Tue, 30 Jul 2019 11:03:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d8xdo6yQT7lSBRoefgsGDXPRGoGloawwctAKDK1eQZKx+e6fwbAHAfrocmy1+s9YURfpkheZY9ij61Fc+Uhi/HSeSAnU0N+AGun4L7Wq+In8d0cfw0LcxzaOznIeWruWntN8zkdABsYNszz20vPC2yIn4+pdXngIAEwjVdKf8mJfHO+NiZ++fSl6dv//ymLUBA0FCg43vq5FeFdqXCbtd5rdxTkSQpkVoOSM3w3X6y8C+RKZRScCJQjhx4hflChWq66M7Q9mK+z5QHY+4+SIhHt5J/0geEbb99sVnQVzDy76NOMhOyWGoK/3qhwOz/pYC6ZkkkWG0JTKKUz2/nQsSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V+qFRotcYWxIRwlPo8kWw+9cw5bv0n1YdrtDvJ4HvUM=; b=U3rA1FEnQ9VfIov07VphHkDogkj34do9vaORlCkG/E6kRosz6bdce8Okx6+ATz8CW6pGh/Ui34Wi0oQ0tqt45f8y6stA1UsBdbC0MVXh4skMIwtPYKTCvt0mV8kt64x+ruM3sUZa6h7pv45Lwiyh7YUNfb/bvDuGXnDt2rs+AKHpFb/zBZDT/rvdpU40AV4bnXM0ob1k6kxfBIZ1kIx2KOi2jw212Vj8UPmd0uiAL4vBYtChCdxaUjgFXanvE8aHvCW6xa8R+CN2DSuf+Yba1dtEMb2jb4iKsgLGGj2jKmiWMYEf7ZoEVFphk3UrgOen3Oc7WaotHG5fiqFZdHBm6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=nxp.com;dmarc=pass action=none header.from=nxp.com;dkim=pass header.d=nxp.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V+qFRotcYWxIRwlPo8kWw+9cw5bv0n1YdrtDvJ4HvUM=; b=is6ZGbVxPEoLCgTyCjg/i9CUidcVAHXnoVZ3nv1jldW69qD/6ni81s9NoTsbuKaX0suw1rJJkBKo74MxOoA85wPxX/VMGrzOSw86S3enqmCmw67Dm9idZnt326tR6VWn8AR42oDq7diVG6NEIW9ezdEMOy5bwlX1C7wdsnMa0u0= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6447.eurprd04.prod.outlook.com (20.179.232.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Tue, 30 Jul 2019 09:03:07 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::964:4ddc:346b:e2ec]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::964:4ddc:346b:e2ec%7]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 09:03:07 +0000 From: Akhil Goyal To: Thomas Monjalon CC: Bernard Iremonger , "dev@dpdk.org" , Anoob Joseph , "konstantin.ananyev@intel.com" , Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya Thread-Topic: [dpdk-dev] [EXT] [PATCH] doc: deprecate legacy code path in ipsec-secgw Thread-Index: AQHVRitzwTpsrZhZLECEWe3JhP6PuqbiqGgwgAAWsgCAAAED4IAAC4QAgAAOSbCAAAM9gIAAAOwQ Date: Tue, 30 Jul 2019 09:03:07 +0000 Message-ID: References: <1562835937-24141-1-git-send-email-bernard.iremonger@intel.com> <2417926.RaMoeEf8dU@xps> <2658214.f7z3ihukRQ@xps> In-Reply-To: <2658214.f7z3ihukRQ@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b20f8401-2a2e-4b45-0a8f-08d714ccbd5d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6447; x-ms-traffictypediagnostic: VE1PR04MB6447: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0114FF88F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(396003)(39860400002)(346002)(376002)(199004)(189003)(13464003)(6506007)(446003)(14454004)(256004)(6436002)(76176011)(6246003)(14444005)(54906003)(99286004)(7696005)(186003)(53546011)(66066001)(55016002)(3846002)(4326008)(6116002)(25786009)(102836004)(26005)(9686003)(86362001)(33656002)(6916009)(11346002)(8676002)(52536014)(71200400001)(71190400001)(305945005)(478600001)(229853002)(8936002)(2906002)(81156014)(53936002)(81166006)(316002)(476003)(68736007)(5660300002)(76116006)(66946007)(486006)(74316002)(44832011)(64756008)(66476007)(66556008)(66446008)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6447; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: rBddRhJ69KC3nQZ85FV9w7nGXJnj8Kd4NI8ki1HnDzSHxLiGrSAO6K2zswqLex/8tAvU8rhdr1cKV+g+EJ3OdkxF/V6Qb8a43b3dtpojLi5MQWC1m+Z8H8cRlGHt6NfQeRHIsYwafvyZDdxWJhsgL9psGjwZyTbDahh31QOAQAWP+/s2FMgAV6K01V1CqfZPZPE734DL++QmdjLe9a9DsfRldxrAG0OGJeOWD0T8DrtCikgi1XHJztWk14eLOxjVoqwswBiPMRnLEjUC2AW2kn/Uj653KWrREhNQ/ZBPutnPWtX6iIEuTCeeEbHS652GYOkSU5s+p6utyHPPYbfsUTJkPZJyJtulrxiU6s9pL0bRuCJtQTmY8MicdEZuFcDnJy8ifST91ktJQUAdSyP72Kj2iYTagHh2qEKk5udwNfQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b20f8401-2a2e-4b45-0a8f-08d714ccbd5d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 09:03:07.8480 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6447 Subject: Re: [dpdk-dev] [EXT] [PATCH] doc: deprecate legacy code path in ipsec-secgw X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, July 30, 2019 2:27 PM > To: Akhil Goyal > Cc: Bernard Iremonger ; dev@dpdk.org; Anoob > Joseph ; konstantin.ananyev@intel.com; Jerin Jacob > Kollanukkaran ; Narayana Prasad Raju Athreya > > Subject: Re: [dpdk-dev] [EXT] [PATCH] doc: deprecate legacy code path in = ipsec- > secgw >=20 > 30/07/2019 10:48, Akhil Goyal: > > > 30/07/2019 09:20, Akhil Goyal: > > > > > 30/07/2019 07:55, Akhil Goyal: > > > > > > > > > > All the functionality of the legacy code path in now av= ailable > > > > > > > > > > in the librte_ipsec library. > > > > > > > > > > It is planned to deprecate the legacy code path in the = 19.11 > > > > > > > > > > release and remove the legacy code path in the 20.02 re= lease. > > > > > > > > > > > > > > > > > > > > Signed-off-by: Bernard Iremonger > > > > > > > > > > > Acked-by: Konstantin Ananyev > > > > > > > > > > Acked-by: Fan Zhang > > > > > > > > > > Acked-by: Akhil Goyal > > > > > > > > > > --- > > > > > > > > > > doc/guides/rel_notes/deprecation.rst | 5 +++++ > > > > > > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > > > > > > > > > > Acked-by: Anoob Joseph > > > > > > > > > > > > > > > > Applied to dpdk-next-crypto > > > > > > > > > > > > > > Why do we have a deprecation notice for some code path in an > example? > > > > > > > The deprecation notices are for the API. > > > > > > > > > > > > > > I think you can drop the legacy code in 19.11, > > > > > > > and I don't merge this patch in master. > > > > > > > > > > > > We are planning to remove the original code and replace it with= IPSec > > > > > > library APIs which are still experimental. > > > > > > With this change there won't be any example of the legacy ipsec= code > path. > > > > > > That's good to drop old code. > > > If someone still wants to look at it, it is in old releases. > > > > > > > > > Applications over DPDK take ipsec-secgw as an example and IPSec > > > > > > is a major use case for customers. There may also be performanc= e > > > > > > differences in the two code paths. Atleast on NXP platforms I s= aw > > > > > > 5-7% drop when the patches were originally submitted. > > > > > > Not sure what is the current state. > > > > > > That's a different issue you need to solve in the library. > > > > > > > > > I feel it is worth notifying the users that the original codepa= th is > > > > > > getting deprecated, so that they can plan to move to new IPSec = APIs. > > > > > > I hope they already planned to move when they saw the new library. > > > > > > > > The deprecation notice is not the right place for a change in an = example. > > > > > What change is there in IPsec API? In which release? > > > > > > > > IPSec lib was introduced in 1902 release and a few enhancements > > > > are done thereafter. > > > > Previously all IPSec related stuff was done in the application, > > > > now we have IPSec Lib which perform similar work. > > > > There are changes both in datapath as well as control path. > > > > User need to adapt to the recent changes, as we may no longer > > > > support/maintain the datapath/control path which was done previousl= y > > > > and there may be some conflict. > > > > > > So the real DPDK change is to have a new library in 19.02. > > > > > > > If deprecation notice is not the right place, > > > > then where should it be notified before actually making the change. > > > > > > It has already been notified in "New Features" of 19.02 > > > that there is an IPsec library. What do you want to notify more? > > > Again, the example is not supposed to be a real application. > > > If you want to maintain an IPsec application with better quality rule= s, > > > I suggest to start a new git repository for it. > > > > OK got your point, but in that case, I would say, legacy code shall not= be > removed > > Until we have the ipsec lib as experimental. > > User should have both the code paths as long as we have ipsec library > experimental. >=20 > That's your take. > When do you plan to remove experimental status of IPsec library? >=20 There have been addition of some functionality in this release cycle. I wou= ld say we can wait for 1 release cycle for some fixes or changes which may be require= d. If it looks stable in next release cycle, we can make formal in DPDK 2002.