From mboxrd@z Thu Jan  1 00:00:00 1970
From: Qiang Zhao <qiang.zhao@nxp.com>
Date: Wed, 15 Apr 2020 08:32:02 +0000
Subject: [RFC PATCH] net, qe: add DM support for QE UEC ethernet
In-Reply-To: <635f8328-5345-fe59-05e8-5df2303677e2@denx.de>
References: <20200218090546.1507059-1-hs@denx.de>
 <d367364f-c525-91eb-dec7-026ef781a91a@denx.de>
 <VE1PR04MB676835B6E76A39D7D46A6B5491C10@VE1PR04MB6768.eurprd04.prod.outlook.com>
 <5c23f32f-c4db-f98d-1a54-b03437300e60@denx.de>
 <635f8328-5345-fe59-05e8-5df2303677e2@denx.de>
Message-ID: <VE1PR04MB6768EBD5B55B518A74FDB38691DB0@VE1PR04MB6768.eurprd04.prod.outlook.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Am 15.04.2020 um 06:57 schrieb Heiko Schocher:

> -----Original Message-----
> From: Heiko Schocher <hs@denx.de>
> Sent: 2020?4?15? 14:25
> To: Qiang Zhao <qiang.zhao@nxp.com>
> Cc: Priyanka Jain <priyanka.jain@nxp.com>; U-Boot Mailing List
> <u-boot@lists.denx.de>; Holger Brunck <holger.brunck@ch.abb.com>; Joe
> Hershberger <joe.hershberger@ni.com>; Mario Six <mario.six@gdsys.cc>
> Subject: Re: [RFC PATCH] net, qe: add DM support for QE UEC ethernet
> 
> Hello Qiang Zhao,
> 
> Am 15.04.2020 um 06:57 schrieb Heiko Schocher:
> > Hello Qiang Zhao,
> >
> > Am 09.04.2020 um 10:00 schrieb Qiang Zhao:
> >> On 2020/4/9 13:20, Heiko Schocher <hs@denx.de> wrote:
> >>
> >>
> >>> -----Original Message-----
> >>> From: Heiko Schocher <hs@denx.de>
> >>> Sent: 2020?4?9? 13:19
> >>> To: Priyanka Jain <priyanka.jain@nxp.com>
> >>> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Holger Brunck
> >>> <holger.brunck@ch.abb.com>; Joe Hershberger
> >>> <joe.hershberger@ni.com>; Mario Six <mario.six@gdsys.cc>; Qiang Zhao
> >>> <qiang.zhao@nxp.com>
> >>> Subject: Re: [RFC PATCH] net, qe: add DM support for QE UEC ethernet
> >>>
> >>> Hello Priyanka,
> >>>
> >>> Am 18.02.2020 um 10:05 schrieb Heiko Schocher:
> >>>> add DM/DTS suppor for the UEC ethernet on QUICC Engine Block.
> >>>>
> >>>> Signed-off-by: Heiko Schocher <hs@denx.de>
> >>>> ---
> >>>> Travis build:
> >>>>
> >>>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ft
> >>>> rav
> >>>>
> >>>
> is-ci.org%2Fhsdenx%2Fu-boot-test%2Fbuilds%2F651400509&amp;data=02%7C
> >>> 01
> >>>> %7Cqiang.zhao%40nxp.com%7C51477945d03e4b72383708d7dc458e7e
> %7C
> >>> 686ea1d3b
> >>>>
> >>>
> c2b4c6fa92cd99c5c301635%7C0%7C0%7C637220063612830833&amp;sdata
> >>> =MALxWjN
> >>>> kO0lgq1b0gmk646eEI8HWZUXRqTHt6zaOQPk%3D&amp;reserved=0
> >>>>
> >>>> - I let the old none DM based implementation in code
> >>>> ??? so boards should work with old implementation.
> >>>> ??? This Code should be removed if all boards are converted
> >>>> ??? to DM/DTS.
> >>>>
> >>>> - add the DM based qe uec driver under drivers/net/qe
> >>>>
> >>>> - Therefore copied the files uccf.c uccf.h uec.h from
> >>>> ??? drivers/qe. So there are a lot of Codingstyle problems
> >>>> ??? currently. I fix them in next version if this RFC
> >>>> ??? patch is OK or it needs some changes.
> >>>>
> >>>> - The dm based driver code is now under drivers/net/qe/dm_qe_uec.c
> >>>> ??? Used a lot of functions from drivers/qe/uec.c
 
We need to make sure the old qe uec driver and new dm driver could not be enabled at the same time.

> >>>>
> >>>> - seperated the PHY specific code into seperate file
> >>>> ??? drivers/net/qe/dm_qe_uec_phy.c
> >>
> 
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de

Best Regards
Qiang Zhao