From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurentiu Tudor Subject: RE: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms Date: Fri, 7 Apr 2017 14:00:58 +0000 Message-ID: References: <20170317100602.2837-8-horia.geanta@nxp.com> <87vaqkvk6c.fsf@concordia.ellerman.id.au> <58E39F90.6050408@nxp.com> <87lgrftbgl.fsf@concordia.ellerman.id.au> <58E4D9C3.4070406@nxp.com> <87inmggxp7.fsf@concordia.ellerman.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Cc: Claudiu Manoil , Cristian Stoica , Dan Douglass , "linux-arm-kernel@lists.infradead.org" , Vakul Garg , "linuxppc-dev@lists.ozlabs.org" , "David S. Miller" , Alexandru Porosanu , "linux-crypto@vger.kernel.org" To: Michael Ellerman , =?iso-8859-2?Q?Horia_Geant=E3?= , Herbert Xu , Scott Wood , Roy Pledge Return-path: Received: from mail-ve1eur01on0080.outbound.protection.outlook.com ([104.47.1.80]:9008 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751759AbdDGOBr (ORCPT ); Fri, 7 Apr 2017 10:01:47 -0400 In-Reply-To: <87inmggxp7.fsf@concordia.ellerman.id.au> Content-Language: en-US Sender: linux-crypto-owner@vger.kernel.org List-ID: -----Original Message----- From: Michael Ellerman [mailto:mpe@ellerman.id.au]=20 Sent: Friday, April 07, 2017 4:22 PM To: Laurentiu Tudor ; Horia Geant=E3 ; Herbert Xu ; Scott Wood ; Roy Pledge Cc: Claudiu Manoil ; Cristian Stoica ; Dan Douglass ; linux-arm-kernel@lists.in= fradead.org; Vakul Garg ; linuxppc-dev@lists.ozlabs.org= ; David S. Miller ; Alexandru Porosanu ; linux-crypto@vger.kernel.org Subject: Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms Importance: High Laurentiu Tudor writes: > On 04/05/2017 01:06 PM, Michael Ellerman wrote: >> Laurentiu Tudor writes: >> >>> Hi Michael, >>> >>> Just a couple of basic things to check: >>> - was the dtb updated to the newest? >> >> Possibly not, it's an automated build/boot, I'll have to check what=20 >> it does with the dtb. >> >>> - is the qman node present? This should be easily visible in=20 >>> /proc/device-tree/soc@ffe000000/qman@318000. >> >> No it's not there. >> >> That's running linux-next with: >> >> CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI=3Dn >> >> >> Does that mean I didn't update the device tree? > > I think so. Also, I just checked that the node is actually there by=20 > compiling p5020ds.dts and then decompiling the dtb. > OK, I'll make sure I update the DTB. >=20 > It will still be good if the code was a bit more robust about the qman be= ing missing. Totally agree. We should handle this error condition. --- Thanks & Best Regards, Laurentiu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0050.outbound.protection.outlook.com [104.47.1.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3w01Tp5K6XzDqGv for ; Sat, 8 Apr 2017 00:01:50 +1000 (AEST) From: Laurentiu Tudor To: Michael Ellerman , =?iso-8859-2?Q?Horia_Geant=E3?= , Herbert Xu , Scott Wood , Roy Pledge CC: Claudiu Manoil , Cristian Stoica , Dan Douglass , "linux-arm-kernel@lists.infradead.org" , Vakul Garg , "linuxppc-dev@lists.ozlabs.org" , "David S. Miller" , Alexandru Porosanu , "linux-crypto@vger.kernel.org" Subject: RE: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms Date: Fri, 7 Apr 2017 14:00:58 +0000 Message-ID: References: <20170317100602.2837-8-horia.geanta@nxp.com> <87vaqkvk6c.fsf@concordia.ellerman.id.au> <58E39F90.6050408@nxp.com> <87lgrftbgl.fsf@concordia.ellerman.id.au> <58E4D9C3.4070406@nxp.com> <87inmggxp7.fsf@concordia.ellerman.id.au> In-Reply-To: <87inmggxp7.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , -----Original Message----- From: Michael Ellerman [mailto:mpe@ellerman.id.au]=20 Sent: Friday, April 07, 2017 4:22 PM To: Laurentiu Tudor ; Horia Geant=E3 ; Herbert Xu ; Scott Wood ; Roy Pledge Cc: Claudiu Manoil ; Cristian Stoica ; Dan Douglass ; linux-arm-kernel@lists.in= fradead.org; Vakul Garg ; linuxppc-dev@lists.ozlabs.org= ; David S. Miller ; Alexandru Porosanu ; linux-crypto@vger.kernel.org Subject: Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms Importance: High Laurentiu Tudor writes: > On 04/05/2017 01:06 PM, Michael Ellerman wrote: >> Laurentiu Tudor writes: >> >>> Hi Michael, >>> >>> Just a couple of basic things to check: >>> - was the dtb updated to the newest? >> >> Possibly not, it's an automated build/boot, I'll have to check what=20 >> it does with the dtb. >> >>> - is the qman node present? This should be easily visible in=20 >>> /proc/device-tree/soc@ffe000000/qman@318000. >> >> No it's not there. >> >> That's running linux-next with: >> >> CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI=3Dn >> >> >> Does that mean I didn't update the device tree? > > I think so. Also, I just checked that the node is actually there by=20 > compiling p5020ds.dts and then decompiling the dtb. > OK, I'll make sure I update the DTB. >=20 > It will still be good if the code was a bit more robust about the qman be= ing missing. Totally agree. We should handle this error condition. --- Thanks & Best Regards, Laurentiu From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurentiu.tudor@nxp.com (Laurentiu Tudor) Date: Fri, 7 Apr 2017 14:00:58 +0000 Subject: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms In-Reply-To: <87inmggxp7.fsf@concordia.ellerman.id.au> References: <20170317100602.2837-8-horia.geanta@nxp.com> <87vaqkvk6c.fsf@concordia.ellerman.id.au> <58E39F90.6050408@nxp.com> <87lgrftbgl.fsf@concordia.ellerman.id.au> <58E4D9C3.4070406@nxp.com> <87inmggxp7.fsf@concordia.ellerman.id.au> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org -----Original Message----- From: Michael Ellerman [mailto:mpe at ellerman.id.au] Sent: Friday, April 07, 2017 4:22 PM To: Laurentiu Tudor ; Horia Geant? ; Herbert Xu ; Scott Wood ; Roy Pledge Cc: Claudiu Manoil ; Cristian Stoica ; Dan Douglass ; linux-arm-kernel at lists.infradead.org; Vakul Garg ; linuxppc-dev at lists.ozlabs.org; David S. Miller ; Alexandru Porosanu ; linux-crypto at vger.kernel.org Subject: Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms Importance: High Laurentiu Tudor writes: > On 04/05/2017 01:06 PM, Michael Ellerman wrote: >> Laurentiu Tudor writes: >> >>> Hi Michael, >>> >>> Just a couple of basic things to check: >>> - was the dtb updated to the newest? >> >> Possibly not, it's an automated build/boot, I'll have to check what >> it does with the dtb. >> >>> - is the qman node present? This should be easily visible in >>> /proc/device-tree/soc at ffe000000/qman at 318000. >> >> No it's not there. >> >> That's running linux-next with: >> >> CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI=n >> >> >> Does that mean I didn't update the device tree? > > I think so. Also, I just checked that the node is actually there by > compiling p5020ds.dts and then decompiling the dtb. > OK, I'll make sure I update the DTB. > > It will still be good if the code was a bit more robust about the qman being missing. Totally agree. We should handle this error condition. --- Thanks & Best Regards, Laurentiu