All of lore.kernel.org
 help / color / mirror / Atom feed
From: Z.Q. Hou <zhiqiang.hou@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2 2/2] armv8/fsl-lsch3: consolidate the clock system initialization
Date: Sat, 8 Oct 2016 06:10:29 +0000	[thread overview]
Message-ID: <VI1PR0401MB25602E82901A68925D147C5784D90@VI1PR0401MB2560.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <DB5PR0401MB19588357FFD9F30089D901B397D90@DB5PR0401MB1958.eurprd04.prod.outlook.com>

Hi Prabhakar,

> -----Original Message-----
> From: Prabhakar Kushwaha
> Sent: 2016?10?8? 11:18
> To: Z.Q. Hou <zhiqiang.hou@nxp.com>; york sun <york.sun@nxp.com>;
> u-boot at lists.denx.de; albert.u.boot at aribaud.net; Mingkai Hu
> <mingkai.hu@nxp.com>; Calvin Johnson <calvin.johnson@nxp.com>
> Subject: RE: [PATCHv2 2/2] armv8/fsl-lsch3: consolidate the clock system
> initialization
> 
> 
> > -----Original Message-----
> > From: Z.Q. Hou
> > Sent: Saturday, October 08, 2016 8:23 AM
> > To: york sun <york.sun@nxp.com>; u-boot at lists.denx.de;
> > albert.u.boot at aribaud.net; Mingkai Hu <mingkai.hu@nxp.com>; Prabhakar
> > Kushwaha <prabhakar.kushwaha@nxp.com>; Calvin Johnson
> > <calvin.johnson@nxp.com>
> > Subject: RE: [PATCHv2 2/2] armv8/fsl-lsch3: consolidate the clock
> > system initialization
> >
> > Hi York,
> >
> > Sorry for my delay response since the National Day holidays.
> >
> >
> > > -----Original Message-----
> > > From: york sun
> > > Sent: 2016?10?6? 0:20
> > > To: Z.Q. Hou <zhiqiang.hou@nxp.com>; u-boot at lists.denx.de;
> > > albert.u.boot at aribaud.net; Mingkai Hu <mingkai.hu@nxp.com>;
> > > Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Calvin Johnson
> > > <calvin.johnson@nxp.com>
> > > Subject: Re: [PATCHv2 2/2] armv8/fsl-lsch3: consolidate the clock
> > > system initialization
> > >
> > > On 09/26/2016 01:13 AM, Zhiqiang Hou wrote:
> > > > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > > >
> > > > This patch map the sys_info->freq_systembus to Platform PLL, and
> > > > implement the IPs' clock function individually.
> > > >
> > > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > > > ---
> > > > V2:
> > > >  - Generate the patch set base on the latest
> > > git://git.denx.de/u-boot-fsl-qoriq.git.
> > > >  - Add Platform clock and IPs' input clock divisors.
> > > >
> > > >  .../arm/cpu/armv8/fsl-layerscape/fsl_lsch3_speed.c | 31
> > > > ++++++++++++++++------
> > > > arch/arm/include/asm/arch-fsl-layerscape/config.h  |  8
> > > ++++++  .../include/asm/arch-fsl-layerscape/immap_lsch3.h  |  1 +
> > > >  include/configs/ls2080a_common.h                   |  2 +-
> > > >  4 files changed, 33 insertions(+), 9 deletions(-)
> > > >
> > > > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/fsl_lsch3_speed.c
> > > > b/arch/arm/cpu/armv8/fsl-layerscape/fsl_lsch3_speed.c
> > > > index a9b12a4..afc8a31 100644
> > > > --- a/arch/arm/cpu/armv8/fsl-layerscape/fsl_lsch3_speed.c
> > > > +++ b/arch/arm/cpu/armv8/fsl-layerscape/fsl_lsch3_speed.c
> > > > @@ -88,11 +88,10 @@ void get_sys_info(struct sys_info *sys_info)
> > > > #endif  #endif
> > > >
> > > > +	/* The freq_systembus is used to record frequency of platform
> > > > +PLL */
> > > >  	sys_info->freq_systembus *= (gur_in32(&gur->rcwsr[0]) >>
> > > >  			FSL_CHASSIS3_RCWSR0_SYS_PLL_RAT_SHIFT) &
> > > >  			FSL_CHASSIS3_RCWSR0_SYS_PLL_RAT_MASK;
> > > > -	/* Platform clock is half of platform PLL */
> > > > -	sys_info->freq_systembus /= 2;
> > > >  	sys_info->freq_ddrbus *= (gur_in32(&gur->rcwsr[0]) >>
> > > >  			FSL_CHASSIS3_RCWSR0_MEM_PLL_RAT_SHIFT) &
> > > >  			FSL_CHASSIS3_RCWSR0_MEM_PLL_RAT_MASK;
> > > > @@ -132,7 +131,8 @@ void get_sys_info(struct sys_info *sys_info)
> > > >  	ccr = ifc_in32(&ifc_regs.gregs->ifc_ccr);
> > > >  	ccr = ((ccr & IFC_CCR_CLK_DIV_MASK) >> IFC_CCR_CLK_DIV_SHIFT)
> +
> > > > 1;
> > > >
> > > > -	sys_info->freq_localbus = sys_info->freq_systembus / ccr;
> > > > +	sys_info->freq_localbus = sys_info->freq_systembus /
> > > > +					CONFIG_SYS_FSL_PCLK_DIV / ccr;
> > > >  #endif
> > > >  }
> > > >
> > >
> > > Zhiqiang and Prabhakar,
> > >
> > > Your patches collide with each other. Can you two work together to
> > > sort it out?
> > >
> > > http://patchwork.ozlabs.org/patch/666849/
> > >
> 
> Following are the patches
> 
> http://patchwork.ozlabs.org/patch/666844/
> http://patchwork.ozlabs.org/patch/666849/
> http://patchwork.ozlabs.org/patch/666848/
> http://patchwork.ozlabs.org/patch/677041/
> 
Nowadays, the CONFIG_* must be added to Kconfig files, when you will upgrade your patches to fix it, so I can rebase my patches against yours?

Thanks,
Zhiqiang

      reply	other threads:[~2016-10-08  6:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26  8:01 [U-Boot] [PATCHv2 1/2] armv8/fsl-lsch2: refactor the clock system initialization Zhiqiang Hou
2016-09-26  8:01 ` [U-Boot] [PATCHv2 2/2] armv8/fsl-lsch3: consolidate " Zhiqiang Hou
2016-10-05 16:20   ` york sun
2016-10-08  2:52     ` Z.Q. Hou
2016-10-08  3:18       ` Prabhakar Kushwaha
2016-10-08  6:10         ` Z.Q. Hou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0401MB25602E82901A68925D147C5784D90@VI1PR0401MB2560.eurprd04.prod.outlook.com \
    --to=zhiqiang.hou@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.