From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:DPAA2 ETHERNET SWITCH DRIVER"
<linux-kernel@vger.kernel.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>
Subject: RE: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check
Date: Mon, 25 Feb 2019 09:43:33 +0000 [thread overview]
Message-ID: <VI1PR0402MB2800B7E183F5C0A809ABE78CE07A0@VI1PR0402MB2800.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <c9bd0756-2824-a2c2-24ad-a69dc41d9ac3@gmail.com>
> Subject: Re: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check
>
> Le 2/23/19 à 12:45 AM, Ioana Ciornei a écrit :
> >
> >> Subject: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice
> >> check
> >>
> >> port_switchdev_event() does not check that the target network device
> >> is actually backed by the ethsw driver, this could be problematic in
> >> a stacked environment case.
> >>
> >
> > Just FYI, I sent a patch set containing a similar patch verifying if the netdev is
> backed by the ethsw:
> > https://lkml.org/lkml/2019/2/6/216
> >
> > I sent the entire patch set against the staging tree.
>
> Thank you. BTW do you have any plans for moving this driver out of staging? It
> looks pretty good to me to get promoted in tree, provided that you also have all
> the dependencies in place etc.
Driver dependencies such as the fsl-mc bus or the dpio driver are out of staging but not all the TODO items are yet implemented (most notably support for control traffic).
Do you think maybe we can move it now and submit directly to the netdev tree the other features?
Ioana C
prev parent reply other threads:[~2019-02-25 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 22:02 [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check Florian Fainelli
2019-02-23 8:45 ` Ioana Ciornei
2019-02-24 16:17 ` Florian Fainelli
2019-02-25 9:43 ` Ioana Ciornei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0402MB2800B7E183F5C0A809ABE78CE07A0@VI1PR0402MB2800.eurprd04.prod.outlook.com \
--to=ioana.ciornei@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.