From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-2?Q?Horia_Geant=E3?= Subject: Re: [PATCH 1/2] crypto: talitos - don't persistently map req_ctx->hw_context and req_ctx->buf Date: Fri, 2 Mar 2018 18:19:23 +0000 Message-ID: References: <7c934f0788d60bd82fb1cb51d712c9ab1ea7fcb4.1519660621.git.christophe.leroy@c-s.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Cc: "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" To: Christophe Leroy , Herbert Xu , "David S. Miller" Return-path: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On 2/26/2018 6:40 PM, Christophe Leroy wrote:=0A= > Commit 49f9783b0cea ("crypto: talitos - do hw_context DMA mapping=0A= > outside the requests") introduced a persistent dma mapping of=0A= > req_ctx->hw_context=0A= > Commit 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash= =0A= > on SEC1") introduced a persistent dma mapping of req_ctx->buf=0A= > =0A= > As there is no destructor for req_ctx (the request context), the=0A= > associated dma handlers where set in ctx (the tfm context). This is=0A= > wrong as several hash operations can run with the same ctx.=0A= > =0A= > This patch removes this persistent mapping.=0A= > =0A= > Reported-by: Horia Geanta =0A= > Fixes: 49f9783b0cea ("crypto: talitos - do hw_context DMA mapping outside= the requests")=0A= > Fixes: 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash = on SEC1")=0A= > Signed-off-by: Christophe Leroy =0A= Tested-by: Horia Geant=E3 =0A= =0A= Please add this to 4.15.y -stable tree.=0A= =0A= Thanks,=0A= Horia=0A= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0073.outbound.protection.outlook.com [104.47.1.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ztHdG66WTzF1pv for ; Sat, 3 Mar 2018 05:19:29 +1100 (AEDT) From: =?iso-8859-2?Q?Horia_Geant=E3?= To: Christophe Leroy , Herbert Xu , "David S. Miller" CC: "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [PATCH 1/2] crypto: talitos - don't persistently map req_ctx->hw_context and req_ctx->buf Date: Fri, 2 Mar 2018 18:19:23 +0000 Message-ID: References: <7c934f0788d60bd82fb1cb51d712c9ab1ea7fcb4.1519660621.git.christophe.leroy@c-s.fr> Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2/26/2018 6:40 PM, Christophe Leroy wrote:=0A= > Commit 49f9783b0cea ("crypto: talitos - do hw_context DMA mapping=0A= > outside the requests") introduced a persistent dma mapping of=0A= > req_ctx->hw_context=0A= > Commit 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash= =0A= > on SEC1") introduced a persistent dma mapping of req_ctx->buf=0A= > =0A= > As there is no destructor for req_ctx (the request context), the=0A= > associated dma handlers where set in ctx (the tfm context). This is=0A= > wrong as several hash operations can run with the same ctx.=0A= > =0A= > This patch removes this persistent mapping.=0A= > =0A= > Reported-by: Horia Geanta =0A= > Fixes: 49f9783b0cea ("crypto: talitos - do hw_context DMA mapping outside= the requests")=0A= > Fixes: 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash = on SEC1")=0A= > Signed-off-by: Christophe Leroy =0A= Tested-by: Horia Geant=E3 =0A= =0A= Please add this to 4.15.y -stable tree.=0A= =0A= Thanks,=0A= Horia=0A=