All of lore.kernel.org
 help / color / mirror / Atom feed
From: Horia Geanta <horia.geanta@nxp.com>
To: Iuliana Prodan <iuliana.prodan@nxp.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Aymen Sghaier <aymen.sghaier@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v3 10/14] crypto: caam - fix MDHA key derivation for certain user key lengths
Date: Fri, 26 Jul 2019 15:04:14 +0000	[thread overview]
Message-ID: <VI1PR0402MB34854EC43A55241885C7C87598C00@VI1PR0402MB3485.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 1564063106-9552-11-git-send-email-iuliana.prodan@nxp.com

On 7/25/2019 4:58 PM, Iuliana Prodan wrote:
> From: Horia Geantă <horia.geanta@nxp.com>
> 
> Fuzz testing uncovered an issue when |user key| > |derived key|.
> Derived key generation has to be fixed in two cases:
> 
> 1. Era >= 6 (DKP is available)
> DKP cannot be used with immediate input key if |user key| > |derived key|,
> since the resulting descriptor (after DKP execution) would be invalid -
> having a few bytes from user key left in descriptor buffer
> as incorrect opcodes.
> 
> Fix DKP usage both in standalone hmac and in authenc algorithms.
> For authenc the logic is simplified, by always storing both virtual
> and dma key addresses.
> 
> 2. Era < 6
> The same case (|user key| > |derived key|) fails when DKP
> is not available.
> Make sure gen_split_key() dma maps max(|user key|, |derived key|),
> since this is an in-place (bidirectional) operation.
> 
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
> 
> Changes since v2:
> - fix MDHA key derivation for CAAM with era < 6.
> ---
The change log shouldn't be included in the commit message.

Horia

  reply	other threads:[~2019-07-26 15:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-25 13:58 [PATCH v3 00/14] crypto: caam - fixes for kernel v5.3 Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 01/14] crypto: caam/qi - fix error handling in ERN handler Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 02/14] crypto: caam - fix return code in completion callbacks Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 03/14] crypto: caam - update IV only when crypto operation succeeds Iuliana Prodan
2019-07-26 14:57   ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 04/14] crypto: caam - check key length Iuliana Prodan
2019-07-26 15:19   ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 05/14] crypto: caam - check authsize Iuliana Prodan
2019-07-26 15:25   ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 06/14] crypto: caam - check assoclen Iuliana Prodan
2019-07-26 15:28   ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 07/14] crypto: caam - check zero-length input Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 08/14] crypto: caam - update rfc4106 sh desc to support zero length input Iuliana Prodan
2019-07-26 15:44   ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 09/14] crypto: caam - keep both virtual and dma key addresses Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 10/14] crypto: caam - fix MDHA key derivation for certain user key lengths Iuliana Prodan
2019-07-26 15:04   ` Horia Geanta [this message]
2019-07-25 13:58 ` [PATCH v3 11/14] crypto: caam - free resources in case caam_rng registration failed Iuliana Prodan
2019-07-26 15:53   ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 12/14] crypto: caam - execute module exit point only if necessary Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 13/14] crypto: caam - unregister algorithm only if the registration succeeded Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 14/14] crypto: caam - change return value in case CAAM has no MDHA Iuliana Prodan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0402MB34854EC43A55241885C7C87598C00@VI1PR0402MB3485.eurprd04.prod.outlook.com \
    --to=horia.geanta@nxp.com \
    --cc=aymen.sghaier@nxp.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=iuliana.prodan@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.