From: Andy Duan <fugang.duan@nxp.com>
To: Fabio Estevam <festevam@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [EXT] [PATCH net-next v2 2/2] net: fec_ptp: Use dev_err() instead of pr_err()
Date: Tue, 4 Jun 2019 03:51:36 +0000 [thread overview]
Message-ID: <VI1PR0402MB3600D120E0CB743F67063F52FF150@VI1PR0402MB3600.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190604030445.21994-2-festevam@gmail.com>
From: Fabio Estevam <festevam@gmail.com> Sent: Tuesday, June 4, 2019 11:05 AM
> dev_err() is more appropriate for printing error messages inside drivers, so
> switch to dev_err().
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> Changes since v1:
> - Use dev_err() instead of netdev_err() - Andy
>
> drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index 7e892b1cbd3d..19e2365be7d8 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -617,7 +617,7 @@ void fec_ptp_init(struct platform_device *pdev, int
> irq_idx)
> fep->ptp_clock = ptp_clock_register(&fep->ptp_caps, &pdev->dev);
> if (IS_ERR(fep->ptp_clock)) {
> fep->ptp_clock = NULL;
> - pr_err("ptp_clock_register failed\n");
> + dev_err(&pdev->dev, "ptp_clock_register failed\n");
> }
>
> schedule_delayed_work(&fep->time_keep, HZ);
> --
> 2.17.1
next prev parent reply other threads:[~2019-06-04 3:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 3:04 [PATCH net-next v2 1/2] net: fec_main: Use netdev_err() instead of pr_err() Fabio Estevam
2019-06-04 3:04 ` [PATCH net-next v2 2/2] net: fec_ptp: Use dev_err() " Fabio Estevam
2019-06-04 3:51 ` Andy Duan [this message]
2019-06-04 3:55 ` [EXT] [PATCH net-next v2 1/2] net: fec_main: Use netdev_err() " Andy Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0402MB3600D120E0CB743F67063F52FF150@VI1PR0402MB3600.eurprd04.prod.outlook.com \
--to=fugang.duan@nxp.com \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.