From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peng Fan <peng.fan@nxp.com>
Date: Tue, 18 Apr 2017 00:54:06 +0000
Subject: [U-Boot] [PATCH V2 12/12] imx: mx7dsabresd: add board revision
 check
In-Reply-To: <CAOMZO5CU_ESJJc6-F321Q=-HFi6T2nGakA5o4+b4+4o4kemQ6Q@mail.gmail.com>
References: <1492063800-17290-1-git-send-email-peng.fan@nxp.com>
 <1492063800-17290-12-git-send-email-peng.fan@nxp.com>
 <CAOMZO5CU_ESJJc6-F321Q=-HFi6T2nGakA5o4+b4+4o4kemQ6Q@mail.gmail.com>
Message-ID: <VI1PR04MB11669B70517F4FC47975EF4788190@VI1PR04MB1166.eurprd04.prod.outlook.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Fabio,

> -----Original Message-----
> From: Fabio Estevam [mailto:festevam at gmail.com]
> Sent: Monday, April 17, 2017 11:00 PM
> To: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>; U-Boot-Denx <u-boot@lists.denx.de>
> Subject: Re: [U-Boot] [PATCH V2 12/12] imx: mx7dsabresd: add board revision
> check
> 
> On Thu, Apr 13, 2017 at 3:10 AM, Peng Fan <peng.fan@nxp.com> wrote:
> 
> > +#define BOARD_REV_C  0x300
> > +#define BOARD_REV_B  0x200
> > +#define BOARD_REV_A  0x100
> > +
> > +static int mx7sabre_rev(void)
> > +{
> > +       /*
> > +        * Get Board ID information from OCOTP_GP1[15:8]
> > +        * i.MX7D SDB RevA: 0x41
> > +        * i.MX7D SDB RevB: 0x42
> 
> Isn't this versioning scheme shared with other NXP boards? If so, it would be
> better to put this in common code.

I prefer to keep the code here. There are board revision fuse for the boards from NXP, but
this is not always true, I think.

Thanks,
Peng.