All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huan Wang <alison.wang@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: fix m88e1111s PHY auto negotiation timeout
Date: Thu, 18 Feb 2016 09:38:18 +0000	[thread overview]
Message-ID: <VI1PR04MB1600CA5066312DACD129F793F4AF0@VI1PR04MB1600.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <56C57716.4060105@gmail.com>

> On 16.02.2016 07:54, Thomas Chou wrote:
> > After commit a058052c358c
> > ("net: phy: do not read configuration register on reset")
> >
> > both 3c120 and 10m50 devboard which use Marvel m88e1111s PHY got this
> > error message,
> >
> > Net:   eth0: ethernet at 400
> > => ping 192.168.1.5
> > ethernet at 400 Waiting for PHY auto negotiation to complete.... TIMEOUT !
> > Using ethernet at 400 device
> > host 192.168.1.5 is alive
> >
> > This is because the auto negotiation control bit was cleared by the
> > new phy_reset(). But the m88e1111s_config() does the soft-reset
> > already, there is no need to reset twice. The extra phy_reset() should
> > be removed.
> >
> > Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> > ---
> >   drivers/net/phy/marvell.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> > index eab1558..5badfac 100644
> > --- a/drivers/net/phy/marvell.c
> > +++ b/drivers/net/phy/marvell.c
> > @@ -271,8 +271,6 @@ static int m88e1111s_config(struct phy_device
> > *phydev)
> >
> >   	genphy_config_aneg(phydev);
> >
> > -	phy_reset(phydev);
> > -
> >   	return 0;
> >   }
> >
> >
> 
> I've also stumbled over this problem on some boards equipped with the
> Marvell PHY. Could you please take a look at these patches instead:
> 
> http://patchwork.ozlabs.org/patch/581316/
> http://patchwork.ozlabs.org/patch/581317/
> 
> Do they work for you?
> 
> Joe, could you please make sure to push these for this release? As its a
> real bugfix.
> 
> 
[Alison Wang] 
After commit a058052c358c
("net: phy: do not read configuration register on reset")

I find auto negotiation timeout error also occurs on Atheros's PHY AR8033 too. :(

Best Regards,
Alison Wang

  reply	other threads:[~2016-02-18  9:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-16  6:54 [U-Boot] [PATCH] net: fix m88e1111s PHY auto negotiation timeout Thomas Chou
2016-02-18  7:47 ` Stefan Roese
2016-02-18  9:38   ` Huan Wang [this message]
2016-02-25  1:33   ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB1600CA5066312DACD129F793F4AF0@VI1PR04MB1600.eurprd04.prod.outlook.com \
    --to=alison.wang@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.