From: Andy Tang <andy.tang@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Leo Li <leoyang.li@nxp.com>
Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix a compatible issue
Date: Tue, 24 Sep 2019 08:00:29 +0000 [thread overview]
Message-ID: <VI1PR04MB4333F1CF5DF521678575D61EF3840@VI1PR04MB4333.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190914024231.GB3425@dragon>
Hi Shawn,
> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: 2019年9月14日 10:43
> To: Andy Tang <andy.tang@nxp.com>
> Cc: Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org;
> mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org
> Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix a compatible issue
>
> Caution: EXT Email
>
> On Thu, Aug 29, 2019 at 03:34:39PM +0800, Yuantian Tang wrote:
> > The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847.
> > So correct it.
>
> Can elaborate the fix a little bit, saying what's the issue exactly with using
> that incorrect compatible?
Ok.
>
> >
> > Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
>
> Do we need a fix tag?
What does "fix tag" mean?
BR,
Andy
>
> Shawn
>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > index 5e14e5a19744..f5da9e8b0d9d 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > @@ -107,7 +107,7 @@
> > status = "okay";
> >
> > i2c-mux@77 {
> > - compatible = "nxp,pca9847";
> > + compatible = "nxp,pca9547";
> > reg = <0x77>;
> > #address-cells = <1>;
> > #size-cells = <0>;
> > --
> > 2.17.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-24 8:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 7:34 [PATCH] arm64: dts: ls1028a: fix a compatible issue Yuantian Tang
2019-08-29 7:34 ` Yuantian Tang
2019-09-14 2:42 ` Shawn Guo
2019-09-14 2:42 ` Shawn Guo
2019-09-24 8:00 ` Andy Tang [this message]
2019-10-03 8:44 ` [EXT] " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB4333F1CF5DF521678575D61EF3840@VI1PR04MB4333.eurprd04.prod.outlook.com \
--to=andy.tang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.