[U-Boot] [EXT] Re: [PATCH 1/4] ata: fsl_ahci: Add sata DM support for Freescale powerpc socs

From: Peng Ma <peng.ma@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [EXT] Re: [PATCH 1/4] ata: fsl_ahci: Add sata DM support for Freescale powerpc socs
Date: Wed, 15 May 2019 10:19:46 +0000	[thread overview]
Message-ID: <VI1PR04MB4431165FCE15C7E77B86D2CAED090@VI1PR04MB4431.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <ac3b8383-be17-4788-a30d-322728ed2f62@denx.de>


>-----Original Message-----
>From: Stefan Roese <sr@denx.de>
>Sent: 2019年5月15日 17:23
>To: Peng Ma <peng.ma@nxp.com>; Prabhakar Kushwaha
><prabhakar.kushwaha@nxp.com>; Shengzhou Liu <shengzhou.liu@nxp.com>;
>Ruchika Gupta <ruchika.gupta@nxp.com>
>Cc: Yinbo Zhu <yinbo.zhu@nxp.com>; sjg at chromium.org; Jagdish Gediya
><jagdish.gediya@nxp.com>; York Sun <york.sun@nxp.com>;
>bmeng.cn at gmail.com; make at marvell.com; Andy Tang <andy.tang@nxp.com>;
>u-boot at lists.denx.de
>Subject: [EXT] Re: [PATCH 1/4] ata: fsl_ahci: Add sata DM support for Freescale
>powerpc socs
>
>Caution: EXT Email
>
>On 15.05.19 11:04, Peng Ma wrote:
>>
>>
>>> -----Original Message-----
>>> From: Stefan Roese <sr@denx.de>
>>> Sent: 2019年3月27日 18:48
>>> To: Peng Ma <peng.ma@nxp.com>; Prabhakar Kushwaha
>>> <prabhakar.kushwaha@nxp.com>; Shengzhou Liu
><shengzhou.liu@nxp.com>;
>>> Ruchika Gupta <ruchika.gupta@nxp.com>
>>> Cc: Yinbo Zhu <yinbo.zhu@nxp.com>; sjg at chromium.org; Jagdish Gediya
>>> <jagdish.gediya@nxp.com>; York Sun <york.sun@nxp.com>;
>>> bmeng.cn at gmail.com; make at marvell.com; Andy Tang
><andy.tang@nxp.com>;
>>> u-boot at lists.denx.de
>>> Subject: Re: [PATCH 1/4] ata: fsl_ahci: Add sata DM support for
>>> Freescale powerpc socs
>>>
>>> On 27.03.19 11:41, Peng Ma wrote:
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Stefan Roese <sr@denx.de>
>>>>> Sent: 2019年3月27日 18:01
>>>>> To: Peng Ma <peng.ma@nxp.com>; Prabhakar Kushwaha
>>>>> <prabhakar.kushwaha@nxp.com>; Shengzhou Liu
>>> <shengzhou.liu@nxp.com>;
>>>>> Ruchika Gupta <ruchika.gupta@nxp.com>
>>>>> Cc: Yinbo Zhu <yinbo.zhu@nxp.com>; sjg at chromium.org; Jagdish Gediya
>>>>> <jagdish.gediya@nxp.com>; York Sun <york.sun@nxp.com>;
>>>>> bmeng.cn at gmail.com; make at marvell.com; Andy Tang
>>> <andy.tang@nxp.com>;
>>>>> u-boot at lists.denx.de
>>>>> Subject: Re: [PATCH 1/4] ata: fsl_ahci: Add sata DM support for
>>>>> Freescale powerpc socs
>>>>>
>>>>> On 27.03.19 10:23, Peng Ma wrote:
>>>>>> This patch is to support Freescale sata driver with dts initialized.
>>>>>> Also resolved the following problems.
>>>>>>
>>>>>> ===================== WARNING ====================== This
>>> board
>>>>> does
>>>>>> not use CONFIG_DM_SCSI. Please update the storage controller to
>>>>>> use CONFIG_DM_SCSI before the v2019.07 release.
>>>>>> Failure to update by the deadline may result in board removal.
>>>>>> See doc/driver-model/MIGRATION.txt for more info.
>>>>>> ====================================================
>>>>>>
>>>>>> Signed-off-by: Peng Ma <peng.ma@nxp.com>
>>>>>> ---
>>>>>> depends on:
>>>>>>   -
>>>>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
>>>>> at
>>>>> chw
>>>>>
>>>
>ork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D99168&amp;data
>>>>>
>>>
>=02%7C01%7Cpeng.ma%40nxp.com%7C71e43bd30bf24799586f08d6b29b1ef
>>>>>
>>>
>3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636892776652072
>>>>>
>>>
>966&amp;sdata=3Z33Z5raG%2BnbtSUpz2kPCGpefk1byOgy0%2Br3R4DUFU8%
>>>>> 3D&amp;reserved=0
>>>>>>   -
>>>>>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
>>>>>> pa
>>>>>> tc
>>>>>>
>>>>>
>>>
>hwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D99167&amp;d
>>>>> ata
>>>>>>
>>>>>
>>>
>=02%7C01%7Cpeng.ma%40nxp.com%7C71e43bd30bf24799586f08d6b29b1ef
>>>>> 3%7C686e
>>>>>>
>>>>>
>>>
>a1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636892776652072966&amp;
>>>>> sdata=sr
>>>>>> %2BCh4UioJw0kuhOiLhc3F6keRhIH8Wflt%2BvMJnHtsY%3D&amp;reser
>ve
>>> d=
>>>>> 0
>>>>>>
>>>>>>     drivers/ata/Kconfig    |   10 +
>>>>>>     drivers/ata/Makefile   |    1 +
>>>>>>     drivers/ata/fsl_ahci.c | 1030
>>>>> ++++++++++++++++++++++++++++++++++++++++
>>>>>>     drivers/ata/fsl_sata.h |    1 +
>>>>>>     4 files changed, 1042 insertions(+)
>>>>>>     create mode 100644 drivers/ata/fsl_ahci.c
>>>>>
>>>>> Will this patch series replace the old fsl_sata.c driver? If yes,
>>>>> could you remove this driver as well in this series?
>>>> [Peng Ma]
>>>> Hi Stefan,
>>>>
>>>> fsl_sata.c used to Non DM sata driver for some powerpc socs.
>>>> Currently We only have one board that supports dts initialization. I
>>>> will remove this old driver When all of our powerpc socs support DM.
>>>
>>> I see, thanks. I just wanted to know, if this new SATA driver is a
>>> meant as a replacement for the old non-DM driver.
>> [Peng Ma]
>> Hi Stefan,
>>
>> I am so sorry to reply late, Other Non dts powerpc board need the old
>> sata driver, so the new Sata driver does not replace the so far.
>
>Just curious: Which are the "other non dts powerpc boards"? Are there still
>many? Is there a plan to move them to DT as well? Or should they perhaps be
>dropped from mainline if not converted to DT? What's stopping the conversion
>here?
[Peng Ma]
1: There is some platforms still with non dts such as: T1024QDS, T1024RDB, T1040D4RDB etc.
2: I do not know the plan to move them to DT,  we only support one platform named T2080QDS so far.
3:Before all of them support DT, we should not delete old sata driver.

Thanks. 
Best Regards,
Peng		
>
>Thanks,
>Stefan