All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Ayuj Verma <ayverma@marvell.com>,
	"Trahe, Fiona" <fiona.trahe@intel.com>,
	 "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
Cc: Shally Verma <shallyv@marvell.com>,
	Sunila Sahu <ssahu@marvell.com>,
	Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>,
	Arvind Desai <adesai@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers
Date: Wed, 17 Apr 2019 09:57:31 +0000	[thread overview]
Message-ID: <VI1PR04MB48930122B197D0ED984F1209E6250@VI1PR04MB4893.eurprd04.prod.outlook.com> (raw)


Hi Ayuj,

> -----Original Message-----
> From: Ayuj Verma [mailto:ayverma@marvell.com]
> Sent: Friday, April 12, 2019 8:03 AM
> To: akhil.goyal@nxp.com<mailto:akhil.goyal@nxp.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com<mailto:arkadiuszx.kusztal@intel.com>>; Trahe, Fiona
> <fiona.trahe@intel.com<mailto:fiona.trahe@intel.com>>
> Cc: shallyv@marvell.com<mailto:shallyv@marvell.com>; ssahu@marvell.com<mailto:ssahu@marvell.com>; kkotamarthy@marvell.com<mailto:kkotamarthy@marvell.com>; adesai@marvell.com<mailto:adesai@marvell.com>;
> dev@dpdk.org<mailto:dev@dpdk.org>; Ayuj Verma <ayverma@marvell.com<mailto:ayverma@marvell.com>>
> Subject: [PATCH v1] fix alphabetical ordering of headers
>
> rte_crypto_sym.h is included prior to rte_crypto_asym.h
> in rte_crypto.h, which breaks alphabetical order.
>
> include rte_crypto_sym.h in rte_crypto_asym.h fixes this.
[Fiona] I presume you tried just swapping the order and it broke?
If something in rte_crypto_asym.h depends on something from rte_crypto_sym.h, it
probably shouldn't. What's the dependency and can/should it be moved to rte_crypto.h?
[Ayuj] it is enum rte_crypto_auth_algorithm which it import from sym.h. So do you suggest to move it to rte_crypto.h?

[Akhil] moving the enum is not a good idea. I believe we do not need this change at all. Keeping the headers in alphabetical order may be a preferred way,
But it should not be mandatory, there may be some dependencies like this.

             reply	other threads:[~2019-04-17  9:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17  9:57 Akhil Goyal [this message]
2019-04-17 11:24 ` [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers Trahe, Fiona
  -- strict thread matches above, loose matches on Subject: below --
2019-04-16  7:40 Akhil Goyal
2019-04-12  7:03 Ayuj Verma
2019-04-12 15:17 ` Trahe, Fiona
2019-04-16 16:15   ` Ayuj Verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB48930122B197D0ED984F1209E6250@VI1PR04MB4893.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=adesai@marvell.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=ayverma@marvell.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=kkotamarthy@marvell.com \
    --cc=shallyv@marvell.com \
    --cc=ssahu@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.