Re: [LTP] [PATCH v1] mem/swapping01: Make sure swap is supported by kernel

From: Bogdan Lezhepekov via ltp <ltp@lists.linux.it>
To: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>,
	Li Wang <liwang@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v1] mem/swapping01: Make sure swap is supported by kernel
Date: Fri, 11 Feb 2022 07:35:54 +0000	[thread overview]
Message-ID: <VI1PR04MB49587421680CE7C6AA8599CD93309@VI1PR04MB4958.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <6205BA38.7070903@fujitsu.com>

[-- Attachment #1.1: Type: text/plain, Size: 1237 bytes --]

Hi all,

I didn't go for CONFIG_SWAP just because wanted to be aligned with syscalls/swapon/swapon03.c and to not multiply patterns.

If you see CONFIG_SWAP more beneficial for docparser, I can make another patch.

Should I?

Cheers,
Bogdan
________________________________
From: ltp <ltp-bounces+bogdan.lezhepekov=suse.com@lists.linux.it> on behalf of xuyang2018.jy@fujitsu.com <xuyang2018.jy@fujitsu.com>
Sent: Friday, February 11, 2022 3:21
To: Li Wang <liwang@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v1] mem/swapping01: Make sure swap is supported by kernel

Hi Li
>
>
> On Fri, Feb 11, 2022 at 12:09 AM Cyril Hrubis <chrubis@suse.cz
> <mailto:chrubis@suse.cz>> wrote:
>
>     Hi!
>     Applied, thanks.
>
>     I guess that the SAFE_OPEN() caused TBROK on machines without
>     CONFIG_SWAP, right?
>
>
> If so, why not go fix with .needs_config for "CONFIG_SWAP=y" ?
+1, it is also friendly to docparse.

ps: I never listen user complaint for the lack of CONFIG_PORC, so only
using .needs_config for "CONFIG_SWAP=y" can work well.

Best Regards
Yang Xu
>
> --
> Regards,
> Li Wang
>
>
>
>

--
Mailing list info: https://lists.linux.it/listinfo/ltp

[-- Attachment #1.2: Type: text/html, Size: 3316 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp