From mboxrd@z Thu Jan  1 00:00:00 1970
From: Poonam Aggrwal <poonam.aggrwal@nxp.com>
Date: Mon, 22 Oct 2018 03:43:52 +0000
Subject: [U-Boot] [PATCH 1/2] powerpc: t1040: Correct RCW MAC2_GMII_SEL
	value
In-Reply-To: <CAEUhbmVv9N=-EyshTSxLj+d2wGPzJcyV06+3bNq9Z8hmfDcSBw@mail.gmail.com>
References: <1539006957-3461-1-git-send-email-bmeng.cn@gmail.com>
 <DB7PR04MB42986C43B73C70D29A2EFC489AE60@DB7PR04MB4298.eurprd04.prod.outlook.com>
 <CAEUhbmUKfZv84RMFm21GfMXj_wy5f0DmMZh9pFYTjwe5gWbCPQ@mail.gmail.com>
 <CAEUhbmVv9N=-EyshTSxLj+d2wGPzJcyV06+3bNq9Z8hmfDcSBw@mail.gmail.com>
Message-ID: <VI1PR04MB49765B6C737265A71FE2842C86F40@VI1PR04MB4976.eurprd04.prod.outlook.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



> -----Original Message-----
> From: Bin Meng [mailto:bmeng.cn at gmail.com]
> Sent: Monday, October 22, 2018 7:41 AM
> To: York Sun <york.sun@nxp.com>
> Cc: Poonam Aggrwal <poonam.aggrwal@nxp.com>; U-Boot Mailing List <u-
> boot at lists.denx.de>
> Subject: Re: [PATCH 1/2] powerpc: t1040: Correct RCW MAC2_GMII_SEL value
> 
> On Mon, Oct 15, 2018 at 1:21 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > On Mon, Oct 8, 2018 at 11:07 PM York Sun <york.sun@nxp.com> wrote:
> > >
> > > On 10/08/2018 06:51 AM, Bin Meng wrote:
> > > > Per T1040RM (Rev. 1, 08/2015), the value of
> > > > FSL_CORENET_RCWSR13_MAC2_GMII_SEL_ENET_PORT is wrong and
> should be
> > > > 0x00000080 (bit 440 in the RCW).
> > > >
> > > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > > > ---
> > >
> > >
> > > Poonam,
> > >
> > > Please review and confirm on T1040. Thanks.
> > >
> >
> > Ping ?
> 
> Ping ?
Apologies Bin, York for such late response....
The patch looks correct, the value of FSL_CORENET_RCWSR13_MAC2_GMII_SEL_ENET_PORT should be 0x80 indeed,
I would suggest that I test it once that DTSEC2 RGMII works with this change, because I see more changes which could be required in drivers/fm/t1040.c...seems a goof up there as well.

Kind Regards
Poonam