From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D490C282DF for ; Fri, 19 Apr 2019 18:16:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 241BF222E9 for ; Fri, 19 Apr 2019 18:16:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="sb2muPTk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727005AbfDSSQk (ORCPT ); Fri, 19 Apr 2019 14:16:40 -0400 Received: from mail-eopbgr150089.outbound.protection.outlook.com ([40.107.15.89]:52369 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726762AbfDSSQj (ORCPT ); Fri, 19 Apr 2019 14:16:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bdOMdNJmJGOVzzRDliZ13hYceqbBlu9X588oBQ/37Es=; b=sb2muPTk29AUFBD27Emi7Ons964JYJObjoEZ1DvRmbWMLjf7MV4IwcUIFGurqc6aW4Oe3YZfSuUHyHZ2w/WwvI2mx0r8E9zMVyhgVe2bqXnNMkhq8H8NM+9TKYr3hXz67muslkr6Ge+beLdpTieQvQDyHu/BLIdLVANcOqwRogI= Received: from VI1PR04MB5134.eurprd04.prod.outlook.com (20.177.50.159) by VI1PR04MB5919.eurprd04.prod.outlook.com (20.178.205.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Fri, 19 Apr 2019 13:41:39 +0000 Received: from VI1PR04MB5134.eurprd04.prod.outlook.com ([fe80::5c9b:12cc:80f2:1f42]) by VI1PR04MB5134.eurprd04.prod.outlook.com ([fe80::5c9b:12cc:80f2:1f42%3]) with mapi id 15.20.1813.013; Fri, 19 Apr 2019 13:41:39 +0000 From: Laurentiu Tudor To: Robin Murphy , "netdev@vger.kernel.org" , Madalin-cristian Bucur , Roy Pledge , Camelia Alexandra Groza , Leo Li CC: "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "linuxppc-dev@lists.ozlabs.org" , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH 02/13] soc/fsl/bman: map FBPR area in the iommu Thread-Topic: [PATCH 02/13] soc/fsl/bman: map FBPR area in the iommu Thread-Index: AQHU5je+GYAdWERgxkCiU6HsMs84n6YisRcAgCDsguA= Date: Fri, 19 Apr 2019 13:41:38 +0000 Message-ID: References: <20190329140014.8126-1-laurentiu.tudor@nxp.com> <20190329140014.8126-3-laurentiu.tudor@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=laurentiu.tudor@nxp.com; x-originating-ip: [213.233.110.112] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f1080e5-4da5-4fa6-733c-08d6c4ccbfd8 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:VI1PR04MB5919; x-ms-traffictypediagnostic: VI1PR04MB5919: x-microsoft-antispam-prvs: x-forefront-prvs: 0012E6D357 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(346002)(136003)(39860400002)(366004)(396003)(199004)(13464003)(189003)(55016002)(73956011)(66946007)(6246003)(52536014)(99286004)(66066001)(478600001)(2906002)(9686003)(97736004)(68736007)(44832011)(76176011)(86362001)(64756008)(76116006)(66446008)(53936002)(316002)(7696005)(54906003)(6116002)(110136005)(14454004)(6636002)(256004)(229853002)(476003)(6436002)(186003)(11346002)(74316002)(81156014)(4326008)(7736002)(305945005)(25786009)(26005)(71190400001)(33656002)(71200400001)(53546011)(486006)(6506007)(81166006)(8676002)(3846002)(102836004)(446003)(8936002)(66476007)(2501003)(5660300002)(66556008);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5919;H:VI1PR04MB5134.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BeFY///qE+RmwKpRlRJcQbMDG6Ojm0ES1+M6FnlZDN7AFfwPqkRA68Yel4C5A2BZA38ZKAEfl1itecVa5l+X+os/AuRHbPYLy4ZGAxoUwRyCftMZOOmFpLLFo7yBfLSkHiI8puUkfAts9wEV92UfWF1RxW5MaBabJ5yZv/j9rI7GYMAn5aizHP+ZQTGA6ZKkstQwz8J6iXMVkT2Harme/xs49FxgfnffoYxNnsAmTL5Wc0WJahLAz7Y8rXrIoO6tNp7XOXRSwgoMRh+RX5jO57Q+5wbT31pp0pI1r5Rs91rZ4K0v2PlLJ3HN5rRT9XwITBffXN6+aZrZRbXS3TA5OFFuqf+mdvUv/kgn5bnLfi0dmt09sEwrT00SW+39HTDnRJbfJ+wSEv4TdLIinJMAhtrEpzA9DQxlzKbWvKjsPxk= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f1080e5-4da5-4fa6-733c-08d6c4ccbfd8 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2019 13:41:38.8808 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5919 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGkgUm9iaW4sDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUm9iaW4g TXVycGh5IDxyb2Jpbi5tdXJwaHlAYXJtLmNvbT4NCj4gU2VudDogRnJpZGF5LCBNYXJjaCAyOSwg MjAxOSA0OjUxIFBNDQo+IA0KPiBPbiAyOS8wMy8yMDE5IDE0OjAwLCBsYXVyZW50aXUudHVkb3JA bnhwLmNvbSB3cm90ZToNCj4gPiBGcm9tOiBMYXVyZW50aXUgVHVkb3IgPGxhdXJlbnRpdS50dWRv ckBueHAuY29tPg0KPiA+DQo+ID4gQWRkIGEgb25lLXRvLW9uZSBpb21tdSBtYXBwaW5nIGZvciBi bWFuIHByaXZhdGUgZGF0YSBtZW1vcnkgKEZCUFIpLg0KPiA+IFRoaXMgaXMgcmVxdWlyZWQgZm9y IEJNQU4gdG8gd29yayB3aXRob3V0IGZhdWx0cyBiZWhpbmQgYW4gaW9tbXUuDQo+ID4NCj4gPiBT aWduZWQtb2ZmLWJ5OiBMYXVyZW50aXUgVHVkb3IgPGxhdXJlbnRpdS50dWRvckBueHAuY29tPg0K PiA+IC0tLQ0KPiA+ICAgZHJpdmVycy9zb2MvZnNsL3FibWFuL2JtYW5fY2Nzci5jIHwgMTEgKysr KysrKysrKysNCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspDQo+ID4NCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zb2MvZnNsL3FibWFuL2JtYW5fY2Nzci5jDQo+IGIvZHJp dmVycy9zb2MvZnNsL3FibWFuL2JtYW5fY2Nzci5jDQo+ID4gaW5kZXggN2MzY2M5NjgwNTNjLi5i MjA5Yzc5NTExYmIgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9zb2MvZnNsL3FibWFuL2JtYW5f Y2Nzci5jDQo+ID4gKysrIGIvZHJpdmVycy9zb2MvZnNsL3FibWFuL2JtYW5fY2Nzci5jDQo+ID4g QEAgLTI5LDYgKzI5LDcgQEANCj4gPiAgICAqLw0KPiA+DQo+ID4gICAjaW5jbHVkZSAiYm1hbl9w cml2LmgiDQo+ID4gKyNpbmNsdWRlIDxsaW51eC9pb21tdS5oPg0KPiA+DQo+ID4gICB1MTYgYm1h bl9pcF9yZXY7DQo+ID4gICBFWFBPUlRfU1lNQk9MKGJtYW5faXBfcmV2KTsNCj4gPiBAQCAtMTc4 LDYgKzE3OSw3IEBAIHN0YXRpYyBpbnQgZnNsX2JtYW5fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rl dmljZQ0KPiAqcGRldikNCj4gPiAgIAlpbnQgcmV0LCBlcnJfaXJxOw0KPiA+ICAgCXN0cnVjdCBk ZXZpY2UgKmRldiA9ICZwZGV2LT5kZXY7DQo+ID4gICAJc3RydWN0IGRldmljZV9ub2RlICpub2Rl ID0gZGV2LT5vZl9ub2RlOw0KPiA+ICsJc3RydWN0IGlvbW11X2RvbWFpbiAqZG9tYWluOw0KPiA+ ICAgCXN0cnVjdCByZXNvdXJjZSAqcmVzOw0KPiA+ICAgCXUxNiBpZCwgYm1fcG9vbF9jbnQ7DQo+ ID4gICAJdTggbWFqb3IsIG1pbm9yOw0KPiA+IEBAIC0yMjUsNiArMjI3LDE1IEBAIHN0YXRpYyBp bnQgZnNsX2JtYW5fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZQ0KPiAqcGRldikNCj4gPg0K PiA+ICAgCWRldl9kYmcoZGV2LCAiQWxsb2NhdGVkIEZCUFIgMHglbGx4IDB4JXp4XG4iLCBmYnBy X2EsIGZicHJfc3opOw0KPiA+DQo+ID4gKwkvKiBDcmVhdGUgYW4gMS10by0xIGlvbW11IG1hcHBp bmcgZm9yIEZCUFIgYXJlYSAqLw0KPiA+ICsJZG9tYWluID0gaW9tbXVfZ2V0X2RvbWFpbl9mb3Jf ZGV2KGRldik7DQo+IA0KPiBJZiB0aGF0J3MgZXhwZWN0ZWQgdG8gYmUgdGhlIGRlZmF1bHQgZG9t YWluIHRoYXQgeW91J3JlIGdyYWJiaW5nLCB0aGVuDQo+IHRoaXMgaXMgKmluY3JlZGlibHkqIGZy YWdpbGUuIFRoZXJlJ3Mgbm90aGluZyB0byBzdG9wIHRoZSBJT1ZBIHRoYXQgeW91DQo+IGZvcmNp Ymx5IG1hcCBmcm9tIGJlaW5nIGF1dG9tYXRpY2FsbHkgYWxsb2NhdGVkIGxhdGVyIGFuZCBjYXVz aW5nIHNvbWUNCj4gb3RoZXIgRE1BIG1hcHBpbmcgdG8gZmFpbCBub2lzaWx5IGFuZCB1bmV4cGVj dGVkbHkuIEZ1cnRoZXJtb3JlLCBoYXZlDQo+IHlvdSB0cmllZCB0aGlzIHdpdGggImlvbW11LnBh c3N0aHJvdWdoPTEiPw0KPiANCj4gVGhhdCBzYWlkLCBJIHJlYWxseSBkb24ndCB1bmRlcnN0YW5k IHdoYXQncyBnb2luZyBvbiBoZXJlIGFueXdheSA6Lw0KPiANCj4gQXMgZmFyIGFzIEkgY2FuIHRl bGwgZnJvbSBxYm1hbl9pbml0X3ByaXZhdGVfbWVtKCksIGZicHJfYSBjb21lcyBmcm9tDQo+IGRt YV9hbGxvY19jb2hlcmVudCgpIGFuZCB0aHVzIHdvdWxkIGFscmVhZHkgYmUgYSBtYXBwZWQgSU9W QSAtIGlzbid0DQo+IHRoaXMgdGhlIHN0dWZmIHRoYXQgUm95IGNvbnZlcnRlZCB0byBuaWNlbHkg dXNlIHNoYXJlZC1kbWEtcG9vbCByZWdpb25zDQo+IGEgd2hpbGUgYWdvPw0KPiANCg0KRmluYWxs eSBmb3VuZCBzb21lIHRpbWUgdG8gbG9vayBpbnRvIHRoaXMsIHNvcnJ5IGZvciB0aGUgZGVsYXku IEl0IHNlZW1zIHRoYXQgb24gdGhlIGNvZGUgcGF0aCB0YWtlbiBpbiBvdXIgY2FzZSAoZG1hX2Fs bG9jX2NvaGVyZW50KCkgLT4gZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Zyb21fZGV2 X2NvaGVyZW50KCkgLT4gX19kbWFfYWxsb2NfZnJvbV9jb2hlcmVudCgpKSB0aGVyZSdzIG5vIGNh bGwgaW50byB0aGUgaW9tbXUgbGF5ZXIsIHRodXMgbm8gbWFwcGluZyBpbiB0aGUgc21tdS4gSSBw bGFuIHRvIGNvbWUgdXAgd2l0aCBhIFJGQyBwYXRjaCBlYXJseSBuZXh0IHdlZWsgc28gd2UgaGF2 ZSBzb21ldGhpbmcgY29uY3JldGUgdG8gZGlzY3VzcyBvbi4NCg0KLS0tDQpCZXN0IFJlZ2FyZHMs IExhdXJlbnRpdQ0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA4A7C282DA for ; Fri, 19 Apr 2019 13:44:07 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F1B3222A2 for ; Fri, 19 Apr 2019 13:44:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="sb2muPTk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F1B3222A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44lxys0CSfzDqQk for ; Fri, 19 Apr 2019 23:44:05 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nxp.com (client-ip=40.107.6.81; helo=eur04-db3-obe.outbound.protection.outlook.com; envelope-from=laurentiu.tudor@nxp.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="sb2muPTk"; dkim-atps=neutral Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60081.outbound.protection.outlook.com [40.107.6.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44lxwD3t6JzDqBL for ; Fri, 19 Apr 2019 23:41:45 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bdOMdNJmJGOVzzRDliZ13hYceqbBlu9X588oBQ/37Es=; b=sb2muPTk29AUFBD27Emi7Ons964JYJObjoEZ1DvRmbWMLjf7MV4IwcUIFGurqc6aW4Oe3YZfSuUHyHZ2w/WwvI2mx0r8E9zMVyhgVe2bqXnNMkhq8H8NM+9TKYr3hXz67muslkr6Ge+beLdpTieQvQDyHu/BLIdLVANcOqwRogI= Received: from VI1PR04MB5134.eurprd04.prod.outlook.com (20.177.50.159) by VI1PR04MB5919.eurprd04.prod.outlook.com (20.178.205.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Fri, 19 Apr 2019 13:41:39 +0000 Received: from VI1PR04MB5134.eurprd04.prod.outlook.com ([fe80::5c9b:12cc:80f2:1f42]) by VI1PR04MB5134.eurprd04.prod.outlook.com ([fe80::5c9b:12cc:80f2:1f42%3]) with mapi id 15.20.1813.013; Fri, 19 Apr 2019 13:41:39 +0000 From: Laurentiu Tudor To: Robin Murphy , "netdev@vger.kernel.org" , Madalin-cristian Bucur , Roy Pledge , Camelia Alexandra Groza , Leo Li Subject: RE: [PATCH 02/13] soc/fsl/bman: map FBPR area in the iommu Thread-Topic: [PATCH 02/13] soc/fsl/bman: map FBPR area in the iommu Thread-Index: AQHU5je+GYAdWERgxkCiU6HsMs84n6YisRcAgCDsguA= Date: Fri, 19 Apr 2019 13:41:38 +0000 Message-ID: References: <20190329140014.8126-1-laurentiu.tudor@nxp.com> <20190329140014.8126-3-laurentiu.tudor@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=laurentiu.tudor@nxp.com; x-originating-ip: [213.233.110.112] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f1080e5-4da5-4fa6-733c-08d6c4ccbfd8 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB5919; x-ms-traffictypediagnostic: VI1PR04MB5919: x-microsoft-antispam-prvs: x-forefront-prvs: 0012E6D357 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(39860400002)(366004)(396003)(199004)(13464003)(189003)(55016002)(73956011)(66946007)(6246003)(52536014)(99286004)(66066001)(478600001)(2906002)(9686003)(97736004)(68736007)(44832011)(76176011)(86362001)(64756008)(76116006)(66446008)(53936002)(316002)(7696005)(54906003)(6116002)(110136005)(14454004)(6636002)(256004)(229853002)(476003)(6436002)(186003)(11346002)(74316002)(81156014)(4326008)(7736002)(305945005)(25786009)(26005)(71190400001)(33656002)(71200400001)(53546011)(486006)(6506007)(81166006)(8676002)(3846002)(102836004)(446003)(8936002)(66476007)(2501003)(5660300002)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5919; H:VI1PR04MB5134.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BeFY///qE+RmwKpRlRJcQbMDG6Ojm0ES1+M6FnlZDN7AFfwPqkRA68Yel4C5A2BZA38ZKAEfl1itecVa5l+X+os/AuRHbPYLy4ZGAxoUwRyCftMZOOmFpLLFo7yBfLSkHiI8puUkfAts9wEV92UfWF1RxW5MaBabJ5yZv/j9rI7GYMAn5aizHP+ZQTGA6ZKkstQwz8J6iXMVkT2Harme/xs49FxgfnffoYxNnsAmTL5Wc0WJahLAz7Y8rXrIoO6tNp7XOXRSwgoMRh+RX5jO57Q+5wbT31pp0pI1r5Rs91rZ4K0v2PlLJ3HN5rRT9XwITBffXN6+aZrZRbXS3TA5OFFuqf+mdvUv/kgn5bnLfi0dmt09sEwrT00SW+39HTDnRJbfJ+wSEv4TdLIinJMAhtrEpzA9DQxlzKbWvKjsPxk= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f1080e5-4da5-4fa6-733c-08d6c4ccbfd8 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2019 13:41:38.8808 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5919 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "iommu@lists.linux-foundation.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "davem@davemloft.net" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" SGkgUm9iaW4sDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUm9iaW4g TXVycGh5IDxyb2Jpbi5tdXJwaHlAYXJtLmNvbT4NCj4gU2VudDogRnJpZGF5LCBNYXJjaCAyOSwg MjAxOSA0OjUxIFBNDQo+IA0KPiBPbiAyOS8wMy8yMDE5IDE0OjAwLCBsYXVyZW50aXUudHVkb3JA bnhwLmNvbSB3cm90ZToNCj4gPiBGcm9tOiBMYXVyZW50aXUgVHVkb3IgPGxhdXJlbnRpdS50dWRv ckBueHAuY29tPg0KPiA+DQo+ID4gQWRkIGEgb25lLXRvLW9uZSBpb21tdSBtYXBwaW5nIGZvciBi bWFuIHByaXZhdGUgZGF0YSBtZW1vcnkgKEZCUFIpLg0KPiA+IFRoaXMgaXMgcmVxdWlyZWQgZm9y IEJNQU4gdG8gd29yayB3aXRob3V0IGZhdWx0cyBiZWhpbmQgYW4gaW9tbXUuDQo+ID4NCj4gPiBT aWduZWQtb2ZmLWJ5OiBMYXVyZW50aXUgVHVkb3IgPGxhdXJlbnRpdS50dWRvckBueHAuY29tPg0K PiA+IC0tLQ0KPiA+ICAgZHJpdmVycy9zb2MvZnNsL3FibWFuL2JtYW5fY2Nzci5jIHwgMTEgKysr KysrKysrKysNCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspDQo+ID4NCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zb2MvZnNsL3FibWFuL2JtYW5fY2Nzci5jDQo+IGIvZHJp dmVycy9zb2MvZnNsL3FibWFuL2JtYW5fY2Nzci5jDQo+ID4gaW5kZXggN2MzY2M5NjgwNTNjLi5i MjA5Yzc5NTExYmIgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9zb2MvZnNsL3FibWFuL2JtYW5f Y2Nzci5jDQo+ID4gKysrIGIvZHJpdmVycy9zb2MvZnNsL3FibWFuL2JtYW5fY2Nzci5jDQo+ID4g QEAgLTI5LDYgKzI5LDcgQEANCj4gPiAgICAqLw0KPiA+DQo+ID4gICAjaW5jbHVkZSAiYm1hbl9w cml2LmgiDQo+ID4gKyNpbmNsdWRlIDxsaW51eC9pb21tdS5oPg0KPiA+DQo+ID4gICB1MTYgYm1h bl9pcF9yZXY7DQo+ID4gICBFWFBPUlRfU1lNQk9MKGJtYW5faXBfcmV2KTsNCj4gPiBAQCAtMTc4 LDYgKzE3OSw3IEBAIHN0YXRpYyBpbnQgZnNsX2JtYW5fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rl dmljZQ0KPiAqcGRldikNCj4gPiAgIAlpbnQgcmV0LCBlcnJfaXJxOw0KPiA+ICAgCXN0cnVjdCBk ZXZpY2UgKmRldiA9ICZwZGV2LT5kZXY7DQo+ID4gICAJc3RydWN0IGRldmljZV9ub2RlICpub2Rl ID0gZGV2LT5vZl9ub2RlOw0KPiA+ICsJc3RydWN0IGlvbW11X2RvbWFpbiAqZG9tYWluOw0KPiA+ ICAgCXN0cnVjdCByZXNvdXJjZSAqcmVzOw0KPiA+ICAgCXUxNiBpZCwgYm1fcG9vbF9jbnQ7DQo+ ID4gICAJdTggbWFqb3IsIG1pbm9yOw0KPiA+IEBAIC0yMjUsNiArMjI3LDE1IEBAIHN0YXRpYyBp bnQgZnNsX2JtYW5fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZQ0KPiAqcGRldikNCj4gPg0K PiA+ICAgCWRldl9kYmcoZGV2LCAiQWxsb2NhdGVkIEZCUFIgMHglbGx4IDB4JXp4XG4iLCBmYnBy X2EsIGZicHJfc3opOw0KPiA+DQo+ID4gKwkvKiBDcmVhdGUgYW4gMS10by0xIGlvbW11IG1hcHBp bmcgZm9yIEZCUFIgYXJlYSAqLw0KPiA+ICsJZG9tYWluID0gaW9tbXVfZ2V0X2RvbWFpbl9mb3Jf ZGV2KGRldik7DQo+IA0KPiBJZiB0aGF0J3MgZXhwZWN0ZWQgdG8gYmUgdGhlIGRlZmF1bHQgZG9t YWluIHRoYXQgeW91J3JlIGdyYWJiaW5nLCB0aGVuDQo+IHRoaXMgaXMgKmluY3JlZGlibHkqIGZy YWdpbGUuIFRoZXJlJ3Mgbm90aGluZyB0byBzdG9wIHRoZSBJT1ZBIHRoYXQgeW91DQo+IGZvcmNp Ymx5IG1hcCBmcm9tIGJlaW5nIGF1dG9tYXRpY2FsbHkgYWxsb2NhdGVkIGxhdGVyIGFuZCBjYXVz aW5nIHNvbWUNCj4gb3RoZXIgRE1BIG1hcHBpbmcgdG8gZmFpbCBub2lzaWx5IGFuZCB1bmV4cGVj dGVkbHkuIEZ1cnRoZXJtb3JlLCBoYXZlDQo+IHlvdSB0cmllZCB0aGlzIHdpdGggImlvbW11LnBh c3N0aHJvdWdoPTEiPw0KPiANCj4gVGhhdCBzYWlkLCBJIHJlYWxseSBkb24ndCB1bmRlcnN0YW5k IHdoYXQncyBnb2luZyBvbiBoZXJlIGFueXdheSA6Lw0KPiANCj4gQXMgZmFyIGFzIEkgY2FuIHRl bGwgZnJvbSBxYm1hbl9pbml0X3ByaXZhdGVfbWVtKCksIGZicHJfYSBjb21lcyBmcm9tDQo+IGRt YV9hbGxvY19jb2hlcmVudCgpIGFuZCB0aHVzIHdvdWxkIGFscmVhZHkgYmUgYSBtYXBwZWQgSU9W QSAtIGlzbid0DQo+IHRoaXMgdGhlIHN0dWZmIHRoYXQgUm95IGNvbnZlcnRlZCB0byBuaWNlbHkg dXNlIHNoYXJlZC1kbWEtcG9vbCByZWdpb25zDQo+IGEgd2hpbGUgYWdvPw0KPiANCg0KRmluYWxs eSBmb3VuZCBzb21lIHRpbWUgdG8gbG9vayBpbnRvIHRoaXMsIHNvcnJ5IGZvciB0aGUgZGVsYXku IEl0IHNlZW1zIHRoYXQgb24gdGhlIGNvZGUgcGF0aCB0YWtlbiBpbiBvdXIgY2FzZSAoZG1hX2Fs bG9jX2NvaGVyZW50KCkgLT4gZG1hX2FsbG9jX2F0dHJzKCkgLT4gZG1hX2FsbG9jX2Zyb21fZGV2 X2NvaGVyZW50KCkgLT4gX19kbWFfYWxsb2NfZnJvbV9jb2hlcmVudCgpKSB0aGVyZSdzIG5vIGNh bGwgaW50byB0aGUgaW9tbXUgbGF5ZXIsIHRodXMgbm8gbWFwcGluZyBpbiB0aGUgc21tdS4gSSBw bGFuIHRvIGNvbWUgdXAgd2l0aCBhIFJGQyBwYXRjaCBlYXJseSBuZXh0IHdlZWsgc28gd2UgaGF2 ZSBzb21ldGhpbmcgY29uY3JldGUgdG8gZGlzY3VzcyBvbi4NCg0KLS0tDQpCZXN0IFJlZ2FyZHMs IExhdXJlbnRpdQ0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurentiu Tudor Subject: RE: [PATCH 02/13] soc/fsl/bman: map FBPR area in the iommu Date: Fri, 19 Apr 2019 13:41:38 +0000 Message-ID: References: <20190329140014.8126-1-laurentiu.tudor@nxp.com> <20190329140014.8126-3-laurentiu.tudor@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Robin Murphy , "netdev@vger.kernel.org" , Madalin-cristian Bucur , Roy Pledge , Camelia Alexandra Groza , Leo Li Cc: "iommu@lists.linux-foundation.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "davem@davemloft.net" List-Id: iommu@lists.linux-foundation.org Hi Robin, > -----Original Message----- > From: Robin Murphy > Sent: Friday, March 29, 2019 4:51 PM > > On 29/03/2019 14:00, laurentiu.tudor@nxp.com wrote: > > From: Laurentiu Tudor > > > > Add a one-to-one iommu mapping for bman private data memory (FBPR). > > This is required for BMAN to work without faults behind an iommu. > > > > Signed-off-by: Laurentiu Tudor > > --- > > drivers/soc/fsl/qbman/bman_ccsr.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/soc/fsl/qbman/bman_ccsr.c > b/drivers/soc/fsl/qbman/bman_ccsr.c > > index 7c3cc968053c..b209c79511bb 100644 > > --- a/drivers/soc/fsl/qbman/bman_ccsr.c > > +++ b/drivers/soc/fsl/qbman/bman_ccsr.c > > @@ -29,6 +29,7 @@ > > */ > > > > #include "bman_priv.h" > > +#include > > > > u16 bman_ip_rev; > > EXPORT_SYMBOL(bman_ip_rev); > > @@ -178,6 +179,7 @@ static int fsl_bman_probe(struct platform_device > *pdev) > > int ret, err_irq; > > struct device *dev = &pdev->dev; > > struct device_node *node = dev->of_node; > > + struct iommu_domain *domain; > > struct resource *res; > > u16 id, bm_pool_cnt; > > u8 major, minor; > > @@ -225,6 +227,15 @@ static int fsl_bman_probe(struct platform_device > *pdev) > > > > dev_dbg(dev, "Allocated FBPR 0x%llx 0x%zx\n", fbpr_a, fbpr_sz); > > > > + /* Create an 1-to-1 iommu mapping for FBPR area */ > > + domain = iommu_get_domain_for_dev(dev); > > If that's expected to be the default domain that you're grabbing, then > this is *incredibly* fragile. There's nothing to stop the IOVA that you > forcibly map from being automatically allocated later and causing some > other DMA mapping to fail noisily and unexpectedly. Furthermore, have > you tried this with "iommu.passthrough=1"? > > That said, I really don't understand what's going on here anyway :/ > > As far as I can tell from qbman_init_private_mem(), fbpr_a comes from > dma_alloc_coherent() and thus would already be a mapped IOVA - isn't > this the stuff that Roy converted to nicely use shared-dma-pool regions > a while ago? > Finally found some time to look into this, sorry for the delay. It seems that on the code path taken in our case (dma_alloc_coherent() -> dma_alloc_attrs() -> dma_alloc_from_dev_coherent() -> __dma_alloc_from_coherent()) there's no call into the iommu layer, thus no mapping in the smmu. I plan to come up with a RFC patch early next week so we have something concrete to discuss on. --- Best Regards, Laurentiu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56EFDC282DA for ; Fri, 19 Apr 2019 13:42:01 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21775222B4 for ; Fri, 19 Apr 2019 13:42:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="sb2muPTk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21775222B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id D6F5A23D4; Fri, 19 Apr 2019 13:42:00 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 5124323C2 for ; Fri, 19 Apr 2019 13:41:44 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150077.outbound.protection.outlook.com [40.107.15.77]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1276414D for ; Fri, 19 Apr 2019 13:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bdOMdNJmJGOVzzRDliZ13hYceqbBlu9X588oBQ/37Es=; b=sb2muPTk29AUFBD27Emi7Ons964JYJObjoEZ1DvRmbWMLjf7MV4IwcUIFGurqc6aW4Oe3YZfSuUHyHZ2w/WwvI2mx0r8E9zMVyhgVe2bqXnNMkhq8H8NM+9TKYr3hXz67muslkr6Ge+beLdpTieQvQDyHu/BLIdLVANcOqwRogI= Received: from VI1PR04MB5134.eurprd04.prod.outlook.com (20.177.50.159) by VI1PR04MB5919.eurprd04.prod.outlook.com (20.178.205.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Fri, 19 Apr 2019 13:41:39 +0000 Received: from VI1PR04MB5134.eurprd04.prod.outlook.com ([fe80::5c9b:12cc:80f2:1f42]) by VI1PR04MB5134.eurprd04.prod.outlook.com ([fe80::5c9b:12cc:80f2:1f42%3]) with mapi id 15.20.1813.013; Fri, 19 Apr 2019 13:41:39 +0000 From: Laurentiu Tudor To: Robin Murphy , "netdev@vger.kernel.org" , Madalin-cristian Bucur , Roy Pledge , Camelia Alexandra Groza , Leo Li Subject: RE: [PATCH 02/13] soc/fsl/bman: map FBPR area in the iommu Thread-Topic: [PATCH 02/13] soc/fsl/bman: map FBPR area in the iommu Thread-Index: AQHU5je+GYAdWERgxkCiU6HsMs84n6YisRcAgCDsguA= Date: Fri, 19 Apr 2019 13:41:38 +0000 Message-ID: References: <20190329140014.8126-1-laurentiu.tudor@nxp.com> <20190329140014.8126-3-laurentiu.tudor@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=laurentiu.tudor@nxp.com; x-originating-ip: [213.233.110.112] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f1080e5-4da5-4fa6-733c-08d6c4ccbfd8 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB5919; x-ms-traffictypediagnostic: VI1PR04MB5919: x-microsoft-antispam-prvs: x-forefront-prvs: 0012E6D357 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(39860400002)(366004)(396003)(199004)(13464003)(189003)(55016002)(73956011)(66946007)(6246003)(52536014)(99286004)(66066001)(478600001)(2906002)(9686003)(97736004)(68736007)(44832011)(76176011)(86362001)(64756008)(76116006)(66446008)(53936002)(316002)(7696005)(54906003)(6116002)(110136005)(14454004)(6636002)(256004)(229853002)(476003)(6436002)(186003)(11346002)(74316002)(81156014)(4326008)(7736002)(305945005)(25786009)(26005)(71190400001)(33656002)(71200400001)(53546011)(486006)(6506007)(81166006)(8676002)(3846002)(102836004)(446003)(8936002)(66476007)(2501003)(5660300002)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5919; H:VI1PR04MB5134.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BeFY///qE+RmwKpRlRJcQbMDG6Ojm0ES1+M6FnlZDN7AFfwPqkRA68Yel4C5A2BZA38ZKAEfl1itecVa5l+X+os/AuRHbPYLy4ZGAxoUwRyCftMZOOmFpLLFo7yBfLSkHiI8puUkfAts9wEV92UfWF1RxW5MaBabJ5yZv/j9rI7GYMAn5aizHP+ZQTGA6ZKkstQwz8J6iXMVkT2Harme/xs49FxgfnffoYxNnsAmTL5Wc0WJahLAz7Y8rXrIoO6tNp7XOXRSwgoMRh+RX5jO57Q+5wbT31pp0pI1r5Rs91rZ4K0v2PlLJ3HN5rRT9XwITBffXN6+aZrZRbXS3TA5OFFuqf+mdvUv/kgn5bnLfi0dmt09sEwrT00SW+39HTDnRJbfJ+wSEv4TdLIinJMAhtrEpzA9DQxlzKbWvKjsPxk= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f1080e5-4da5-4fa6-733c-08d6c4ccbfd8 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2019 13:41:38.8808 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5919 Cc: "iommu@lists.linux-foundation.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "davem@davemloft.net" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190419134138.5ZkB8H8a46nkTzG_oz9SEMXvshAORyyK5Vn1M7Q50yk@z> Hi Robin, > -----Original Message----- > From: Robin Murphy > Sent: Friday, March 29, 2019 4:51 PM > > On 29/03/2019 14:00, laurentiu.tudor@nxp.com wrote: > > From: Laurentiu Tudor > > > > Add a one-to-one iommu mapping for bman private data memory (FBPR). > > This is required for BMAN to work without faults behind an iommu. > > > > Signed-off-by: Laurentiu Tudor > > --- > > drivers/soc/fsl/qbman/bman_ccsr.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/soc/fsl/qbman/bman_ccsr.c > b/drivers/soc/fsl/qbman/bman_ccsr.c > > index 7c3cc968053c..b209c79511bb 100644 > > --- a/drivers/soc/fsl/qbman/bman_ccsr.c > > +++ b/drivers/soc/fsl/qbman/bman_ccsr.c > > @@ -29,6 +29,7 @@ > > */ > > > > #include "bman_priv.h" > > +#include > > > > u16 bman_ip_rev; > > EXPORT_SYMBOL(bman_ip_rev); > > @@ -178,6 +179,7 @@ static int fsl_bman_probe(struct platform_device > *pdev) > > int ret, err_irq; > > struct device *dev = &pdev->dev; > > struct device_node *node = dev->of_node; > > + struct iommu_domain *domain; > > struct resource *res; > > u16 id, bm_pool_cnt; > > u8 major, minor; > > @@ -225,6 +227,15 @@ static int fsl_bman_probe(struct platform_device > *pdev) > > > > dev_dbg(dev, "Allocated FBPR 0x%llx 0x%zx\n", fbpr_a, fbpr_sz); > > > > + /* Create an 1-to-1 iommu mapping for FBPR area */ > > + domain = iommu_get_domain_for_dev(dev); > > If that's expected to be the default domain that you're grabbing, then > this is *incredibly* fragile. There's nothing to stop the IOVA that you > forcibly map from being automatically allocated later and causing some > other DMA mapping to fail noisily and unexpectedly. Furthermore, have > you tried this with "iommu.passthrough=1"? > > That said, I really don't understand what's going on here anyway :/ > > As far as I can tell from qbman_init_private_mem(), fbpr_a comes from > dma_alloc_coherent() and thus would already be a mapped IOVA - isn't > this the stuff that Roy converted to nicely use shared-dma-pool regions > a while ago? > Finally found some time to look into this, sorry for the delay. It seems that on the code path taken in our case (dma_alloc_coherent() -> dma_alloc_attrs() -> dma_alloc_from_dev_coherent() -> __dma_alloc_from_coherent()) there's no call into the iommu layer, thus no mapping in the smmu. I plan to come up with a RFC patch early next week so we have something concrete to discuss on. --- Best Regards, Laurentiu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC04BC282DA for ; Fri, 19 Apr 2019 13:41:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99D49222B4 for ; Fri, 19 Apr 2019 13:41:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qCUSn3Yy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="sb2muPTk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99D49222B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NeciKHl1yWyhRqdGHEv0sVZCNiNJ5XphEDhSvQoThhI=; b=qCUSn3YyMH4TCO JPJQgCn2d+6FXZJ1O+xnYKQ2b6KDBtAkY7zzE/+UdeGxElqCcuC6akRss0n02Xu5iZ7YyZXKv1GJp Yc9BVeXpBILFdp3czTRs/jB/Cf+WxOWDS5d255SXN1zNz+qQ9wZHy8j4lho4QnVgiykJz3vYK5f8d lVTIZzC5kMoWZaJXvyIVrlhR9CXt48Oqwc7rF1oN7PLEF27bTSBtG4WKfPlT0DgnFjXOZQvh3C0PN YEtX79OHNAEZyth27km/MudRHbB7WL+6lAE/PV+pwGWXlZ7M7Mt8qcm+ERZltg6TDDXpaRsFe7Mx8 EMfm6zcoUV6rESnAqQQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHTm1-0006LT-1v; Fri, 19 Apr 2019 13:41:49 +0000 Received: from mail-db5eur01on0622.outbound.protection.outlook.com ([2a01:111:f400:fe02::622] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHTlx-0006L4-1y for linux-arm-kernel@lists.infradead.org; Fri, 19 Apr 2019 13:41:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bdOMdNJmJGOVzzRDliZ13hYceqbBlu9X588oBQ/37Es=; b=sb2muPTk29AUFBD27Emi7Ons964JYJObjoEZ1DvRmbWMLjf7MV4IwcUIFGurqc6aW4Oe3YZfSuUHyHZ2w/WwvI2mx0r8E9zMVyhgVe2bqXnNMkhq8H8NM+9TKYr3hXz67muslkr6Ge+beLdpTieQvQDyHu/BLIdLVANcOqwRogI= Received: from VI1PR04MB5134.eurprd04.prod.outlook.com (20.177.50.159) by VI1PR04MB5919.eurprd04.prod.outlook.com (20.178.205.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Fri, 19 Apr 2019 13:41:39 +0000 Received: from VI1PR04MB5134.eurprd04.prod.outlook.com ([fe80::5c9b:12cc:80f2:1f42]) by VI1PR04MB5134.eurprd04.prod.outlook.com ([fe80::5c9b:12cc:80f2:1f42%3]) with mapi id 15.20.1813.013; Fri, 19 Apr 2019 13:41:39 +0000 From: Laurentiu Tudor To: Robin Murphy , "netdev@vger.kernel.org" , Madalin-cristian Bucur , Roy Pledge , Camelia Alexandra Groza , Leo Li Subject: RE: [PATCH 02/13] soc/fsl/bman: map FBPR area in the iommu Thread-Topic: [PATCH 02/13] soc/fsl/bman: map FBPR area in the iommu Thread-Index: AQHU5je+GYAdWERgxkCiU6HsMs84n6YisRcAgCDsguA= Date: Fri, 19 Apr 2019 13:41:38 +0000 Message-ID: References: <20190329140014.8126-1-laurentiu.tudor@nxp.com> <20190329140014.8126-3-laurentiu.tudor@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=laurentiu.tudor@nxp.com; x-originating-ip: [213.233.110.112] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f1080e5-4da5-4fa6-733c-08d6c4ccbfd8 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB5919; x-ms-traffictypediagnostic: VI1PR04MB5919: x-microsoft-antispam-prvs: x-forefront-prvs: 0012E6D357 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(39860400002)(366004)(396003)(199004)(13464003)(189003)(55016002)(73956011)(66946007)(6246003)(52536014)(99286004)(66066001)(478600001)(2906002)(9686003)(97736004)(68736007)(44832011)(76176011)(86362001)(64756008)(76116006)(66446008)(53936002)(316002)(7696005)(54906003)(6116002)(110136005)(14454004)(6636002)(256004)(229853002)(476003)(6436002)(186003)(11346002)(74316002)(81156014)(4326008)(7736002)(305945005)(25786009)(26005)(71190400001)(33656002)(71200400001)(53546011)(486006)(6506007)(81166006)(8676002)(3846002)(102836004)(446003)(8936002)(66476007)(2501003)(5660300002)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5919; H:VI1PR04MB5134.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BeFY///qE+RmwKpRlRJcQbMDG6Ojm0ES1+M6FnlZDN7AFfwPqkRA68Yel4C5A2BZA38ZKAEfl1itecVa5l+X+os/AuRHbPYLy4ZGAxoUwRyCftMZOOmFpLLFo7yBfLSkHiI8puUkfAts9wEV92UfWF1RxW5MaBabJ5yZv/j9rI7GYMAn5aizHP+ZQTGA6ZKkstQwz8J6iXMVkT2Harme/xs49FxgfnffoYxNnsAmTL5Wc0WJahLAz7Y8rXrIoO6tNp7XOXRSwgoMRh+RX5jO57Q+5wbT31pp0pI1r5Rs91rZ4K0v2PlLJ3HN5rRT9XwITBffXN6+aZrZRbXS3TA5OFFuqf+mdvUv/kgn5bnLfi0dmt09sEwrT00SW+39HTDnRJbfJ+wSEv4TdLIinJMAhtrEpzA9DQxlzKbWvKjsPxk= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f1080e5-4da5-4fa6-733c-08d6c4ccbfd8 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2019 13:41:38.8808 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5919 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190419_064145_176607_D2A97F1C X-CRM114-Status: GOOD ( 20.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "iommu@lists.linux-foundation.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "davem@davemloft.net" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Robin, > -----Original Message----- > From: Robin Murphy > Sent: Friday, March 29, 2019 4:51 PM > > On 29/03/2019 14:00, laurentiu.tudor@nxp.com wrote: > > From: Laurentiu Tudor > > > > Add a one-to-one iommu mapping for bman private data memory (FBPR). > > This is required for BMAN to work without faults behind an iommu. > > > > Signed-off-by: Laurentiu Tudor > > --- > > drivers/soc/fsl/qbman/bman_ccsr.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/soc/fsl/qbman/bman_ccsr.c > b/drivers/soc/fsl/qbman/bman_ccsr.c > > index 7c3cc968053c..b209c79511bb 100644 > > --- a/drivers/soc/fsl/qbman/bman_ccsr.c > > +++ b/drivers/soc/fsl/qbman/bman_ccsr.c > > @@ -29,6 +29,7 @@ > > */ > > > > #include "bman_priv.h" > > +#include > > > > u16 bman_ip_rev; > > EXPORT_SYMBOL(bman_ip_rev); > > @@ -178,6 +179,7 @@ static int fsl_bman_probe(struct platform_device > *pdev) > > int ret, err_irq; > > struct device *dev = &pdev->dev; > > struct device_node *node = dev->of_node; > > + struct iommu_domain *domain; > > struct resource *res; > > u16 id, bm_pool_cnt; > > u8 major, minor; > > @@ -225,6 +227,15 @@ static int fsl_bman_probe(struct platform_device > *pdev) > > > > dev_dbg(dev, "Allocated FBPR 0x%llx 0x%zx\n", fbpr_a, fbpr_sz); > > > > + /* Create an 1-to-1 iommu mapping for FBPR area */ > > + domain = iommu_get_domain_for_dev(dev); > > If that's expected to be the default domain that you're grabbing, then > this is *incredibly* fragile. There's nothing to stop the IOVA that you > forcibly map from being automatically allocated later and causing some > other DMA mapping to fail noisily and unexpectedly. Furthermore, have > you tried this with "iommu.passthrough=1"? > > That said, I really don't understand what's going on here anyway :/ > > As far as I can tell from qbman_init_private_mem(), fbpr_a comes from > dma_alloc_coherent() and thus would already be a mapped IOVA - isn't > this the stuff that Roy converted to nicely use shared-dma-pool regions > a while ago? > Finally found some time to look into this, sorry for the delay. It seems that on the code path taken in our case (dma_alloc_coherent() -> dma_alloc_attrs() -> dma_alloc_from_dev_coherent() -> __dma_alloc_from_coherent()) there's no call into the iommu layer, thus no mapping in the smmu. I plan to come up with a RFC patch early next week so we have something concrete to discuss on. --- Best Regards, Laurentiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel