[Buildroot] [EXT] Re: [PATCH v4 1/9] package/nxp: new package directory

[Jerry Huang <jerry.huang@nxp.com>]

Best Regards
Jerry Huang

> -----Original Message-----
> From: Heiko Thiery <heiko.thiery@gmail.com>
> Sent: Wednesday, February 5, 2020 10:09 PM
> To: Jerry Huang <jerry.huang@nxp.com>
> Cc: buildroot at busybox.net; olteanv at gmail.com; Michael Walle
> <michael@walle.cc>; geomatsi at gmail.com; matthew.weber at collins.com;
> Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Subject: [EXT] Re: [Buildroot] [PATCH v4 1/9] package/nxp: new package
> directory
> 
> Caution: EXT Email
> 
> Hi Changming,
> 
> >
> +###############################################################
> ######
> > +###########
> > +#
> > +# helper
> > +#
> >
> +###############################################################
> ######
> > +###########
> > +
> > +# Helper for self-extracting binaries distributed by NXP.
> > +#
> > +# The --force option makes sure it doesn't fail if the source #
> > +directory already exists. The --auto-accept skips the license check,
> > +# as it is not needed in Buildroot because we have legal-info. Since
> > +# there's a EULA in the binary file, we extract it in this macro, and
> > +# it should therefore be added to the LICENSE_FILES variable of #
> > +packages using this macro. Also, remember to set REDISTRIBUTE to #
> > +"NO". Indeed, this is a legal minefield: the EULA specifies that the
> > +# Board Support Package includes software and hardware (sic!) for #
> > +which a separate license is needed...
> > +#
> > +# $(1): full path to the archive file # define NXP_EXTRACT_HELPER
> > +       awk 'BEGIN      { start = 0; } \
> > +            /^EOEULA/  { start = 0; } \
> > +                       { if (start) print; } \
> > +            /<<EOEULA/ { start = 1; }' \
> > +           $(1) > $(@D)/EULA
> > +       cd $(@D) && sh $(1) --force --auto-accept
> > +       find $(@D)/$(basename $(notdir $(1))) -mindepth 1 -maxdepth 1
> -exec mv {} $(@D) \;
> > +       rmdir $(@D)/$(basename $(notdir $(1))) endef
> > +
> > +include $(sort $(wildcard package/nxp/*/*.mk))
> 
> This seems to be a duplication of the FREESCALE_IMX_EXTRACT_HELPER, isn't
> it?
> Do we then can remove the other one and use only the new "nxp" one?
> 
> By the way is there a plan to move all NXP specific packages (qoriq and imx) to
> the nxp subdir?
Yes, the helper is the duplication of FREESCALE_IMX_EXTRACT_HELPER.
Because Freescale is merged into NXP a few years ago, according to NXP's policy, we need to use nxp, instead of freescale.
So, I think the packages related NXP should be move into nxp directory.

> --
> Heiko