From: Leonard Crestez <leonard.crestez@nxp.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Trent Piepho <tpiepho@impinj.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Stefan Agner <stefan@agner.ch>,
Richard Zhu <hongxing.zhu@nxp.com>,
dl-linux-imx <linux-imx@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] PCI: imx6: Simplify Kconfig depends on
Date: Fri, 12 Apr 2019 17:56:22 +0000 [thread overview]
Message-ID: <VI1PR04MB5533A64718D373F9F8357BCDEE280@VI1PR04MB5533.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20190326181912.GB12093@e107981-ln.cambridge.arm.com
On 3/26/19 8:19 PM, Lorenzo Pieralisi wrote:
> On Mon, Mar 11, 2019 at 06:59:28PM +0000, Leonard Crestez wrote:
>> In theory this driver can be used on imx6sx without enabling support for
>> imx6q or imx7d but the "depends on" condition doesn't allow that.
>>
>> Instead of making the condition even longer just make it depend on
>> "ARCH_MXC || COMPILE_TEST" instead.
>>
>> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>> ---
>> drivers/pci/controller/dwc/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
>> index 6ea74b1c0d94..21747fd0e799 100644
>> --- a/drivers/pci/controller/dwc/Kconfig
>> +++ b/drivers/pci/controller/dwc/Kconfig
>> @@ -88,11 +88,11 @@ config PCI_EXYNOS
>> depends on PCI_MSI_IRQ_DOMAIN
>> select PCIE_DW_HOST
>>
>> config PCI_IMX6
>> bool "Freescale i.MX6/7/8 PCIe controller"
>> - depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST
>> + depends on ARCH_MXC || COMPILE_TEST
>> depends on PCI_MSI_IRQ_DOMAIN
>> select PCIE_DW_HOST
>
> If Lucas does not spot any problem with this patch I would request his
> ACK to merge it, thanks.
Lucas: Can you please ack this? It's a bit old but applies cleanly and
resend shouldn't be required.
--
Regards,
Leonard
next prev parent reply other threads:[~2019-04-12 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 18:59 [PATCH] PCI: imx6: Simplify Kconfig depends on Leonard Crestez
2019-03-26 18:19 ` Lorenzo Pieralisi
2019-04-12 17:56 ` Leonard Crestez [this message]
2019-04-12 18:03 ` Trent Piepho
2019-04-12 18:20 ` Leonard Crestez
2019-04-30 14:22 ` Lorenzo Pieralisi
2019-07-05 15:41 ` Lucas Stach
2019-07-05 15:51 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB5533A64718D373F9F8357BCDEE280@VI1PR04MB5533.eurprd04.prod.outlook.com \
--to=leonard.crestez@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=l.stach@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.