From: Leonard Crestez <leonard.crestez@nxp.com>
To: "stefan@agner.ch" <stefan@agner.ch>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>
Cc: Trent Piepho <tpiepho@impinj.com>,
Richard Zhu <hongxing.zhu@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>,
"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length
Date: Wed, 21 Nov 2018 13:47:05 +0000 [thread overview]
Message-ID: <VI1PR04MB5533BBC2B45752ED84E4D037EEDA0@VI1PR04MB5533.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 1542749302.30311.624.camel@impinj.com
On 11/20/2018 11:28 PM, Trent Piepho wrote:
> On Tue, 2018-11-20 at 21:42 +0100, Stefan Agner wrote:
>> On 20.11.2018 20:13, Trent Piepho wrote:
>>> It also seems to me that this doesn't need to be in the internal pci
>>> config access functions. The driver shouldn't be reading registers
>>> that don't exist anyway. It's really about trying to fix sysfs access
>>> to registers that don't exist. So maybe it should be done there.
>>
>> That was my first approach, see:
>
> Yes, but that just used the pci device id which applies to every IMX
> design.
>
> It's also not totally correct, as it seems real registers after 0x200
> do work on imx6, and that would prevent access to them.
I see that Lorenzo already accepted the patch in pci/dwc:
https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?h=pci/dwc&id=f14eaec153aaebbe940ddd21e4198cc2abc927c2
My tests show that this series breaks pci cards on 6qdl and I think it
should be reverted until a fix is found. Are you OK with this?
Fixing might require an entirely different approach.
next prev parent reply other threads:[~2018-11-21 13:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 16:56 [PATCH v3 1/2] PCI: imx6: introduce drvdata Stefan Agner
2018-11-20 16:56 ` [PATCH v3 2/2] PCI: imx6: limit DBI register length Stefan Agner
2018-11-20 18:19 ` Leonard Crestez
2018-11-20 19:13 ` Trent Piepho
2018-11-20 20:42 ` Stefan Agner
2018-11-20 21:28 ` Trent Piepho
2018-11-21 13:47 ` Leonard Crestez [this message]
2018-11-21 14:17 ` Lorenzo Pieralisi
2018-11-28 12:19 ` Stefan Agner
2018-11-28 17:36 ` Stefan Agner
2018-11-28 17:50 ` Lucas Stach
2018-11-28 17:56 ` Stefan Agner
2018-11-28 18:01 ` Leonard Crestez
2018-11-26 10:16 ` Leonard Crestez
2018-11-26 16:34 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB5533BBC2B45752ED84E4D037EEDA0@VI1PR04MB5533.eurprd04.prod.outlook.com \
--to=leonard.crestez@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=stefan@agner.ch \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.