From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C75AEC433EF for ; Fri, 7 Jan 2022 16:23:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1D2CC83662; Fri, 7 Jan 2022 17:23:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="ftQ+HJCE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CC574836C5; Fri, 7 Jan 2022 17:23:05 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on061d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe02::61d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9A05283510 for ; Fri, 7 Jan 2022 17:23:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=camelia.groza@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NtksoYVx80xTLpkYRYZkUtX2bC6JnrkoUhU6PU92auq8ulbAtDTLpsxDwlaV3c9f4BL3tGupcem2CmuuNo1TfoDFevN/EStvsJO8ty86QXur9DW5EB9PlQ418/ZX2eP39+zBkADgx/uRs7C0pgVv1OE2EHjP+dd/w6CqPpzAxS5grQE/UKyIFLGx8YXXhfaah5C+7j/UBJLoZCPlihlt4w4U6oZAa18ggYa4cs06vkA03LhkIGlpvS32jcm05bQcvYAhgwpKgsbqgsga14YlM+B9vV4EN7TfUB/V+17HRlMjt9e8GMIU7qpzEU4dxWuVSpHPfXkVdNV9PsaJB0PVlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JRpoWRSiK/FMrASoMahpHcQGNm6yUYXJtatvFkKB5T8=; b=Ppn0mCQpEcaRaGuU22ty+eS+yP6AKYxI/RHDlRynRbd1YWgVJBbhqoxht60WeIUw0RBBjrELXxZ7c5ROKhZQjPuEl2soYF7wlDRMEspnwNv61odc6y/QzcWeJezAfaV3/Sjkz631aMDEQC26US1T1xcldaLcee8JqT/4pj4XmJnNQnWdKgUTmuhs3ndJFc4QCqQ94o0mcUug0bas6tQ0tqs0UADM969VGcz9qlrhqz3pde4dARQGRQAOuOZ+Hd3/fbIPFwFa5TniYtwwoWQUe1ETf4RlsB2crlwuzIaIfAzYP9xRqUv5f09j122SFDxxkFiE7UikPlrCEyBkq7zDjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JRpoWRSiK/FMrASoMahpHcQGNm6yUYXJtatvFkKB5T8=; b=ftQ+HJCEO+ab1K62SiH2Bdci+11HWwuJVnM4L4RQSYgGhj7tMByys1BEIIC6zo5/Ixp/6LRXxZnh7Sxbo8Z+0jyCMTV/tufURDUz1wLm4qHyyMkAO8hgeA7SDXc64pWuGH5mhTMvu0I8WRP+X+ac2hcZKPeB1gEiuaZ3E9dvdro= Received: from VI1PR04MB5807.eurprd04.prod.outlook.com (2603:10a6:803:ec::21) by VI1PR0401MB2477.eurprd04.prod.outlook.com (2603:10a6:800:55::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.10; Fri, 7 Jan 2022 16:23:00 +0000 Received: from VI1PR04MB5807.eurprd04.prod.outlook.com ([fe80::5cde:3f13:f9d2:d1b]) by VI1PR04MB5807.eurprd04.prod.outlook.com ([fe80::5cde:3f13:f9d2:d1b%4]) with mapi id 15.20.4867.009; Fri, 7 Jan 2022 16:23:00 +0000 From: "Camelia Alexandra Groza (OSS)" To: Markus Koch , Ioana Ciornei , "joe.hershberger@ni.com" , "rfried.dev@gmail.com" CC: "Madalin Bucur (OSS)" , "u-boot@lists.denx.de" Subject: RE: [PATCH v2] net: fsl_mdio: Fix busy flag polling register Thread-Topic: [PATCH v2] net: fsl_mdio: Fix busy flag polling register Thread-Index: AQHYAYIbbm1LLZYNkEiA+uZ/vE1goaxXwqbA Date: Fri, 7 Jan 2022 16:23:00 +0000 Message-ID: References: <20220104154149.9473-1-markus@notsyncing.net> In-Reply-To: <20220104154149.9473-1-markus@notsyncing.net> Accept-Language: en-GB, ro-RO, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b885b885-2522-4096-eebb-08d9d1f9f8ff x-ms-traffictypediagnostic: VI1PR0401MB2477:EE_ x-ms-exchange-sharedmailbox-routingagent-processed: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PW53Ex+RzSAFj8THlFRan3eC8OhgOf6sDJVTZ89X7VarqmMlbN93/GF8CyyeETBk8bfgVD8SR5i1hM4XpIf5XrF/yc1AYG9rI/4niE0WySY/zwlUckMhcIi1oQOQT/gKqEfeQzLI7PfV9lm98k/f2NGyDZzdsRunW6FgN9PPDH/z5rRq6VMi1LvoJJQbjilzyjlNRq0onxu1hKo4lSKChkezGW4aD0E1DqC5oH7M/qmh8zOiZZ+xfo1FJs6vfh5lbdnZjCV3dQXmG6eLyvFcgYwrg4vuhX4NijI4yrDEkSoqov6BfmtJyVIkTZqElIABxNcKaForCxkt+64eYth7qTWELeeM6TFE4ZtceQz+Os3xtY/k30il0pHMdMfCsGtT0Jw5xi2XcxDE9JK2Mxjv5sGnfhAqTOwvH0RBwl0ybvHYiW4t3Mg86xq6EHO97U12NrG3GwNFkGAf+1qvEr/C5M9tTuBZKV4ckM3R4kVwkWHDH2NZJJfwwRB9Ok46bwYccdtSLLcJztwDbuN9I+x0vzJ1da9UnJ1iBY/ZcHreRT9BQOZXcpe+AydydA9LgsaMnPZzsZR9HnWOGFRxBkDkXYByuU+fg0sRCapw0iwBQW5rBLBCiJO1ihiE7B4xR7tyVdJJ5xo4eBvjXk9Rxaiu7KNvqFNI2ICKnbigS8hZipjK8R+e336pXnbOuC+4FPiHS1+VRFUr0IrU/rEIcMtGDA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5807.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(52536014)(122000001)(7696005)(38100700002)(66446008)(83380400001)(64756008)(66556008)(66946007)(9686003)(54906003)(76116006)(5660300002)(66476007)(53546011)(8676002)(2906002)(71200400001)(186003)(110136005)(26005)(38070700005)(6506007)(508600001)(55016003)(33656002)(86362001)(316002)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zc7q/gi1dcCreLbE8oDBUdSbq9QvVTtX5GfwP3aD3+dOVmC46rHCa14ktkOn?= =?us-ascii?Q?I9V0m2dlaPdWesKbYkhLweSHrSRHp40rFig9nXL0IjK6r6jTf6qFldaPrSyO?= =?us-ascii?Q?e22T5HJJDtGcONuEUY5nBw+mVo36Y/RaocQD1rYq9AxIHf231nan3M+elo0p?= =?us-ascii?Q?XXevjkxn0+Iwaaxd7WPghcyUXpp9kZhkLBhaSuV4j4ly4HTt6gi+Rz5INiPx?= =?us-ascii?Q?qOxn4ZC9TN5i0jFwZqWnltneXJZbkuBglIZTiPSbPaMMFZaOsA2+2Cy7lA+P?= =?us-ascii?Q?LaLuj3iuMct7Ssw3ueS+it72SixiwcqOtit86+1AMnkbdWh0EQzJWWls2GzM?= =?us-ascii?Q?HgEGyTV3oN6V8Ce6WVxseIdVNAYdzaSd66uFVcEnNzSPU/5tIF7hwWdPT0af?= =?us-ascii?Q?+BBpVX+KoZZ+/k1t2ks2G1FfAMx5U/JBIFyVXXORT9dVns3IxAz5wimUzzaV?= =?us-ascii?Q?20+8F4oygYpqnGS2KwMV2if4DJmV9IZ6mz0eNtIBY2PUAEG1YznsBgkSAzdg?= =?us-ascii?Q?UE3QK74x6JmrC0rL0Z+q9hJ2dK5HncSbY4BPLK63kwt85WCBYg/qCQ0qcYgW?= =?us-ascii?Q?YJXZLaWrpomb0NvqskZI6oloZUMp348bpavIw/nWtl8DYsYyc9q5U0XDGO2O?= =?us-ascii?Q?40EceIXkIEANcbeC71naUUEjffOwa2amRYI7o0vIzJJShgyCz/PUasvevcrx?= =?us-ascii?Q?44nzDtbcBW+ULOfimJL+ShHLaGQTUQbWZHQH2n5yvZXS+BloKdaCskEIcvIT?= =?us-ascii?Q?ktBRtBiT4s0mKKSp+9coXuGzKb7FVJyFEaT3wJOVc7dh1vOxf8DMnD1+ah7P?= =?us-ascii?Q?VAyDCgiaucHyKV+im67Kwhgt9YV6+S7kys+UWmVINSsdXc910NVckpqUyTJJ?= =?us-ascii?Q?P5IeUDKZ/0evFDNSh/FtNm3/XKOtL1Amm9qJQc2RRmipYF/gyHWbI7ccm05T?= =?us-ascii?Q?SX0CNnLM1zDDm/k9I/XxYGTj83fOxkn9ppDPzxpQc036+7bhhBY0Sq47DILe?= =?us-ascii?Q?i26jenqFk2E5x75vcPWrDFcr7tWi+yhnCy+9LYGQ1Nq4z5fteQfNcX+K1CbI?= =?us-ascii?Q?SvT1T4Y83PRlem6L5g8/Rc73dy19ts/9vF4D70Ege2Kt0tz0v2HjXAy2Ph0s?= =?us-ascii?Q?RR3quV/rG9ZWmYRxrs/e435Xz37PzIzXeU1ew+cdwlGAKMhkiSP5qTTt/LO0?= =?us-ascii?Q?0asvpRCCJhlKDvzE0oyh1RJo1TRi7hp4+ESQNd/SdEHg68c7R7KKhSr7jhYl?= =?us-ascii?Q?umTCMSR2FG3Hz5qbel01ClBA54r7plfzrI9yoMtMWy0FWspViHxUZqUEHAT5?= =?us-ascii?Q?REXWG32mdfw6cwCmuxtoT41qUGDyIS7f+VFB1iPH3/dt7bTWev/PVZp4e7W6?= =?us-ascii?Q?KLsP8ST3O0IRHR/RyY+oUlKL6GnO6lIUGOA3HUsY7U8a5ZYE3EAoOtYgRWL4?= =?us-ascii?Q?i5KQpuvY6559uOgPh+FF8y4YFfG7i4TmtAZUS4AYNTP30xYBiVD8bjALzwRp?= =?us-ascii?Q?kCB2s7FnxG9fi4CARObV7sPaulPPASuuteB+tTWEsSHepO8e3Y+GV/JWF7gV?= =?us-ascii?Q?1Th5XyYPfabiRp4jedzqnQ6hgDHLEFFMu0V2Yw/A4myFntKoibX9rHo9fW2L?= =?us-ascii?Q?hNoyc/peFzu9UZRPR1CflLg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5807.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b885b885-2522-4096-eebb-08d9d1f9f8ff X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2022 16:23:00.2501 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rToUhdQn/yewvIoJ87pL8tXKgu4z0XJlLuEqLLdD1TMqjdFucRZfHTRcSPfhoKH7EtRwH34YEJRjMwuMZFHWaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2477 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean > -----Original Message----- > From: U-Boot On Behalf Of Markus Koch > Sent: Tuesday, January 4, 2022 17:42 > To: Ioana Ciornei ; joe.hershberger@ni.com; > rfried.dev@gmail.com > Cc: Madalin Bucur (OSS) ; Camelia Alexandra > Groza ; u-boot@lists.denx.de; Markus Koch > > Subject: [PATCH v2] net: fsl_mdio: Fix busy flag polling register >=20 > NXP's mEMAC reference manual, Chapter 6.5.5 "MDIO Ethernet > Management > Interface usage", specifies to poll the BSY (0) bit in the CFG/STAT > register to wait until a transaction has finished, not bit 31 in the > data register. >=20 > In the Linux kernel, this has already been fixed in commit 26eee0210ad7 > ("net/fsl: fix a bug in xgmac_mdio"). >=20 > Signed-off-by: Markus Koch I am ok with the change for the mEMAC driver but MDIO_DATA_BSY is still used by the fsl_ls_mdio driver. The MDIO driver suffers from the same issue= . Please send a v3 and either patch both drivers or don't remove the define. Also, if removing the define, please mention it explicitly in the patch description. Thanks, Camelia > --- >=20 > Changed to use the mdio_stat register. Thanks, Ioana! >=20 > drivers/net/fm/memac_phy.c | 2 +- > include/fsl_memac.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/net/fm/memac_phy.c b/drivers/net/fm/memac_phy.c > index 72b500a6d1..3ddae97e09 100644 > --- a/drivers/net/fm/memac_phy.c > +++ b/drivers/net/fm/memac_phy.c > @@ -64,7 +64,7 @@ static int memac_wait_until_done(struct > memac_mdio_controller *regs) > { > unsigned int timeout =3D MAX_NUM_RETRIES; >=20 > - while ((memac_in_32(®s->mdio_data) & MDIO_DATA_BSY) && > timeout--) > + while ((memac_in_32(®s->mdio_stat) & MDIO_STAT_BSY) && > timeout--) > ; >=20 > if (!timeout) { > diff --git a/include/fsl_memac.h b/include/fsl_memac.h > index d067f1511c..6ac1e558b9 100644 > --- a/include/fsl_memac.h > +++ b/include/fsl_memac.h > @@ -254,7 +254,6 @@ struct memac_mdio_controller { > #define MDIO_CTL_READ (1 << 15) >=20 > #define MDIO_DATA(x) (x & 0xffff) > -#define MDIO_DATA_BSY (1 << 31) >=20 > struct fsl_enet_mac; >=20 > -- > 2.34.1