From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C1FBC43381 for ; Mon, 18 Mar 2019 20:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00A8120828 for ; Mon, 18 Mar 2019 20:35:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="eF4oEp0J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727208AbfCRUfq (ORCPT ); Mon, 18 Mar 2019 16:35:46 -0400 Received: from mail-eopbgr140079.outbound.protection.outlook.com ([40.107.14.79]:38628 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726980AbfCRUfq (ORCPT ); Mon, 18 Mar 2019 16:35:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=48wB7eadQjMQGEzj9t5WqQedH1Jh2HzxD+H+KbkKrTI=; b=eF4oEp0JedeR+3EzF+Vob5FcUnz+wV5IO0XW56G0nOLlVHo8GOjc4Z5wiC9g0kVaFzBfOb5dhy3oSuHXkuq3M61qvgkLwlHOiRzXnGozmTlNV5wr96NHAbhKEmG5IxIoRiZkEGx42ZfUJiaZWYnvKESMMCwH6ZI3kwTpfhonbdU= Received: from VI1PR0501MB2271.eurprd05.prod.outlook.com (10.169.135.8) by VI1PR0501MB2575.eurprd05.prod.outlook.com (10.168.137.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.14; Mon, 18 Mar 2019 20:35:02 +0000 Received: from VI1PR0501MB2271.eurprd05.prod.outlook.com ([fe80::a0b8:7ed8:d657:2f59]) by VI1PR0501MB2271.eurprd05.prod.outlook.com ([fe80::a0b8:7ed8:d657:2f59%6]) with mapi id 15.20.1709.015; Mon, 18 Mar 2019 20:35:02 +0000 From: Parav Pandit To: Jakub Kicinski CC: Jiri Pirko , "Samudrala, Sridhar" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Thread-Topic: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Thread-Index: AQHU0FlVGn07mv/5S0qtfXL/6zV0naX4F3YAgACpvYCAAl2OgIABFocAgACw24CAAGdAAIABP+yAgABd4gCAAQniAIABHgoAgADJ0ICAAEdZgIAECm0AgAEiPwCAAMbcgIAAc58AgACZ0oCAAKqSgIAAAXSAgAAJR4CAAPajAIAA82GAgAAGytCAABI3gIAAHF7AgAAPYgCAAAD0MIAAPSgAgACeBbCAAE9/AIAAG6zwgAQYzoCAADlP0IAACGDQgAA3/QCAAADJ4IAABaWAgAAGk/A= Date: Mon, 18 Mar 2019 20:35:02 +0000 Message-ID: References: <20190314150945.031d1b08@cakuba.netronome.com> <20190314163915.24fd2481@cakuba.netronome.com> <4436da3d-4b99-f792-8e77-695d5958794d@intel.com> <20190315200814.GD2305@nanopsycho> <20190318122105.GH2270@nanopsycho> <20190318123634.6e90c043@cakuba.netronome.com> <20190318125935.580c8fbe@cakuba.netronome.com> In-Reply-To: <20190318125935.580c8fbe@cakuba.netronome.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=parav@mellanox.com; x-originating-ip: [208.176.44.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 27ad254e-062d-4817-bd24-08d6abe13271 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR0501MB2575; x-ms-traffictypediagnostic: VI1PR0501MB2575: x-microsoft-antispam-prvs: x-forefront-prvs: 098076C36C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(396003)(136003)(366004)(39860400002)(346002)(13464003)(189003)(199004)(53546011)(8676002)(6506007)(256004)(105586002)(478600001)(316002)(25786009)(74316002)(8936002)(53936002)(68736007)(33656002)(14454004)(86362001)(6916009)(7736002)(76176011)(106356001)(97736004)(81156014)(26005)(93886005)(102836004)(81166006)(186003)(2906002)(6246003)(561944003)(305945005)(7696005)(52536014)(229853002)(476003)(11346002)(486006)(5660300002)(4326008)(3846002)(6116002)(71200400001)(54906003)(71190400001)(66066001)(55016002)(446003)(99286004)(6436002)(9686003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0501MB2575;H:VI1PR0501MB2271.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: E1VMfh8iG5Sozpu7bhQjhKD3SDmF19eGsuel6yb0GxY4gg1HYC2kT0zTNx2b1m3j7CI/8P85i5BN4iw5fKldExiwduWSa2w6RZbV5FOjZSeB3gD/OfUTmbrXHogIENUZlap8AR5nKA3Wvh/Uh8tudUIeG8lTt5d1y4atikbkzZW4TQAKbR3XbEyRU/AwAbJRRcrY6ZBMa8gTZQDA2uJ4GEzHalFUTU3RASXexkAHQJMCBV98pFpl4IPO42eL7xOdJ9jQXMHsDyDmVCIPQFA1k00p04hSePtmngwjGbFnOml7LnrFwmGbU7ttkldHQj3x+oZw2MQUeio7LSlOUS45BBc/+8xOBKwL6Ec8x69ic6bbUJ91MbFzBdZbPV/h0+Lr44dtaXbCsYor0DIK4oGmQUD52OJ/qP8e0WhKLHvTXKk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27ad254e-062d-4817-bd24-08d6abe13271 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2019 20:35:02.0839 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2575 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Jakub Kicinski > Sent: Monday, March 18, 2019 3:00 PM > To: Parav Pandit > Cc: Jiri Pirko ; Samudrala, Sridhar > ; davem@davemloft.net; > netdev@vger.kernel.org; oss-drivers@netronome.com > Subject: RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink P= CI > ports >=20 > On Mon, 18 Mar 2019 19:44:21 +0000, Parav Pandit wrote: > > > -----Original Message----- > > > From: Jakub Kicinski > > > Sent: Monday, March 18, 2019 2:37 PM > > > To: Parav Pandit > > > Cc: Jiri Pirko ; Samudrala, Sridhar > > > ; davem@davemloft.net; > > > netdev@vger.kernel.org; oss-drivers@netronome.com > > > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > > > devlink PCI ports > > > > > > On Mon, 18 Mar 2019 16:22:33 +0000, Parav Pandit wrote: > > > >>>>>>2. flavour should not be vf/pf, flavour should be hostport, > switchport. > > > >>> >Because switch is flat and agnostic of pf/vf/mdev. > > > >>>>> > > > >>>>> Not sure. It's good to have this kind of visibility. > > > >>>>> > > > >>>> port can have label/attribute indicating that this belong to > > > >>>> VF-1 or mdev as long as you are agreeing to have mdev attribute = on > host port. > > > >>>> (and not ask for abstracting it, because mdev is well defined ke= rnel > object). > > > >>> > > > >>> Why mdev cannot be another flavour? > > > >>> > > > >> > > > >> hostport is of type pf/vf/mdev connected to some switchport. > > > >> > > > >> So proposal is to have, > > > >> port flavour =3D hostport/switchport port type/label =3D pf/vf/mde= v > > > >> > > > > Instead of having two attributes per port, how about having, port > > > > flavour=3D physical/cpu/dsa/pf/vf/mdev/switchport. > > > > > > > > physical and pf has some overlapping definitions. > > > > > > What "overlapping definitions" do physical and PF have? > > PF has physically user facing port. >=20 > PF doesn't "have a user facing port" in switchdev mode. =20 Physical port described in include/uapi/linux/devlink.h as DEVLINK_PORT_FLA= VOUR_PHYSICAL is not related to switchdev or legacy mode. As the comment block describe it is 'any kind of port physical facing user'= . Current mlx5 driver doesn't expose ports as physical regardless of switchde= v/legacy mode. > It's a limitation of Mellanox HW that you have some strong association th= ere. > Not sure why you keep saying that. Any code reference that I should look at= ? Or maybe you can explain what is that limitation, because I am not aware of= any. > > And physical port in include/uapi/linux/devlink.h also describe that. >=20 > By "that" you must mean that the physical is a user facing port. Can you please describe the difference between 'PF port' and 'physical port= of include/uapi/linux/devlink.h'? I must have missed this crisp definition in discussion between you and Jiri= . I am in meantime checking the thread.