From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92081C43381 for ; Thu, 21 Mar 2019 16:50:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C39D2183E for ; Thu, 21 Mar 2019 16:50:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="PTGN/p2y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728445AbfCUQus (ORCPT ); Thu, 21 Mar 2019 12:50:48 -0400 Received: from mail-eopbgr30086.outbound.protection.outlook.com ([40.107.3.86]:22401 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727958AbfCUQus (ORCPT ); Thu, 21 Mar 2019 12:50:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6v5DySmbEdaF6abn4aoWmo2ntwdTld9dxp534p7lkmE=; b=PTGN/p2yZn+4DI6OGOMyMqI8xN3+HEePymsfQGqPzUQwoHg9xvPQcic6G1efjuGDU5huOu39nRAGy5F2r3ENXzhMhKj7FhQ26HDkSUuhrOyBj3TsjNjZM169WRitgcLbopUqIo9Uw8BFObMVIYKIC+aK23l0C1Qy4JJA4qa65kQ= Received: from VI1PR0501MB2271.eurprd05.prod.outlook.com (10.169.135.8) by VI1PR0501MB2445.eurprd05.prod.outlook.com (10.168.136.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.14; Thu, 21 Mar 2019 16:50:38 +0000 Received: from VI1PR0501MB2271.eurprd05.prod.outlook.com ([fe80::a0b8:7ed8:d657:2f59]) by VI1PR0501MB2271.eurprd05.prod.outlook.com ([fe80::a0b8:7ed8:d657:2f59%6]) with mapi id 15.20.1709.017; Thu, 21 Mar 2019 16:50:38 +0000 From: Parav Pandit To: Jiri Pirko CC: Jakub Kicinski , "Samudrala, Sridhar" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Thread-Topic: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Thread-Index: AQHU0FlVGn07mv/5S0qtfXL/6zV0naX4F3YAgACpvYCAAl2OgIABFocAgACw24CAAGdAAIABP+yAgABd4gCAAQniAIABHgoAgADJ0ICAAEdZgIAECm0AgAEiPwCAAMbcgIAAc58AgACZ0oCAAKqSgIAAAXSAgAAJR4CAAPajAIAA82GAgAAGytCAABI3gIAAHF7AgAAPYgCAAAD0MIAAPSgAgACeBbCAAE9/AIAAG6zwgAQYzoCAADlP0IAACGDQgAA3/QCAAADJ4IAABaWAgAAGk/CAABKjgIAACNIggALgFpCAACkTgIAA1dqAgABiQ4CAABVTAIAACRgw Date: Thu, 21 Mar 2019 16:50:37 +0000 Message-ID: References: <20190318123634.6e90c043@cakuba.netronome.com> <20190318125935.580c8fbe@cakuba.netronome.com> <20190318142949.36f18af4@cakuba.netronome.com> <20190320132257.372369d7@cakuba.netronome.com> <20190321090821.GB2087@nanopsycho> <20190321161622.GS2087@nanopsycho> In-Reply-To: <20190321161622.GS2087@nanopsycho> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=parav@mellanox.com; x-originating-ip: [208.176.44.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 984ad0a4-67b6-48d7-f827-08d6ae1d5868 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR0501MB2445; x-ms-traffictypediagnostic: VI1PR0501MB2445: x-microsoft-antispam-prvs: x-forefront-prvs: 0983EAD6B2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(376002)(346002)(39860400002)(366004)(396003)(189003)(199004)(13464003)(81156014)(76176011)(9686003)(25786009)(99286004)(53936002)(33656002)(229853002)(7696005)(52536014)(53546011)(478600001)(71190400001)(2906002)(186003)(81166006)(71200400001)(5024004)(54906003)(4326008)(14454004)(305945005)(66066001)(6916009)(105586002)(3846002)(6506007)(6246003)(316002)(74316002)(97736004)(26005)(5660300002)(55016002)(8676002)(6116002)(8936002)(476003)(7736002)(93886005)(6436002)(256004)(446003)(486006)(102836004)(68736007)(86362001)(11346002)(106356001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0501MB2445;H:VI1PR0501MB2271.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 7CFRVLVr1KAX/Ntwe1Q77a/Y6keKaS5td5v/EISWsMb227loE1Ldb+7cAG3jDJSNDOx8lTqhBkXIQuPRb7BkshohhHmPCdweefJl20cDXU3v1aS/DIgQa/1V/lv6a4IG68xyJsXFN9/tIdlxAUy5AR5WnggYrBhooZZ7FZ2fXFM6AichBXVQ30piKrxddgLzl6b4u0vd6iqvHmFlGkR6vBSoj+paEYDJXzPwKIaWoiiCpl0ZrFOxfhtzej1OsSZRvdVKlEDIifc8wSJ+ji3BctYBChIq734C0AV5xQf3zLL2aH9HL5ykyJ1LvbM679QUQH6LIuR7+UrhYs7gKwUmKTsSNcNqt7MYiLM//FDP1P1K17ciItgoPSLcS+4dCUSTxRpx6r7OJ0KoobC6H1JBMuT/1vBqgkw8eMDtW6PvBN4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 984ad0a4-67b6-48d7-f827-08d6ae1d5868 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2019 16:50:37.9152 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2445 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Jiri Pirko > Sent: Thursday, March 21, 2019 11:16 AM > To: Parav Pandit > Cc: Jakub Kicinski ; Samudrala, Sridhar > ; davem@davemloft.net; > netdev@vger.kernel.org; oss-drivers@netronome.com > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink P= CI > ports >=20 > Thu, Mar 21, 2019 at 04:03:58PM CET, parav@mellanox.com wrote: > >Hi Jiri, > > > >> -----Original Message----- > >> From: Jiri Pirko > >> Sent: Thursday, March 21, 2019 4:08 AM > >> To: Jakub Kicinski > >> Cc: Parav Pandit ; Samudrala, Sridhar > >> ; davem@davemloft.net; > >> netdev@vger.kernel.org; oss-drivers@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >> Wed, Mar 20, 2019 at 09:22:57PM CET, jakub.kicinski@netronome.com > >> wrote: > >> >On Wed, 20 Mar 2019 18:24:15 +0000, Parav Pandit wrote: > >> >> Hi Jiri, Jakub, Samudrala Sridhar, > >> >> > > > > > And physical port in include/uapi/linux/devlink.h also > >> >> > > > > > describe that. > >> >> > > > > > >> >> > > > > By "that" you must mean that the physical is a user facing = port. > >> >> > > > > >> >> > > > Can you please describe the difference between 'PF port' and > >> >> > > > 'physical port of include/uapi/linux/devlink.h'? I must have > >> >> > > > missed this crisp definition in discussion between you and > >> >> > > > Jiri. I am in meantime checking the thread. > >> >> > > > >> >> > > Perhaps start with the cover letter which includes an ASCII > drawing? > >> >> > > > >> >> > > Using Mellanox nomenclature - PF port is a "representor" for > >> >> > > the PF which may be on another Host (SmartNIC or multihost). > >> >> > > It's pretty much the same thing as a VF port/"representor". > >> >> > > > >> >> > Yes. We are aligned here. :-) > >> >> > I see your point, where in multi-host scenario, a physical port > >> >> > may be 1, but PF ports are 4, because of 4 PFs for 4 hosts. > >> >> > (just an example of 4 hosts with their own mac address sharing 1 > >> >> > physical port). > >> >> > > >> >> > When there is no multihost and one to one mapping between a PF > >> >> > and physical links, there is some overlap between PF port and > >> >> > physical port attributes. > >> >> > I believe, such overlap is fine as long as we have unique > >> >> > indices for the > >> ports. > >> >> > > >> >> > So I am ok to have flavours as > physical/cpu/dsa/pf/vf/mdev/switchport. > >> >> > (last 4 as new port flavours). > >> >> > > >> >> > > Physical port is the hole on the panel of the adapter where > >> >> > > cable > >> goes. > >> >> > >> >> So my take away from above discussion are: > >> >> 1. Following new port flavours should be added > >> pci_pf/pci_vf/mdev/switchport. > >> >> a. Switchport indicates port on the eswitch. Normally this port > >> >> has rep- > >> netdev attached to it. > >> > > >> >I don't understand the "switchport". Surely physical ports are also > >> >attached to the eswitch? And one of the main purpose of adding the > >> >pci_pf/pci_vf flavours was to generate phys_port_name for the port > >> >netdevs. > >> > > >> >Please don't use the term representor if possible. Representor for > >> >most developers describes the way the netdev is implemented in the > >> >driver, so for Mellanox and Netronome different ports will be > >> >representors and non-representors. That's why I prefer port netdev > >> >(attached to eswitch, has switch_id) and host netdev (PF/VF netdev, > >> >vNIC, VSI, etc). > >> > > >> >> b. host side port flavours are pci_pf/pci_vf/mdev which may be > >> >> connected to switchport > >> > > >> >See above, pci_pf/pci_vf are needed for phys_port_name generation. > >> > >> Yep, that makes sense. > >> > >> > >> > > >> >> 2. host side port flavours are not limited to Ethernet, as it is > >> >> for devlink's > >> port instance. > >> >> > >> >> 3. Each port is continue to be accessed using unique port index. > >> >> > >> >> 4. host side ports and switchport are control objects. > >> >> a. switch side ports reside where current eswitch object of > >> >> devlink instance reside b. for a given VF/PF/mdev such host side > >> >> ports may be in hypervisor or VM or both depending on the > >> >> privilege > >> >> > >> >> 5. eth.mac_address, rdma.port_guid can be programmed at host port > >> >> flavours by extending as $ devlink port param set... > >> >> (similar to devlink dev param set) > >> > > >> >You can keep restating that's your position, but I have *not* > >> >conceded to that. > >> > >> I'm also not convinced that host dummy ports are good idea to hold > these. > >> > >> > >I didn't understand what do you mean my dummy port. >=20 > It's a port for a VF host port which is not actually in the host but in t= he vm. > Very confusing. >=20 It is the vf_ctrl flavour. I don't see it any different than rep-netdev. rep-netdev is not that confusing to us that represent eswitch vport. Why vf_ctrl flavour port that represents otherside of the pipe as you have = shown in example? Why it that confusing? > >Can you explain what is wrong in programming host port params using > host_port object? > >Few questions are unanswered in my past 2 or 3 emails. > >Can you please go through them? > >Can you point to some example switch API where you program host params > at switch? > > > >> > > >> >> 6. more host port params can be added in future when user need > >> >> arise > >> >> > >> >> 7. rep-netdev continue to be eswitch (switchport) representor at > >> >> the > >> switch side. > >> >> a. Hence rep-netdev cannot be used for programming host port's > >> parameters. > >> >> > >> >> 8. eswitch devlink instance knows when VF/PF/mdev's switchport are > >> created/removed. > >> >> Hence, those will be created/deleted by eswitch. > >> >> Similarly for host port flavours too. > >> >> > >> >> Does it look fine? Did I miss something? > >> >> We would like to progress on incremental patches for item-4 and > >> >> any prep work needed to reach to item-4.