From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74AC4C43381 for ; Sat, 23 Mar 2019 00:37:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 27F5921925 for ; Sat, 23 Mar 2019 00:37:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="Fw4qaWfG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727654AbfCWAhm (ORCPT ); Fri, 22 Mar 2019 20:37:42 -0400 Received: from mail-eopbgr60068.outbound.protection.outlook.com ([40.107.6.68]:10448 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727611AbfCWAhl (ORCPT ); Fri, 22 Mar 2019 20:37:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eMY45Bd31/Pyfxl7nOgqcdvaW5b5GIlaUuK0TbuHsTI=; b=Fw4qaWfGf8L8V/NLzp9BaL7CaSHBt8vZJOk+2iqZJz0Hg4iLBAmHrBFTWHapoSSo2MjM8xeSymdQldSy9UylgMrIsjK4bORDrSjrt7ukGZddyZAKDvHVpupeAaM6pSooV6PFEgVtholpJAwzPYYzO0MhXI+VdvsMA6kIRtg36mA= Received: from VI1PR0501MB2271.eurprd05.prod.outlook.com (10.169.135.8) by VI1PR0501MB2575.eurprd05.prod.outlook.com (10.168.137.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.14; Sat, 23 Mar 2019 00:37:36 +0000 Received: from VI1PR0501MB2271.eurprd05.prod.outlook.com ([fe80::a0b8:7ed8:d657:2f59]) by VI1PR0501MB2271.eurprd05.prod.outlook.com ([fe80::a0b8:7ed8:d657:2f59%6]) with mapi id 15.20.1730.017; Sat, 23 Mar 2019 00:37:35 +0000 From: Parav Pandit To: Jiri Pirko CC: Jakub Kicinski , "Samudrala, Sridhar" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Thread-Topic: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Thread-Index: AQHU0FlVGn07mv/5S0qtfXL/6zV0naX4F3YAgACpvYCAAl2OgIABFocAgACw24CAAGdAAIABP+yAgABd4gCAAQniAIABHgoAgADJ0ICAAEdZgIAECm0AgAEiPwCAAMbcgIAAc58AgACZ0oCAAKqSgIAAAXSAgAAJR4CAAPajAIAA82GAgAAGytCAABI3gIAAHF7AgAAPYgCAAAD0MIAAPSgAgACeBbCAAE9/AIAACj8AgAQnqgCAAHawAIAEBp8AgABqKuCAABNDgIAACibwgAAIWgCAAAMpIIABgF8AgACI1kA= Date: Sat, 23 Mar 2019 00:37:35 +0000 Message-ID: References: <20190315200814.GD2305@nanopsycho> <20190315134454.581f47ca@cakuba.netronome.com> <20190318121154.GG2270@nanopsycho> <20190318121642.74a56b7e@cakuba.netronome.com> <20190321084526.GA2087@nanopsycho> <20190321161421.GR2087@nanopsycho> <20190321172034.GW2087@nanopsycho> <20190322162736.GE2211@nanopsycho> In-Reply-To: <20190322162736.GE2211@nanopsycho> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=parav@mellanox.com; x-originating-ip: [2605:6000:ec80:6500:6130:5c73:d296:d351] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ddc42f98-8f1d-4269-db5a-08d6af27bed6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR0501MB2575; x-ms-traffictypediagnostic: VI1PR0501MB2575: x-microsoft-antispam-prvs: x-forefront-prvs: 0985DA2459 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(136003)(396003)(39860400002)(366004)(346002)(189003)(199004)(13464003)(52536014)(5660300002)(316002)(229853002)(93886005)(478600001)(6246003)(53936002)(71190400001)(86362001)(71200400001)(25786009)(54906003)(55016002)(9686003)(97736004)(6436002)(33656002)(4326008)(6916009)(8676002)(81166006)(81156014)(476003)(7736002)(106356001)(305945005)(8936002)(14454004)(6116002)(105586002)(68736007)(46003)(7696005)(76176011)(6506007)(53546011)(186003)(99286004)(102836004)(2906002)(486006)(446003)(11346002)(74316002)(256004);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0501MB2575;H:VI1PR0501MB2271.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: CGoIqfC640GYhWUzqdbGbUR7I9e4T98rYdA54NV/nlyISL94Ut+nJl2syNg00JTz+hdR1iVk1LjGAJY3YMYJYchoH/BwLMud651SzuZT7fFX/HXMob2FmRuFDmQevKDV//RxIPad6T9EoJbI4+7ZuhWjCAbyRJmfaPFVaYVuQhpTwfFtuGJS++ysoz1L3KqHKl7Rq/TmbvwqjlPIPSqMlpAVqO5Ig3nsdC7pOjlvUMAazt4m3G4Vb0WGzvMfqfYLK4pl4FXUEm2pXEq7u97CGMj9fkGqJcGQFGndAey08Lq5fSFYRROYfhK4T2wWG/XfDOb5gRrGXXNz4zCQDPNqmcgSPz8k81NKx51v50KT5MAMD/urSabZwxcNB+mAShkjxSRmUHN4o+K8LkZ6qM+y5RXncGQIC2mzgi1yBEPaNAg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddc42f98-8f1d-4269-db5a-08d6af27bed6 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2019 00:37:35.8710 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2575 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Jiri Pirko > Sent: Friday, March 22, 2019 11:28 AM > To: Parav Pandit > Cc: Jakub Kicinski ; Samudrala, Sridhar > ; davem@davemloft.net; > netdev@vger.kernel.org; oss-drivers@netronome.com > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink P= CI > ports >=20 > Thu, Mar 21, 2019 at 06:34:22PM CET, parav@mellanox.com wrote: > > > > > >> -----Original Message----- > >> From: Jiri Pirko > >> Sent: Thursday, March 21, 2019 12:21 PM > >> To: Parav Pandit > >> Cc: Jakub Kicinski ; Samudrala, Sridhar > >> ; davem@davemloft.net; > >> netdev@vger.kernel.org; oss-drivers@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >> Thu, Mar 21, 2019 at 05:52:09PM CET, parav@mellanox.com wrote: > >> > > >> > > >> >> -----Original Message----- > >> >> From: Jiri Pirko > >> >> Sent: Thursday, March 21, 2019 11:14 AM > >> >> To: Parav Pandit > >> >> Cc: Jakub Kicinski ; Samudrala, > >> >> Sridhar ; davem@davemloft.net; > >> >> netdev@vger.kernel.org; oss-drivers@netronome.com > >> >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> >> devlink PCI ports > >> >> > >> >> Thu, Mar 21, 2019 at 04:14:53PM CET, parav@mellanox.com wrote: > >> >> > > >> >> > > >> >> >> -----Original Message----- > >> >> >> From: Jiri Pirko > >> >> >> Sent: Thursday, March 21, 2019 3:45 AM > >> >> >> To: Jakub Kicinski > >> >> >> Cc: Parav Pandit ; Samudrala, Sridhar > >> >> >> ; davem@davemloft.net; > >> >> >> netdev@vger.kernel.org; oss-drivers@netronome.com > >> >> >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> >> >> devlink PCI ports > >> >> >> > >> >> >> Mon, Mar 18, 2019 at 08:16:42PM CET, > >> >> >> jakub.kicinski@netronome.com > >> >> >> wrote: > >> >> >> >On Mon, 18 Mar 2019 13:11:54 +0100, Jiri Pirko wrote: > >> >> >> >> >> >2. flavour should not be vf/pf, flavour should be > >> >> >> >> >> >hostport, > >> >> switchport. > >> >> >> >> >> >Because switch is flat and agnostic of pf/vf/mdev. > >> >> >> >> >> > >> >> >> >> >> Not sure. It's good to have this kind of visibility. > >> >> >> >> > > >> >> >> >> >Yes, this subthread honestly makes me go from 60% sure to > >> >> >> >> >95% sure we shouldn't do the dual object thing :( Seems > >> >> >> >> >like Parav is already confused by it and suggests host port > >> >> >> >> >can exist without switch port :( > >> >> >> >> > >> >> >> >> Although I understand your hesitation, the host ports are > >> >> >> >> also associated with the asic and should be under the devlink > instance. > >> >> >> >> It is just a matter of proper documentation and clear code > >> >> >> >> to avoid confusions. > >> >> >> > > >> >> >> >They are certainly a part and belong to the ASIC, the question > >> >> >> >in my mind is more along the lines of do we want "one pipe/one > port" > >> >> >> >or is it okay to have multiple software objects of the same > >> >> >> >kind for those objects. > >> >> >> > > >> >> >> >To put it differently - do want a port object for each port of > >> >> >> >the ASIC or do we want a port object for each netdev.. > >> >> >> > >> >> >> Perhaps "port" name of the object is misleading. From the > >> >> >> beginning, I ment to have it for both switch ports and host port= s. > >> >> >> I admit that "host port" is a bit misleading, as it is not > >> >> >> really a port of eswitch, but the counter part. But if we > >> >> >> introduce another object for that purpose in devlink (like > >> >> >> "partititon"), it would be a lot of duplication > >> >> I think. > >> >> >> > >> >> >> Question is, do we need the "host port"? Can't we just put a > >> >> >> relation to host netdev in the eswitch port. > >> >> >> > >> >> >Can you please explain how does it work for rdma for non sriov > >> >> >use > >> case? > >> >> >Do we have to create a fake eswitch object? > >> >> > >> >> Could you please provide details on "rdma for non sriov use case"? > >> >> > >> >There are multiple mdevs on PFs that happen to have link layer as IB > >> >and > >> those devlink instances have port that deserved to be configured same > >> way as that of Eth. > >> > >> Could you please describe it a bit more. There is still an eswitch > >> through which the traffic is going, isn't it? > >Yes, there is an eswitch but it doesn't have switch side of vports. >=20 > Why? They should have. >=20 It doesn't have. >=20 > >It is equivalent to legacy mode. > >I hope you are not thinking to create fake eswitch vports. :-)