From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9156C43381 for ; Thu, 21 Mar 2019 16:52:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CA9521902 for ; Thu, 21 Mar 2019 16:52:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="HImsDcQ7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728498AbfCUQwO (ORCPT ); Thu, 21 Mar 2019 12:52:14 -0400 Received: from mail-eopbgr30068.outbound.protection.outlook.com ([40.107.3.68]:37764 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727844AbfCUQwN (ORCPT ); Thu, 21 Mar 2019 12:52:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mW9acJ0eiLlk/CNCIg98gVd0m21ooHN2zMAydPeeUbI=; b=HImsDcQ7hR76gXJqjLm4NMS5bbckxySOhCP0qZrZjD9HrnP8yJzZztDlw/G9MEeeH/QLRBzTEJzAm+zBfW2ZcRa1H+aB60UTOTvBjREHxd+c3gmzuH7KG3lyGcI6UrpvNRuCxuEEu/mPkJu/wJyGz+NXLzu3qn/dDz+Kn/zjyIY= Received: from VI1PR0501MB2271.eurprd05.prod.outlook.com (10.169.135.8) by VI1PR0501MB2445.eurprd05.prod.outlook.com (10.168.136.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.14; Thu, 21 Mar 2019 16:52:09 +0000 Received: from VI1PR0501MB2271.eurprd05.prod.outlook.com ([fe80::a0b8:7ed8:d657:2f59]) by VI1PR0501MB2271.eurprd05.prod.outlook.com ([fe80::a0b8:7ed8:d657:2f59%6]) with mapi id 15.20.1709.017; Thu, 21 Mar 2019 16:52:09 +0000 From: Parav Pandit To: Jiri Pirko CC: Jakub Kicinski , "Samudrala, Sridhar" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Thread-Topic: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Thread-Index: AQHU0FlVGn07mv/5S0qtfXL/6zV0naX4F3YAgACpvYCAAl2OgIABFocAgACw24CAAGdAAIABP+yAgABd4gCAAQniAIABHgoAgADJ0ICAAEdZgIAECm0AgAEiPwCAAMbcgIAAc58AgACZ0oCAAKqSgIAAAXSAgAAJR4CAAPajAIAA82GAgAAGytCAABI3gIAAHF7AgAAPYgCAAAD0MIAAPSgAgACeBbCAAE9/AIAACj8AgAQnqgCAAHawAIAEBp8AgABqKuCAABNDgIAACibw Date: Thu, 21 Mar 2019 16:52:09 +0000 Message-ID: References: <4436da3d-4b99-f792-8e77-695d5958794d@intel.com> <20190315200814.GD2305@nanopsycho> <20190315134454.581f47ca@cakuba.netronome.com> <20190318121154.GG2270@nanopsycho> <20190318121642.74a56b7e@cakuba.netronome.com> <20190321084526.GA2087@nanopsycho> <20190321161421.GR2087@nanopsycho> In-Reply-To: <20190321161421.GR2087@nanopsycho> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=parav@mellanox.com; x-originating-ip: [208.176.44.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e4445e68-39ff-4b67-ca61-08d6ae1d8ed0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR0501MB2445; x-ms-traffictypediagnostic: VI1PR0501MB2445: x-microsoft-antispam-prvs: x-forefront-prvs: 0983EAD6B2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(376002)(346002)(39860400002)(366004)(396003)(189003)(199004)(13464003)(81156014)(76176011)(9686003)(25786009)(99286004)(53936002)(33656002)(229853002)(7696005)(52536014)(53546011)(478600001)(71190400001)(2906002)(186003)(81166006)(71200400001)(54906003)(4326008)(14454004)(305945005)(66066001)(6916009)(105586002)(3846002)(6506007)(6246003)(316002)(74316002)(97736004)(26005)(5660300002)(55016002)(8676002)(6116002)(8936002)(476003)(7736002)(93886005)(6436002)(256004)(446003)(486006)(102836004)(68736007)(86362001)(11346002)(106356001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0501MB2445;H:VI1PR0501MB2271.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: zZ1pBTwFBC33GnYjm5JGiuw0OC7I7RLi/sBo0WP9kGJDJVy6TScJ9RRwxRPVzQrz+29l//SpbDgUEuvVOXCpOkSdUdH71Sgy1bTGZaHawEWbipzdKMolcAYLBgA8gh/KwkpAbu8TQpVzHtq6S4j9AyfhIbzGucYf1xbcZppjLlzGB+2z+hk3pK+Ye85y5QXZuNyu6grolQF6w6hNY+DhotwZwmXE+1LHEMgjQ920XEJSKhjyRqPmJf0CKJaxIP+EtywIh7nX9si/eu5RKcVfgshmUCcIsRBTNEaUadmn+9Bjor81XPpPv7ybu/T4T2vkTLBoz/BiYGqSmYgXwLUnAC/Nbj/98JhEaVuPO2i8Jng4E1+mf+0cQBFpQytAjbBgOhIrCip9B9wVeEhqig2yimy63Fc2phuAANjQ6oWcGRE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4445e68-39ff-4b67-ca61-08d6ae1d8ed0 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2019 16:52:09.2055 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2445 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Jiri Pirko > Sent: Thursday, March 21, 2019 11:14 AM > To: Parav Pandit > Cc: Jakub Kicinski ; Samudrala, Sridhar > ; davem@davemloft.net; > netdev@vger.kernel.org; oss-drivers@netronome.com > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink P= CI > ports >=20 > Thu, Mar 21, 2019 at 04:14:53PM CET, parav@mellanox.com wrote: > > > > > >> -----Original Message----- > >> From: Jiri Pirko > >> Sent: Thursday, March 21, 2019 3:45 AM > >> To: Jakub Kicinski > >> Cc: Parav Pandit ; Samudrala, Sridhar > >> ; davem@davemloft.net; > >> netdev@vger.kernel.org; oss-drivers@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >> Mon, Mar 18, 2019 at 08:16:42PM CET, jakub.kicinski@netronome.com > >> wrote: > >> >On Mon, 18 Mar 2019 13:11:54 +0100, Jiri Pirko wrote: > >> >> >> >2. flavour should not be vf/pf, flavour should be hostport, > switchport. > >> >> >> >Because switch is flat and agnostic of pf/vf/mdev. > >> >> >> > >> >> >> Not sure. It's good to have this kind of visibility. > >> >> > > >> >> >Yes, this subthread honestly makes me go from 60% sure to 95% > >> >> >sure we shouldn't do the dual object thing :( Seems like Parav > >> >> >is already confused by it and suggests host port can exist > >> >> >without switch port :( > >> >> > >> >> Although I understand your hesitation, the host ports are also > >> >> associated with the asic and should be under the devlink instance. > >> >> It is just a matter of proper documentation and clear code to > >> >> avoid confusions. > >> > > >> >They are certainly a part and belong to the ASIC, the question in my > >> >mind is more along the lines of do we want "one pipe/one port" or is > >> >it okay to have multiple software objects of the same kind for those > >> >objects. > >> > > >> >To put it differently - do want a port object for each port of the > >> >ASIC or do we want a port object for each netdev.. > >> > >> Perhaps "port" name of the object is misleading. From the beginning, > >> I ment to have it for both switch ports and host ports. I admit that > >> "host port" is a bit misleading, as it is not really a port of > >> eswitch, but the counter part. But if we introduce another object for > >> that purpose in devlink (like "partititon"), it would be a lot of dupl= ication > I think. > >> > >> Question is, do we need the "host port"? Can't we just put a relation > >> to host netdev in the eswitch port. > >> > >Can you please explain how does it work for rdma for non sriov use case? > >Do we have to create a fake eswitch object? >=20 > Could you please provide details on "rdma for non sriov use case"? >=20 There are multiple mdevs on PFs that happen to have link layer as IB and th= ose devlink instances have port that deserved to be configured same way as = that of Eth.