From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matan Azrad Subject: Re: [PATCH v2 1/3] net/ixgbe: enable hotplug detect in ixgbe Date: Mon, 9 Jul 2018 07:51:27 +0000 Message-ID: References: <1530787185-5915-1-git-send-email-jia.guo@intel.com> <1531119413-17298-1-git-send-email-jia.guo@intel.com> <1531119413-17298-2-git-send-email-jia.guo@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B800FC5@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "jblunck@infradead.org" , "shreyansh.jain@nxp.com" , "dev@dpdk.org" , "Guo, Jia" , "Zhang, Helin" To: "Lu, Wenzhuo" , "Guo, Jia" , "stephen@networkplumber.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "gaetan.rivet@6wind.com" , "Wu, Jingjing" , Thomas Monjalon , Mordechay Haimovsky , "Van Haaren, Harry" , "Zhang, Qi Z" , "He, Shaopeng" , "Iremonger, Bernard" , "arybchenko@solarflare.com" Return-path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60064.outbound.protection.outlook.com [40.107.6.64]) by dpdk.org (Postfix) with ESMTP id 14A895F29 for ; Mon, 9 Jul 2018 09:51:31 +0200 (CEST) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B800FC5@shsmsx102.ccr.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi From: Lu, Wenzhuo > Hi Jeff, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jeff Guo > > Sent: Monday, July 9, 2018 2:57 PM > > To: stephen@networkplumber.org; Richardson, Bruce > > ; Yigit, Ferruh ; > > Ananyev, Konstantin ; > > gaetan.rivet@6wind.com; Wu, Jingjing ; > > thomas@monjalon.net; motih@mellanox.com; matan@mellanox.com; > Van > > Haaren, Harry ; Zhang, Qi Z > > ; He, Shaopeng ; > > Iremonger, Bernard ; > > arybchenko@solarflare.com > > Cc: jblunck@infradead.org; shreyansh.jain@nxp.com; dev@dpdk.org; Guo, > > Jia ; Zhang, Helin > > Subject: [dpdk-dev] [PATCH v2 1/3] net/ixgbe: enable hotplug detect in > > ixgbe > > > > This patch aim to enable hotplug detect in ixgbe pmd driver. Firstly > > it set the flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the > > hotplug ability, and then use rte_dev_event_callback_register to > > register the hotplug event callback to eal. When eal detect the > > hotplug event, it will call the callback to process it, if the event > > is hotplug remove, it will trigger the RTE_ETH_EVENT_INTR_RMV event > > into ethdev callback to let app process the hotplug for the ethdev. > > > > This is an example for other driver, that if any driver support > > hotplug feature could be use this way to enable hotplug detect. > > > > Signed-off-by: Jeff Guo > > --- > > v2->v1: > > refine some doc. > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 46 > > +++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 45 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index 87d2ad0..83ce026 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -1534,6 +1534,47 @@ generate_random_mac_addr(struct ether_addr > > *mac_addr) > > memcpy(&mac_addr->addr_bytes[3], &random, 3); } > > > > +static void > > +eth_dev_event_callback(char *device_name, enum rte_dev_event_type > > type, > > + __rte_unused void *arg) > > +{ > > + uint32_t pid; > > + > > + if (type >=3D RTE_DEV_EVENT_MAX) { > > + fprintf(stderr, "%s called upon invalid event %d\n", > > + __func__, type); > > + fflush(stderr); > > + } > > + > > + switch (type) { > > + case RTE_DEV_EVENT_REMOVE: > > + PMD_DRV_LOG(INFO, "The device: %s has been > removed!\n", > > + device_name); > > + > > + if (!device_name) > > + return; > > + > > + for (pid =3D 0; pid < RTE_MAX_ETHPORTS; pid++) { > > + if (rte_eth_devices[pid].device) { > > + if (!strcmp(device_name, > > + rte_eth_devices[pid].device->name)) { > > + _rte_eth_dev_callback_process( > > + &rte_eth_devices[pid], > > + RTE_ETH_EVENT_INTR_RMV, > > NULL); > > + continue; > > + } > > + } > > + } > > + break; > > + case RTE_DEV_EVENT_ADD: > > + RTE_LOG(INFO, EAL, "The device: %s has been added!\n", > > + device_name); > > + break; > > + default: > > + break; > > + } > > +} > I don't get the point. Looks like this's a very common rte code. Why is i= t put in > ixgbe pmd? Jeff needs to detect if the removed device is related to this PMD, than to = raise RMV events for all this PMD ethdev associated ports.=20 He should not raise RMV events for other PMD ports.