From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matan Azrad Subject: Re: [PATCH V4 8/9] app/testpmd: show example to handle hot unplug Date: Wed, 4 Jul 2018 07:06:15 +0000 Message-ID: References: <1498711073-42917-1-git-send-email-jia.guo@intel.com> <07fb8f04-adee-fd0e-05b5-8d1bcca1338d@intel.com> <2612071.aGzFhBPpOt@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "stephen@networkplumber.org" , "bruce.richardson@intel.com" , "ferruh.yigit@intel.com" , "konstantin.ananyev@intel.com" , "gaetan.rivet@6wind.com" , "jingjing.wu@intel.com" , Mordechay Haimovsky , "harry.van.haaren@intel.com" , "qi.z.zhang@intel.com" , "shaopeng.he@intel.com" , "bernard.iremonger@intel.com" , "shreyansh.jain@nxp.com" , "helin.zhang@intel.com" To: Thomas Monjalon , "Guo, Jia" Return-path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30064.outbound.protection.outlook.com [40.107.3.64]) by dpdk.org (Postfix) with ESMTP id 8EFC21B4BC for ; Wed, 4 Jul 2018 09:06:18 +0200 (CEST) In-Reply-To: <2612071.aGzFhBPpOt@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, Guo From: Thomas Monjalon > 03/07/2018 11:35, Guo, Jia: > > On 7/1/2018 3:46 PM, Matan Azrad wrote: > > > From: Jeff Guo > > >> --- a/app/test-pmd/testpmd.c > > >> +++ b/app/test-pmd/testpmd.c > > >> @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char > *device_name, > > >> enum rte_dev_event_type type, > > >> case RTE_DEV_EVENT_REMOVE: > > >> RTE_LOG(ERR, EAL, "The device: %s has been removed!\n", > > >> device_name); > > >> - /* TODO: After finish failure handle, begin to stop > > >> - * packet forward, stop port, close port, detach port. > > >> - */ > > >> + ret =3D rte_eth_dev_get_port_by_name(device_name, > &port_id); > > > As you probably know, 1 rte_device may be associated to more than one > ethdev ports, so the ethdev port name can be different from rte_device > name. > > > Looks like we need a new ethdev API to get all the ports associated t= o > one rte_device. > > > > agree, seems that the the old ethdev API have some issue when got all > > port by device name. we could check with ethdev maintainer and fix it > > by specific ethdev patch later. >=20 > This ethdev function could return an error if several ports match. >=20 Just to clarify: The ethdev name may be different from the rte_device name of a port, The rte_eth_dev_get_port_by_name() searches the ethdev name and not the rte= _device name. > Ideally, we should not use this function at all. > If you want to manage an ethdev port, why are you using an EAL event? > There is an ethdev callback mechanism for port removal. So, looks like the EAL event should trigger an ethdev event for all the por= ts associated to this rte_device. I think that the best one to do it is the PMD, so maybe the PMD(which wants= to support hot unplug) should register to the EAL event and to trigger an = ethdev RMV event from the EAL callback. What do you think? =20