From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-he1eur01on0056.outbound.protection.outlook.com ([104.47.0.56]:33784 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750968AbeB1HVa (ORCPT ); Wed, 28 Feb 2018 02:21:30 -0500 From: Yuval Mintz To: Jiri Pirko , Jakub Kicinski CC: Ido Schimmel , Jiri Benc , "Ido Schimmel" , "netdev@vger.kernel.org" , "davem@davemloft.net" , "Jiri Pirko" , "dsahern@gmail.com" , mlxsw Subject: RE: [PATCH net-next] team: Use extack to report enslavement failures Date: Wed, 28 Feb 2018 07:21:26 +0000 Message-ID: References: <20180227153808.10740-1-idosch@mellanox.com> <20180227204235.7d4ab738@redhat.com> <20180227202212.GA14835@splinter> <20180227154959.47c80d57@cakuba.netronome.com> <20180228071241.GC19654@nanopsycho> In-Reply-To: <20180228071241.GC19654@nanopsycho> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org List-ID: > >> > If so, for how long? They should certainly be removed eventually. Ho= w > >> > do we ensure we don't forget? > >> > > >> > Seems to me it would be better to remove them right now. > >> > >> I can do that unless someone objects. > > > >I don't object, but FWIW keep in mind extack errors don't show if > >libmnl is not installed.. >=20 > Yeah, or if you have an older iproute2 package. I would keep the existing > dmesg msgs for now. In the future, when everyone is used to exacks, then > we can remove them. Perhaps it makes sense to introduce netdev_nl_err_msg(dev, extack, msg) that would do both today and refactor the code to use it? Later it could be changed to do only NL_SET_ERR_MSG.