Re: [dpdk-dev] [PATCH] ethdev: support flow aging

[Bill Zhou <dongz@mellanox.com>]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, April 10, 2020 6:14 PM
> To: Bill Zhou <dongz@mellanox.com>
> Cc: Matan Azrad <matan@mellanox.com>; Ori Kam <orika@mellanox.com>;
> wenzhuo.lu@intel.com; jingjing.wu@intel.com;
> bernard.iremonger@intel.com; john.mcnamara@intel.com;
> marko.kovacevic@intel.com; ferruh.yigit@intel.com;
> arybchenko@solarflare.com; dev@dpdk.org
> Subject: Re: [PATCH] ethdev: support flow aging
> 
> 10/04/2020 11:46, BillZhou:
> > One of the reasons to destroy a flow is the fact that no packet
> > matches the flow for "timeout" time.
> > For example, when TCP\UDP sessions are suddenly closed.
> >
> > Currently, there is no any DPDK mechanism for flow aging and the
> > applications use their own ways to detect and destroy aged-out flows.
> >
> > The flow aging implementation need include:
> > - A new rte_flow action: RTE_FLOW_ACTION_TYPE_AGE to set the
> timeout and
> >   the application flow context for each flow.
> > - A new ethdev event: RTE_ETH_EVENT_FLOW_AGED for the driver to
> report
> >   that there are new aged-out flows.
> > - A new rte_flow API: rte_flow_get_aged_flows to get the aged-out flows
> >   contexts from the port.
> > - Support input flow aging command line in Testpmd.
> >
> > Signed-off-by: BillZhou <dongz@mellanox.com>
> 
> I think you should insert a space in your name: Bill Zhou.
> I find strange to associate "Bill Zhou" with "dongz" in your email.
> Are you sure you don't want to mention "Dong"?

Thanks for your mention, it's will be updated in the latter patches.
> 
> 
> > +  * Added support for flow Aging mechanism base on counter.
> 
> Aging -> aging
> base -> based
> counter -> hardware counter?

For Mellanox mlx5 driver, flow aging is based on hardware counter update.
But for this patch, it's not include this support, so remove this line.
>