All of lore.kernel.org
 help / color / mirror / Atom feed
From: parav@mellanox.com (Parav Pandit)
Subject: [PATCH] nvmet: Do not check for sg_cnt being zero for	read/write commands.
Date: Wed, 8 Feb 2017 15:11:12 +0000	[thread overview]
Message-ID: <VI1PR0502MB300881F12D7D38A247990A4AD1420@VI1PR0502MB3008.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20170208082426.GA7629@lst.de>


> -----Original Message-----
> From: Christoph Hellwig [mailto:hch at lst.de]
> Sent: Wednesday, February 8, 2017 2:24 AM
> To: Parav Pandit <parav at mellanox.com>
> Cc: hch at lst.de; sagi at grimberg.me; linux-nvme at lists.infradead.org
> Subject: Re: [PATCH] nvmet: Do not check for sg_cnt being zero for
> read/write commands.
> 
> On Tue, Feb 07, 2017@05:35:57PM -0600, Parav Pandit wrote:
> > sg_cnt cannot be zero for inline or sge mode from the fabric drivers
> > because nvme read/write commands have minimum of one block to be
> read
> > or written. (nlb dw12 is 0 based value).
> > So sg_cnt check for 0 is not useful.
> 
> Except that we currently don't verify the data transfer in the SGL matches
> that in the command.  It's been on my todo list for a while, so maybe you can
> take it off my plate first before we'll aply this patch.

Yes. I hit an error when there was a mismatch between nlba and sge length.
That check is needed to fail the nvme requests. I will post that patch soon.

  parent reply	other threads:[~2017-02-08 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 23:35 [PATCH] nvmet: Do not check for sg_cnt being zero for read/write commands Parav Pandit
2017-02-08  8:24 ` Christoph Hellwig
2017-02-08  9:43   ` Sagi Grimberg
2017-02-08 11:54     ` Christoph Hellwig
2017-02-08 15:11   ` Parav Pandit [this message]
2017-02-08 20:06   ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0502MB300881F12D7D38A247990A4AD1420@VI1PR0502MB3008.eurprd05.prod.outlook.com \
    --to=parav@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.