From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shahaf Shuler Subject: Re: [PATCH v3] net/mlx4: fix dev rmv not detected after port stop Date: Mon, 29 Jan 2018 10:54:16 +0000 Message-ID: References: <1516357009-15463-1-git-send-email-motih@mellanox.com> <1517214877-126768-1-git-send-email-motih@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "stable@dpdk.org" To: Mordechay Haimovsky , Adrien Mazarguil Return-path: In-Reply-To: <1517214877-126768-1-git-send-email-motih@mellanox.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Mordechay Haimovsky, Monday, January 29, 2018 10:35 AM: > In failsafe device start can be called for ports/devices that had been pl= ugged > out. > The mlx4 PMD detects device removal by listening to the device RMV events= , > when the mlx4 port is being stopped, the PMD no longer listens to these > events causing the PMD to stop detecting device removals. > This patch fixes this issue by moving installation of the interrupt handl= er to > device configuration, and toggle only the Rx-queue interrupts on start/st= op. >=20 > Fixes: a6e8b01c3c26 ("net/mlx4: compact interrupt functions") > Cc: stable@dpdk.org >=20 > Signed-off-by: Moti Haimovsky > --- > V3: > Modifications according to review inputs from Shahaf Shuler > See: 1516357009-15463-1-git-send-email-motih@mellanox.com >=20 > V2: > Fixed commit message. > --- >=20 > drivers/net/mlx4/mlx4.c | 10 ++++++++-- > drivers/net/mlx4/mlx4.h | 2 ++ > drivers/net/mlx4/mlx4_intr.c | 41 > ++++++++++++++++++++++++++++++++++++++--- > 3 files changed, 48 insertions(+), 5 deletions(-) >=20 Acked-by: Shahaf Shuler =20 Adrien - let me know if you see issues with this patch, I want to include i= t on RC2.