Re: [PATCH v5 2/3] ethdev: introduce Tx queue offloads API

[Shahaf Shuler <shahafs@mellanox.com>]

Tuesday, October 3, 2017 10:50 PM, Ferruh Yigit:
> <...>
> 
> > @@ -620,6 +628,15 @@ Supports packet type parsing and returns a list of
> supported types.
> >
> >  .. _nic_features_timesync:
> >
> > +Mbuf fast free
> > +--------------
> 
> I think this is not one of the current tracked features. Is this coming/planed
> with new patches?

This is not a new feature, rather re-wording and merging of the flags:
ETH_TXQ_FLAGS_NOREFCOUNT
ETH_TXQ_FLAGS_NOMULTMEMP

> 
> I suggest removing from this patch, and if required add with another patch
> that both updates default.ini and this documented.

I agree it makes more sense to have this "feature" on a different patch. 

> 
> > +
> > +Supports optimization for fast release of mbufs following successful Tx.
> > +Requires all mbufs to come from the same mempool and has refcnt = 1.
> > +
> > +* **[uses]       rte_eth_txconf,rte_eth_txmode**:
> ``offloads:DEV_TX_OFFLOAD_MBUF_FAST_FREE``.
> > +* **[provides]   rte_eth_dev_info**:
> ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_MBUF_FAST_
> FREE``.
> > +
> >  Timesync
> >  --------
> >
> > diff --git a/lib/librte_ether/rte_ethdev.c
> > b/lib/librte_ether/rte_ethdev.c index 9b73d2377..59756dd82 100644
> > --- a/lib/librte_ether/rte_ethdev.c
> > +++ b/lib/librte_ether/rte_ethdev.c
> 
> <...>